-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Feature: Silence skip #7797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Feature: Silence skip #7797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all the locale files. Only keep en-us
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Im a bit confused by this skip rate. Please elaborate why you chose for 2.5x instead of e.g. 10x Lets say the ending of a certain video is 60sec it will take 24sec to skip the silence. Thats way too long imo. Why not detect when there is no audio and detect when audio is playing again and instantly skip towards that timestamp instead of relying on playback rate to handle this |
The main goal of this feature is to skip (accelerate) silence between conversations, or other silent parts, not to fast forward to the end of a video. I'm not sure how to "detect when there is no audio and detect when audio is playing again and instantly skip towards that timestamp" . |
This implementation works really well, especially considering that our player is the limiting factor in this case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to be a button for this inside the player instead of outside the player
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Type
Related issue
closes #1766
Description
This PR implements a simple silence skip logic, to dynamically determine silent video parts, related to the individual max volume of the audio source.
Screenshots
2025-08-08.16-34-21.mp4
Testing
Desktop
Additional context