Fix playback rate reset when video ends

[caetano-dev]

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

Closes #7445

Description

Fixes a bug that made the video speed reset when the video ended.

These changes include a session storage to preserve the selected speed and a watch to monitor the currentPlaybackRate prop and keep it in sync.

Testing

1 - Open a video and set a custom speed.
2 - Let the video end.
3 - See that the video speed remains the same.

(previously, the speed would automatically reset to the default at the end)

Desktop

• OS: Linux
• OS Version: Ubuntu 24.04.2 LTS
• FreeTube version: v0.23.5 Beta

Additional context

It seems like the bug was happening because the Shaka Player replaces the <video> element's source when it loads a new manifest. This throws away the current playbackRate.

[efb4f5ff-1298-471a-8973-3d47447115dc]

fyi: havent forgotten about this one but i have made some notes on my issue you are trying to solve and the gist of it is that the issue is maybe running way deeper than i though. So i will investigate the notes first and come back to this

[efb4f5ff-1298-471a-8973-3d47447115dc]

So the other case that was listed in my notes and should be checked is playlists

1. Watch a playlist
2. Change playback rate
3. Video ends
4. Next video resets playback rate
5. Change playback rate again
6. Click on next video in Playlist
7. See that playback is saved

[caetano-dev]

Hello! It seems like it is working fine on this branch.

Here is my test on a playlist I created. The same behaviour was found on playlists from other channels.

video.mp4

[efb4f5ff-1298-471a-8973-3d47447115dc]

Could you rebase into dev so we can test this with working playback

[caetano-dev]

Rebased

[efb4f5ff-1298-471a-8973-3d47447115dc]

Functionally wise LGTM but i prefer @absidue to sign off code wise first

[absidue]

Please remove the sessionStorage code.

[caetano-dev]

Done!