`persistQuery` option doesn't work

[jakewisse]

It looks like the persistQuery option was first implemented in the Link component through referencing the existing state in the Redux store, but then later it was copied over to the reducer. However, I don't know how this was supposed to work since the middleware will call the history lib's push() function with the given search (updating the URL with the new query [empty or otherwise], wiping out the previous one), way before the data flow reaches the reducer.

It seems to me that the only way to resolve this for all possible implementations of the history API is to produce the actions module in install() which has the desired history impl. injected into it. Then, we could do the query merging¹ up front by referencing the state in history.state.

--
1: FWIW, when working on this it wasn't clear to me in the README whether persistQuery would merge the two queries (see #132), or if it would simply not throw away the previous one if not specifying a pathname.

[drKnoxy]

@tptee if you can guide a solution to this i'll get a PR submitted.

[tptee]

Fixed in v14.0.0-1. Real release coming soon!

[jakewisse]

Thanks @tptee! While this looks great for <Link>s, the persistQuery option should still not work for manually dispatching push(), correct?

[adamesque]

Although the merged PR does include reducer code, persistQuery doesn't appear to work for push() in our project. I'll see if I can create a reduction & then file a new issue.