Perf: Use more modern screen-reader only styles #796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: https://a11y-guidelines.orange.com/en/web/components-examples/accessible-hiding/. This also improves performance, since the previously used `left: -1000px` technique created huge layers when the div was close to (or overlapped) an element which got promoted to its own layer.
| overflow: 'hidden', | ||
| padding: 0, | ||
| margin: '-1px', | ||
| clip: 'rect(0, 0, 0, 0)', |
There was a problem hiding this comment.
clip is going to be deprecated and clip-path seems to be the new way to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See: https://a11y-guidelines.orange.com/en/web/components-examples/accessible-hiding/.
This improves performance, since the previously used
left: -1000pxtechnique created huge layers when the div was close to (or overlapped) an element which got promoted to its own layer.Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
See screenshot: https://prnt.sc/1qae4pk
After swapping the css, the layers are gone.
Checklist: (Feel free to delete this section upon completion)