Fix locking on big-endian architectures #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4e4d800 extended locks to have 64-bit keys in most cases, but some were left as 32-bit. However, code using these 32-bit locks assumed that the significant bytes of the key's long value started from lck_string[0], which is false on big-endian architectures. This commit adds Lock::getKeyString(), which gets a pointer to the first used byte of lck_string, and should be used in place of accessing lck_string directly.