Support adapter builds and add tests. #386
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @annajowang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the @apphosting/build package by implementing dynamic support for framework-specific build processes, starting with Next.js and Angular. It refactors the localbuild command to leverage dedicated framework adapters, ensuring that applications built with these frameworks are correctly processed. A new, robust end-to-end testing suite has been introduced to validate the integrity of the generated build artifacts, specifically the bundle.yaml configuration, across different framework scenarios.
Highlights
- Dynamic Adapter Builds: The
localbuildcommand has been enhanced to dynamically fetch and execute the appropriate framework adapter (e.g.,@apphosting/adapter-nextjs) usingnpx. This refactoring allows for extensible support of various frameworks without hardcoding build logic for each. - New
adapterBuildFunction: A new, dedicatedadapterBuildfunction was introduced to encapsulate the core logic for programmatically fetching adapter versions from npm and spawning their respective build commands, improving modularity and maintainability. - Comprehensive E2E Testing Suite: A comprehensive end-to-end testing framework has been added, comprising
run-local-build.ts,adapter-builds.spec.ts, andscenarios.ts. These tests automate the build process for Next.js and Angular starter applications and rigorously verify the correctness and integrity of the generatedbundle.yamlconfiguration. - Framework Whitelist: A
SupportedFrameworksconstant was added to the@apphosting/commonpackage. This explicit whitelist defines the frameworks currently supported by the app hosting build system, providing clarity and a single source of truth.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces support for framework adapter builds and adds a comprehensive end-to-end testing suite. The changes are well-structured, particularly the new testing scenarios. However, there are a few critical issues to address, such as a missing await for an async function and a logic error in the test script's error handling. I've also included several suggestions to improve code quality, consistency, and type safety.
| @@ -21,7 +21,9 @@ | |||
| "type": "module", | |||
| "sideEffects": false, | |||
| "scripts": { | |||
| "build": "rm -rf dist && tsc && chmod +x ./dist/bin/*" | |||
| "build": "rm -rf dist && tsc && chmod +x ./dist/bin/*", | |||
| "test": "npm run test:functional", | |||
There was a problem hiding this comment.
planning to add test:unit in followup CLs
| }, | ||
| "include": [ | ||
| "src/index.ts", | ||
| "src/bin/*.ts", | ||
| ], | ||
| "exclude": [ | ||
| "src/*.spec.ts" | ||
| "src/*.spec.ts", | ||
| "src/bin/build.ts" |
There was a problem hiding this comment.
this will be deleted soon. ignoring build errors here.
annajowang
requested review from
jamesdaniels,
Yuangwang and
sjjj986
and removed request for
sjjj986
annajowang
requested review from
a team,
sjjj986,
blidd-google,
taeold and
leoortizz
as code owners
Uh oh!
There was an error while loading. Please reload this page.