Angular use spec #261
Merged
Angular use spec #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuangwang
requested review from
sjjj986,
jamesdaniels,
tonyjhuang,
blidd-google,
taeold and
leoortizz
as code owners
tonyjhuang
approved these changes
Sep 26, 2024
| @@ -195,20 +186,20 @@ function generateEnvVars(angularVersion: string): EnvironmentVariable[] { | |||
|
|
|||
| // Generate bundle.yaml | |||
| async function generateBundleYaml( | |||
| outputBundleOptions: OutputBundleOptions, | |||
| opts: OutputBundleOptions, | |||
There was a problem hiding this comment.
optional nit: you can unpack the relevant fields here if you want
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new output bundle spec for Angular.
Also copies assets into dist directory instead of .apphosting