-
Notifications
You must be signed in to change notification settings - Fork 165
Fix apphosting/common in build/publish #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
MC-MAGA
approved these changes
Sep 12, 2024
blidd-google
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this - the publish flow has been slightly broken since we set up the @apphosting/common package, this will be a nice QOL improvement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing failures since the changes to
@apphosting/common
. It turns out that in lerna, for the dependency graph to pick up dependents / dependencies the version in the package.json dependencies needs to be in the form of*
*
, that's the easy part@apphosting/common
as a dependency of@apphosting/adapter-*
, so let's pin before we publish to the registry--include-dependencies
intobuild.js
--include-dependents
, changes to@apphosting/common
will still trigger@apphosting/adapter-*
tests to ensure we haven't introduced breaking changesLerna publish would do much of this all for us, if we were using that... but I don't like the loss of control we'd suffer there, seems too magic.