Skip to content

Update next.js bundle.yaml with env and metadata sections #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Sep 3, 2024
Merged

Update next.js bundle.yaml with env and metadata sections #248

merged 28 commits into from
Sep 3, 2024

Conversation

sjjj986
Copy link
Collaborator

@sjjj986 sjjj986 commented Aug 28, 2024

  • pass user's nextjs version from framework buildpack
  • add an empty env section
  • add a metadata section with adapter & nextjs metrics
  • refactor bundle.yaml test

sjjj986 and others added 25 commits August 21, 2024 15:55
@sjjj986
Add metadata to angular bundle.yaml
4aac093 
Add a framework metadata section to Angular adapter's bundle.yaml output:
 - adapter name
 - adapter version
 - framework name
 - framework version
@sjjj986
Refactor for unit tests
08b6d83
@sjjj986
make adapterVersion mandatory
528272e
@sjjj986
backslash escape
7b41b4e
@sjjj986
escape fix
844e136
@sjjj986
lint
c24bd41
@sjjj986
comment
6112326
@sjjj986
refactor
403f95f
@sjjj986
match FRAMEWORK_VERSION name with buildpack
3f8dbca
@sjjj986
Merge branch 'main' into sj-framework-metadata
0de4769
@sjjj986
fix comments
e7e260b
@sjjj986
Merge branch 'sj-framework-metadata' of https://github.com/FirebaseEx…
7813827 
…tended/firebase-framework-tools into sj-framework-metadata
@sjjj986
Make angularVersion mandatory and assert
40410ea
@sjjj986
modify metadata interface
239c0ba
@sjjj986
Revert "modify metadata interface"
40a355a 
This reverts commit 239c0ba.
@sjjj986
Fix backslash escape
38e2206
@sjjj986
fix test
9ed9cbb
@sjjj986
Update env var test
3b2935c
@sjjj986
Merge branch 'main' into sj-framework-metadata
fe3c668
@sjjj986
Move angularVersion assert
e12f0d4
@sjjj986
Merge branch 'sj-framework-metadata' of https://github.com/FirebaseEx…
9bfa136 
…tended/firebase-framework-tools into sj-framework-metadata
@sjjj986
Remove adapter name @ escape
42b0388
@sjjj986
move assert
04d5274
@sjjj986
Update next.js bundle.yaml with env and metadata sections
c397b97 
- pass user's nextjs version from framework buildpack
- add an empty env section
- add a metadata section with adapter & nextjs metrics
- refactor bundle.yaml test
@sjjj986
lint
1614e5c
@sjjj986 sjjj986 marked this pull request as ready for review August 28, 2024 14:53
@sjjj986 sjjj986 requested a review from taeold as a code owner August 28, 2024 14:53
tonyjhuang
tonyjhuang requested changes Aug 28, 2024
View reviewed changes
@sjjj986 sjjj986 changed the base branch from sj-framework-metadata to main September 3, 2024 04:51
@sjjj986 sjjj986 merged commit 95d529f into main Sep 3, 2024
9 checks passed
@sjjj986 sjjj986 deleted the sj-nextjs-metadata branch September 3, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyjhuang tonyjhuang tonyjhuang approved these changes

@Yuangwang Yuangwang Awaiting requested review from Yuangwang Yuangwang is a code owner

@jamesdaniels jamesdaniels Awaiting requested review from jamesdaniels jamesdaniels is a code owner

@blidd-google blidd-google Awaiting requested review from blidd-google blidd-google is a code owner

@taeold taeold Awaiting requested review from taeold taeold is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjjj986 @tonyjhuang