Add metadata to angular bundle.yaml #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

sjjj986 merged 24 commits into main from sj-framework-metadata

Sep 3, 2024

Collaborator

sjjj986 commented Aug 21, 2024

Add a framework metadata section to Angular adapter's bundle.yaml:

adapter name
adapter version
framework name
framework version

sjjj986 added 2 commits

August 21, 2024 15:55


          Add metadata to angular bundle.yaml

4aac093

Add a framework metadata section to Angular adapter's bundle.yaml output:
 - adapter name
 - adapter version
 - framework name
 - framework version


          Refactor for unit tests

08b6d83

github-advanced-security bot found potential problems

View reviewed changes

packages/@apphosting/adapter-angular/src/utils.ts Fixed Show fixed Hide fixed


          make adapterVersion mandatory

528272e

github-advanced-security bot found potential problems

View reviewed changes

packages/@apphosting/adapter-angular/src/utils.ts Fixed Show fixed Hide fixed

sjjj986 added 2 commits

August 26, 2024 18:17


          backslash escape

7b41b4e


          escape fix

844e136

github-advanced-security bot found potential problems

View reviewed changes

packages/@apphosting/adapter-angular/src/utils.ts Fixed Show fixed Hide fixed


          lint

c24bd41

github-advanced-security bot found potential problems

View reviewed changes

packages/@apphosting/adapter-angular/src/utils.ts Fixed Show fixed Hide fixed


          comment

github-advanced-security bot found potential problems

View reviewed changes

packages/@apphosting/adapter-angular/src/utils.ts Fixed Show fixed Hide fixed

sjjj986 and others added 3 commits

August 26, 2024 18:53


          refactor

403f95f


          match FRAMEWORK_VERSION name with buildpack

3f8dbca


          Merge branch 'main' into sj-framework-metadata

0de4769

sjjj986 marked this pull request as ready for review

August 26, 2024 23:28

sjjj986 requested review from Yuangwang, jamesdaniels, tonyjhuang and blidd-google as code owners

August 26, 2024 23:28

tonyjhuang requested changes

View reviewed changes

packages/@apphosting/adapter-angular/src/utils.ts Outdated Show resolved Hide resolved

packages/@apphosting/adapter-angular/src/utils.ts Outdated Show resolved Hide resolved

packages/@apphosting/adapter-angular/src/utils.ts Outdated Show resolved Hide resolved

packages/@apphosting/adapter-angular/src/utils.ts Outdated Show resolved Hide resolved

packages/@apphosting/adapter-angular/src/utils.ts Outdated Show resolved Hide resolved

packages/@apphosting/adapter-angular/src/utils.ts Outdated Show resolved Hide resolved

sjjj986 added 2 commits

August 27, 2024 13:19


          fix comments

e7e260b


          Merge branch 'sj-framework-metadata' of https://github.com/FirebaseEx…

…tended/firebase-framework-tools into sj-framework-metadata

github-advanced-security bot found potential problems

View reviewed changes

packages/@apphosting/adapter-angular/src/utils.ts Fixed Show resolved Hide resolved

tonyjhuang requested changes

View reviewed changes

packages/@apphosting/adapter-angular/src/utils.ts Outdated Show resolved Hide resolved

packages/@apphosting/adapter-angular/src/utils.ts Outdated Show resolved Hide resolved

packages/@apphosting/adapter-angular/src/utils.ts Outdated Show resolved Hide resolved

packages/@apphosting/adapter-angular/src/utils.ts Fixed Show resolved Hide resolved

packages/@apphosting/adapter-angular/src/utils.ts Outdated Show resolved Hide resolved

packages/@apphosting/adapter-angular/src/bin/build.spec.ts Outdated Show resolved Hide resolved


          Make angularVersion mandatory and assert

40410ea

sjjj986 requested a review from taeold as a code owner

August 27, 2024 19:01

sjjj986 added 3 commits

August 27, 2024 15:06


          modify metadata interface

239c0ba


          Revert "modify metadata interface"

40a355a

This reverts commit 239c0ba.


          Fix backslash escape

38e2206

sjjj986 and others added 3 commits

August 27, 2024 16:18


          fix test

9ed9cbb


          Update env var test

3b2935c


          Merge branch 'main' into sj-framework-metadata

fe3c668

tonyjhuang requested changes

View reviewed changes

packages/@apphosting/adapter-angular/src/bin/build.spec.ts Outdated Show resolved Hide resolved

packages/@apphosting/adapter-angular/src/utils.ts Outdated Show resolved Hide resolved

packages/@apphosting/adapter-angular/src/utils.ts Outdated Show resolved Hide resolved

packages/@apphosting/adapter-angular/src/utils.ts Outdated Show resolved Hide resolved

tonyjhuang reviewed

View reviewed changes

packages/@apphosting/adapter-angular/src/utils.ts Outdated Show resolved Hide resolved

sjjj986 added 4 commits

August 27, 2024 17:55


          Move angularVersion assert

e12f0d4


          Merge branch 'sj-framework-metadata' of https://github.com/FirebaseEx…

9bfa136

…tended/firebase-framework-tools into sj-framework-metadata


          Remove adapter name @ escape

42b0388


          move assert

04d5274

tonyjhuang approved these changes

View reviewed changes

Collaborator

tonyjhuang left a comment

Thanks for the changes!

Yuangwang approved these changes

View reviewed changes


          Make adapter name field more generic

3cfbecb

sjjj986 merged commit b3553de into main

9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tonyjhuang tonyjhuang approved these changes

Yuangwang Yuangwang approved these changes

jamesdaniels Awaiting requested review from jamesdaniels jamesdaniels is a code owner

blidd-google Awaiting requested review from blidd-google blidd-google is a code owner

taeold Awaiting requested review from taeold taeold is a code owner

Labels

None yet