14.0.15 breaks nextjs in monorepo

[mehranabi]

PR #346 breaks nextjs rollouts in a monorepo setup.

We have our next app at apps/web and the build output is apps/web/.next/standalone but in #346 the adapter only picks root .next/standalone.
The build passes successfully but the files are not copied over so the container doesn't run properly and the rollout fails.

The workaround is to add outputFiles manually in apphosting.yml:

outputFiles:
  serverApp:
    include: [.]

the config above copied all files that might make your container to run late for health check, put your real standalone output path instead of .

14.0.13 was ok

[dmitryplatonov]

Can confirm the issue. Fails to include files in @apphosting/adapter-nextjs 14.0.15, was working fine with 14.0.13.
Also nx monorepo.
This workaround worked for me:

apphosting.yaml

outputFiles:
  serverApp:
    include:
      - apps/web/.next/standalone

[colin-chadwick]

Same issue here.

[mathu97]

@mehranabi thanks for flagging this! We're in the process of reverting the change until we have a fix for this bug. Are you able to provide some more information on your setup?

1. Where is your apphosting.yaml file placed? Is it at the root directory or in apps/web?
2. Do you have a root directory defined?

[mathu97]

We've published a new adapter version that reverts the breaking change (14.0.16). Things should be working as they were previously.

[dmitryplatonov]

In my case:
apphosting.yaml is placed at the root.
Root directory is defined.

[mehranabi]

Here's our project structure:

my-project/
├── package.json
├── yarn.lock
├── nx.json
├── firebase.json
├── apps/
│   ├── api/
│   │   ├── package.json
│   │   └── src/
│   ├── functions/
│   │   ├── package.json
│   │   └── src/
│   └── web/
│       ├── package.json
│       ├── apphosting.yaml
│       ├── apphosting.staging.yaml
│       ├── project.json (nx project config)
│       └── src/

We use Yarn Workspaces and each directory in apps/ is a workspace.
We also used Nx only for Firebase Apphosting to detect monorepo setup of our project.
We set the app root in Firebase Apphosting to apps/web.

[TheAllSeeingPie]

@mathu97 hey, whatever was changed 3 days ago seems to have broken my builds for AppHosting. Whether I use the backend "automatic rollouts" or the firebase-tools generated "hosting" versions, my containers and functions are borking with the following:

Error: Cannot find module '/workspace/index.js'
at Function._resolveFilename (node:internal/modules/cjs/loader:1401:15)
at defaultResolveImpl (node:internal/modules/cjs/loader:1057:19)
at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1062:22)
at Function._load (node:internal/modules/cjs/loader:1211:37)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:171:5)
at node:internal/main/run_main_module:36:49 {

I've made no changes to any config (until after it broke and was trying to resolve it).

Is there some side-effect of this change that is causing packaging issues?

[mathu97]

@TheAllSeeingPie is this a NextJS app in a NX monorepo set up? If not I suggest creating a support ticket with additional detail so someone from our team can take a look at it. It may be a different problem.

[TheAllSeeingPie]

@TheAllSeeingPie is this a NextJS app in a NX monorepo set up? If not I suggest creating a support ticket with additional detail so someone from our team can take a look at it. It may be a different problem.

It wasn't in a NX monorepo and had been stable in production for months until this release. However moving to a NX monorepo appears to have fixed my problems.