Emit disconnect event when network connection is lost #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a77850f.
JosephusPaye
approved these changes
Oct 22, 2025
Contributor
JosephusPaye
left a comment
JosephusPaye
left a comment
There was a problem hiding this comment.
LGTM!
We can revisit to handle specific errors (instead of treating all errors as network errors that require a disconnect) later, if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
NUClearNetclass to emit a 'disconnect' event when network connection is lost during packet processing.This will allow users of the class to handle errors properly instead of crashing when an error occurs during packet processing.