Skip to content

Conversation

OmegaWeaponDev
Copy link
Contributor

@OmegaWeaponDev OmegaWeaponDev commented Dec 24, 2020

Re-upload of the #3680 pull request as github was being a pain and wouldn't get me commit to the PR for some reason.

Closes #3353

JRoy
JRoy previously approved these changes Dec 24, 2020
@JRoy JRoy added the type: enhancement Features and feature requests. label Dec 24, 2020
@JRoy JRoy added this to the 2.19.0 milestone Dec 24, 2020
@JRoy JRoy changed the title PR: Cancel Afk On Chat - Re-done Cancel afk on chat Dec 24, 2020
@JRoy JRoy changed the title Cancel afk on chat Add option to cancel afk on chat Jan 1, 2021
@JRoy JRoy changed the title Add option to cancel afk on chat Separate option to cancel afk on chat from interact Jan 1, 2021
@JRoy JRoy merged commit a8daa21 into EssentialsX:2.x Jan 1, 2021
@mibby
Copy link

mibby commented Feb 13, 2021

@JRoy This PR seems to make the AFK status change / message occur after a chat message is sent. Is there any possibility of moving this logic around so players go unafk first, followed by their message afterwards to match older Essentials behavior? Primarily to prevent someone returning from being AFK and immediately having their chat line thrown behind their afk status change one.

Here's a screenshot I found showing the old logic.
link

@JRoy
Copy link
Member

JRoy commented Feb 13, 2021

@JRoy This PR seems to make the AFK status change / message occur after a chat message is sent. Is there any possibility of moving this logic around so players go unafk first, followed by their message afterwards to match older Essentials behavior? Primarily to prevent someone returning from being AFK and immediately having their chat line thrown behind their afk status change one.

Here's a screenshot I found showing the old logic.
link

Could you open a separate issue to track this? It's not that simple of a fix because this PR also fixed some unsafe concurrency issues so I can't just revert it.

PS: Can you reply to #3974 (comment) :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Features and feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AFK not cancelled on chat event when "cancel-afk-on-interact" is false
3 participants