Skip to content

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented May 17, 2020

Fixes #2342

@pop4959 pop4959 added the type: enhancement Features and feature requests. label May 17, 2020
Copy link
Member

@pop4959 pop4959 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this out, but there seems like there is a bug checking stack sizes. If you do /more 1 with a stack of 63, you get an error, even though 64 is a valid default stack.

Honestly, I'd avoid adding these new errors, because they aren't very user friendly. In the case, for example, where I have a stack of 50, and use /more 20, I would personally prefer either 1) receiving a stack that is at it's maximum size (either default or over sized) or 2) receive that maximum stack (64), but then another stack in addition (6), given that inventory space permits.

PS: Do over sized stacks even work anymore? I thought they were patched out some time ago.

@JRoy JRoy requested a review from pop4959 May 17, 2020 16:23
@JRoy
Copy link
Member Author

JRoy commented May 17, 2020

@pop4959 Changes Applied

Do oversized stacks even work anymore? I thought they were patched out some time ago.

I know some clients can go over 64, but this is more intended for items like ender pearls or totems which are limited to stack sizes or 16 and 1 respectively which the client will happily handle bigger stack sizes for.

@JRoy JRoy requested a review from pop4959 June 15, 2020 14:40
@JRoy
Copy link
Member Author

JRoy commented Jun 15, 2020

@pop4959 changes applied

pop4959
pop4959 previously approved these changes Jun 16, 2020
@pop4959 pop4959 requested a review from mdcfe June 16, 2020 00:54
pop4959
pop4959 previously approved these changes Jun 22, 2020
@JRoy JRoy requested a review from mdcfe July 5, 2020 13:16
@mdcfe mdcfe merged commit 1a6ad2f into EssentialsX:2.x Jul 6, 2020
@mdcfe mdcfe deleted the feature/enchanced-more branch July 6, 2020 18:55
@pop4959 pop4959 added this to the 2.18.0 milestone Jul 6, 2020
JRoy added a commit to JRoy/Essentials-PR that referenced this pull request Aug 30, 2020
ressidell pushed a commit to ressidell/Essentials that referenced this pull request Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement Features and feature requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow specifying amount in /more

3 participants