-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Allow for specifying amount to increase itemstack in /more #3302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried this out, but there seems like there is a bug checking stack sizes. If you do /more 1
with a stack of 63, you get an error, even though 64 is a valid default stack.
Honestly, I'd avoid adding these new errors, because they aren't very user friendly. In the case, for example, where I have a stack of 50, and use /more 20
, I would personally prefer either 1) receiving a stack that is at it's maximum size (either default or over sized) or 2) receive that maximum stack (64), but then another stack in addition (6), given that inventory space permits.
PS: Do over sized stacks even work anymore? I thought they were patched out some time ago.
@pop4959 Changes Applied
I know some clients can go over 64, but this is more intended for items like ender pearls or totems which are limited to stack sizes or 16 and 1 respectively which the client will happily handle bigger stack sizes for. |
Essentials/src/com/earth2me/essentials/commands/Commandmore.java
Outdated
Show resolved
Hide resolved
@pop4959 changes applied |
Fixes #2342