Add config option to make currency symbol as a suffix #3066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pop4959
previously approved these changes
Mar 13, 2020
There was a problem hiding this comment.
Looks good to me. Minor nitpick: perhaps consider making the methods "is" instead of "get" since this is not getting a suffix, but rather getting if it is a suffix. May make the code easier to understand. Although, I do acknowledge that it seems existing settings use a mix of both, so either works I guess.
|
Yeah I wanted to retain current code style even if it is bad :P. That probably shouldn't be changed unless everything is |
Ichbinjoe
reviewed
Mar 31, 2020
|
Alright I made that code more readable and rebased |
mdcfe
requested changes
Apr 23, 2020
mdcfe
approved these changes
Apr 25, 2020
ressidell
pushed a commit
to ressidell/Essentials
that referenced
this pull request
Apr 27, 2025
Adds `currency-symbol-suffix` config option to move the currency symbol as a suffix rather than a prefix. Closes EssentialsX#2577.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
currency-symbol-suffixconfig option to move the currency symbol as a suffix rather than a prefixCloses #2577