Make drop-items-if-full work on Essentials kits #2820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caojohnny
suggested changes
Oct 14, 2019
| return addItems(fakeInventory, items); | ||
| } | ||
|
|
||
| public static Map<Integer, ItemStack> addAllOversizedItems(final Inventory inventory, final int oversizedStacks, final ItemStack... items) { |
There was a problem hiding this comment.
Why can't this just be a Collection<ItemStack>? That way, you can simply pass in the ArrayList from above without needing to do a cumbersome toArray(...).
There was a problem hiding this comment.
It could be, but then we should be changing addAllItems and any other usages of it as well. I'm not sure if such a change is appropriate for this pull request or not.
caojohnny
approved these changes
Oct 15, 2019
Ichbinjoe
approved these changes
Dec 29, 2019
mdcfe
reviewed
Dec 31, 2019
The addAllItems function uses a copy of the inventory first to check if everything will fit, and then only adds the items if they all fit in the inventory copy. So no, the items won't be added if only some of them fit. |
mdcfe
approved these changes
Dec 31, 2019
ressidell
pushed a commit
to ressidell/Essentials
that referenced
this pull request
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2736
This changes the way the kit command works by creating an ArrayList of items and making sure all can be added before giving the kit if drop-items-if-full is false. Works with oversized stacks.
More testing is recommended. I believe I have included proper economy support, but haven't actually tested it because I don't have an economy plugin on my test server right now. This is also a fairly significant change to the way this command works, so more testing is always better.