Add settings to protect items from explosions #2504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdcfe
requested changes
Apr 24, 2019
Ichbinjoe
requested changes
Apr 24, 2019
EssentialsProtect/src/com/earth2me/essentials/protect/EssentialsProtectBlockListener.java
Show resolved
Hide resolved
Ichbinjoe
added
the
status: waiting on author
|
pretty sure these changes are merge-ready, why is the status waiting on author? |
If @md678685 wants to take it as is its up to him. |
Ichbinjoe
previously approved these changes
Mar 31, 2020
|
@md678685 Need one of those fancy dancy stamps to merge this :) |
mdcfe
approved these changes
Apr 14, 2020
mdcfe
requested changes
Apr 14, 2020
EssentialsProtect/src/com/earth2me/essentials/protect/ProtectConfig.java
Outdated
Show resolved
Hide resolved
JRoy
requested changes
May 22, 2020
EssentialsProtect/src/com/earth2me/essentials/protect/ProtectConfig.java
Outdated
Show resolved
Hide resolved
JRoy
previously approved these changes
May 22, 2020
Ichbinjoe
previously approved these changes
May 22, 2020
pop4959
requested changes
May 27, 2020
Essentials/src/config.yml
Outdated
| water-bucket-flow: false | ||
| fire-spread: true | ||
| lava-fire-spread: true | ||
| lava-itemdamage: true |
There was a problem hiding this comment.
I would recommend this be set to false by default, because this is a change which is going to take many server owners by surprise, especially if they are trying to run a fairly standard vanilla survival server.
Essentials/src/config.yml
Outdated
| portal-creation: false | ||
| tnt-explosion: false | ||
| tnt-playerdamage: false | ||
| tnt-itemdamage: true |
| public enum ProtectConfig { | ||
| disable_contactdmg("protect.disable.contactdmg", false), | ||
| disable_lavadmg("protect.disable.lavadmg", false), | ||
| disable_lava_item_dmg("protect.prevent.lava-itemdamage", true), |
pop4959
approved these changes
Jun 15, 2020
mdcfe
approved these changes
Jun 15, 2020
mdcfe
changed the title
JRoy
pushed a commit
to JRoy/Essentials-PR
that referenced
this pull request
Aug 30, 2020
Co-authored-by: Josh Roy <[email protected]> Co-authored-by: pop4959 <[email protected]> Adds protection settings to Protect to block item damage when entities such as wither skulls, fireballs, TNT and creepers explode. Closes EssentialsX#2284.
ressidell
pushed a commit
to ressidell/Essentials
that referenced
this pull request
Apr 27, 2025
Co-authored-by: Josh Roy <[email protected]> Co-authored-by: pop4959 <[email protected]> Adds protection settings to Protect to block item damage when entities such as wither skulls, fireballs, TNT and creepers explode. Closes EssentialsX#2284.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to #2284. I reworked my fork so that it's better suited since I sort of screwed the other.
Adds protection values to Essentials Protect blocking item damage when entities such as wither skulls; fireballs; TNT explode.
Closes #2284