Skip to content

Conversation

@tommie
Copy link
Contributor

@tommie tommie commented Jun 26, 2024

Having to wrap it all as a string is a bit strange, and an example helps.

(I don't actually think the JSON.parse is needed, because the YAML flow sequence syntax handles that case too: https://yaml.org/spec/1.2.2/#741-flow-sequences)

Having to wrap it all as a string is a bit strange, and an example helps.

I don't actually think the `JSON.parse` is needed, because the YAML flow sequence syntax handles that case too: https://yaml.org/spec/1.2.2/#741-flow-sequences
@EndBug EndBug merged commit ccb0550 into EndBug:main Jun 28, 2024
@EndBug EndBug mentioned this pull request Jun 28, 2024
@EndBug
Copy link
Owner

EndBug commented Jun 28, 2024

Hey! Thanks for the PR!
I think you're right, JSON parsing is redundant! I've opened #646 to keep track of that, as I don't have time to address that at the moment 😅

@all-contributors please add @tommie for their doc contribution :)

@allcontributors
Copy link
Contributor

@EndBug

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @tommie! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants