fix(progress): don't finish before update #732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: "Load workspace" progress is updated after finishing, triggering errors in clients (e.g. Neovim). (Regression introduced in f7b400c) Solution: Correct sequencing of `update_progress` and `finish_progress`. Also make `finish_progress` message for diagnostics consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: "Load workspace" progress is updated after finishing,
triggering errors in clients (e.g. Neovim).
(Regression introduced in f7b400c)
Solution: Correct sequencing of
update_progressandfinish_progress.Also make
finish_progressmessage for diagnostics consistent.