Skip to content

Conversation

CppCXY
Copy link
Member

@CppCXY CppCXY commented Jun 4, 2025

No description provided.

@CppCXY CppCXY marked this pull request as draft June 5, 2025 02:40
@CppCXY CppCXY force-pushed the refactor-flow branch 2 times, most recently from 9e59644 to c7ad0f3 Compare June 16, 2025 05:46
@CppCXY CppCXY force-pushed the refactor-flow branch 2 times, most recently from 1bb9262 to fe866be Compare June 23, 2025 09:48
@CppCXY CppCXY force-pushed the refactor-flow branch 2 times, most recently from 31600e6 to fcfa142 Compare July 1, 2025 12:23
@CppCXY CppCXY marked this pull request as ready for review July 8, 2025 07:20
@CppCXY CppCXY merged commit 03817bb into main Jul 8, 2025
14 checks passed
@clason
Copy link
Contributor

clason commented Jul 8, 2025

Sorry to comment here, but after this got merged I see a performance regression when running emmylua_check on the top-level directory of a repo: The actual lua files get checked quickly (no regression there), but then it just "freezes" for a second or two before exiting (with code 1). Checking only the lua subdirectory is fast (although there might also be a delay, it's too short to measure).

Do you have any suggestion how to debug this?

@CppCXY
Copy link
Member Author

CppCXY commented Jul 8, 2025

Sorry to comment here, but after this got merged I see a performance regression when running emmylua_check on the top-level directory of a repo: The actual lua files get checked quickly (no regression there), but then it just "freezes" for a second or two before exiting (with code 1). Checking only the lua subdirectory is fast (although there might also be a delay, it's too short to measure).

Do you have any suggestion how to debug this?

which repo?

@clason
Copy link
Contributor

clason commented Jul 8, 2025

https://github.com/nvim-treesitter/nvim-treesitter/tree/main (main branch)

with a local .emmyluarc.json on top:

{
  "workspace" : {
    "ignoreDir": [ "lua/nvim-treesitter/async.lua" ]
  },
  "diagnostics" : {
    "disable" : [
      "unnecessary-if",
      "unnecessary-assert",
      "duplicate-require"
    ]
  },
  "strict": {
    "typeCall": true,
    "arrayIndex": true
  }
}

@CppCXY
Copy link
Member Author

CppCXY commented Jul 8, 2025

I’ll test it tomorrow when I have time. I’m getting off work now.

@clason
Copy link
Contributor

clason commented Jul 9, 2025

Now the check is instant again! Thanks for the very fast fix!

@CppCXY CppCXY deleted the refactor-flow branch July 24, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants