refactor member design #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the member design in the code analysis component by removing legacy merge functions and replacing them with new binding functions (bind_type and add_member) that streamline type resolution. Key changes include:
- Replacing merge_decl_expr_type and merge_member_type calls with bind_type across multiple modules.
- Updating member owner handling to use add_member.
- Removing the deprecated merge_type module.
Reviewed Changes
Copilot reviewed 65 out of 65 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/emmylua_code_analysis/src/compilation/analyzer/unresolve/resolve.rs | Converted merge functions to bind_type and added member binding logic |
| crates/emmylua_code_analysis/src/compilation/analyzer/unresolve/mod.rs | Removed merge_type module references |
| crates/emmylua_code_analysis/src/compilation/analyzer/unresolve/merge_type.rs | Removed unused merge functions |
| crates/emmylua_code_analysis/src/compilation/analyzer/lua/stats.rs | Updated local stat and assign stat processing with bind_type |
| crates/emmylua_code_analysis/src/compilation/analyzer/bind_type/mod.rs | Introduced new bind_type function with type merging logic and member migration |
| Various doc, flow, and decl modules | Adjusted to use new binding APIs and removed legacy merge calls |
| CHANGELOG.md | Updated version to 0.7.0 (unreleased) with refactor notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.