diagnostic

crates/emmylua_code_analysis/src/diagnostic/checker/undefined_global.rs

@@ -92,15 +92,17 @@ fn check_name_expr(
 }
 
 fn check_self_name(semantic_model: &SemanticModel, name_expr: LuaNameExpr) -> Option<()> {
-    let closure_expr = name_expr.ancestors::<LuaClosureExpr>().next()?;
-    let signature_id = LuaSignatureId::from_closure(semantic_model.get_file_id(), &closure_expr);
-    let signature = semantic_model
-        .get_db()
-        .get_signature_index()
-        .get(&signature_id)?;
-    if signature.is_method() {
-        return Some(());
-    } else {
-        None
+    let closure_expr = name_expr.ancestors::<LuaClosureExpr>();
+    for closure_expr in closure_expr {
+        let signature_id =
+            LuaSignatureId::from_closure(semantic_model.get_file_id(), &closure_expr);
+        let signature = semantic_model
+            .get_db()
+            .get_signature_index()
+            .get(&signature_id)?;
+        if signature.is_method() {
+            return Some(());
+        }
     }
+    None
 }

crates/emmylua_code_analysis/src/diagnostic/test/mod.rs

@@ -17,3 +17,4 @@ mod syntax_error_test;
 mod unbalanced_assignments_test;
 mod undefined_doc_param_test;
 mod undefined_field_test;
+mod undefined_global_test;

crates/emmylua_code_analysis/src/diagnostic/test/undefined_global_test.rs

@@ -0,0 +1,23 @@
+#[cfg(test)]
+mod test {
+    use crate::{DiagnosticCode, VirtualWorkspace};
+
+    #[test]
+    fn test_issue_250() {
+        let mut ws = VirtualWorkspace::new_with_init_std_lib();
+        assert!(ws.check_code_for(
+            DiagnosticCode::UndefinedGlobal,
+            r#"
+            --- @class A
+            --- @field field any
+            local A = {}
+
+            function A:method()
+            pcall(function()
+                return self.field
+            end)
+            end
+            "#
+        ));
+    }
+}