Skip to content

chore(bw): refactor and cleanup of code #6481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 18, 2025
Merged

chore(bw): refactor and cleanup of code #6481

merged 6 commits into from
Oct 18, 2025

Conversation

@philmoz
Copy link
Collaborator

@philmoz philmoz commented Jul 28, 2025

Reduce code duplication and general cleanup.

@philmoz philmoz added this to the 3.0 milestone Jul 28, 2025
@philmoz philmoz added B&W Related generally to black and white LCD radios house keeping 🧹 Cleanup of code and house keeping labels Jul 28, 2025
@philmoz philmoz marked this pull request as draft July 28, 2025 06:37
@philmoz philmoz force-pushed the philmoz/bw-menu-cleanup branch 3 times, most recently from 7d153d8 to 429257e Compare July 30, 2025 03:34
@philmoz philmoz force-pushed the philmoz/bw-menu-cleanup branch from 429257e to fab68c7 Compare August 8, 2025 00:56
@philmoz philmoz force-pushed the philmoz/bw-menu-cleanup branch 3 times, most recently from 179e6c0 to e252b1d Compare September 20, 2025 08:59
@philmoz philmoz force-pushed the philmoz/bw-menu-cleanup branch 2 times, most recently from 97e1e3f to d926741 Compare October 2, 2025 03:45
@philmoz philmoz marked this pull request as ready for review October 2, 2025 03:45
@philmoz philmoz force-pushed the philmoz/bw-menu-cleanup branch 3 times, most recently from 6ebea6b to 3b12bc6 Compare October 11, 2025 00:39
@philmoz philmoz force-pushed the philmoz/bw-menu-cleanup branch from 3b12bc6 to 5f5e999 Compare October 17, 2025 09:29
@pfeerick
Copy link
Member

The only readily apparent oddity I have encountered with this is probably stems from #6502 ... grab yourself a bw128x64 (i.e. Boxer), and pull up the popup menu for either the logical switches or special functions lines (or in when editing curves)... "Clear" / TR_CLEAR has been buttonised when it shouldn't be.

@philmoz philmoz force-pushed the philmoz/bw-menu-cleanup branch from 5f5e999 to 23efc08 Compare October 18, 2025 04:46
@philmoz
Copy link
Collaborator Author

philmoz commented Oct 18, 2025

The only readily apparent oddity I have encountered with this is probably stems from #6502 ... grab yourself a bw128x64 (i.e. Boxer), and pull up the popup menu for either the logical switches or special functions lines (or in when editing curves)... "Clear" / TR_CLEAR has been buttonised when it shouldn't be.

Thanks, should be fixed now.

@pfeerick
Copy link
Member

Thanks! :) What looks to be a GitHub resource starvation issue is really starting to get on my nerves now... 🤮 😬

@pfeerick pfeerick merged commit e904da8 into main Oct 18, 2025
29 of 47 checks passed
@pfeerick pfeerick deleted the philmoz/bw-menu-cleanup branch October 18, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

B&W Related generally to black and white LCD radios house keeping 🧹 Cleanup of code and house keeping

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@philmoz @pfeerick