Jon/fix/same addr swap #5706
Jon/fix/same addr swap #5706
Conversation
| /> | ||
| )) | ||
| return | ||
| } catch (e) { |
There was a problem hiding this comment.
Doesn't ESLint require this to be (e: unknown)?
There was a problem hiding this comment.
I didn't get any linter warnings here...
There was a problem hiding this comment.
@typescript-eslint/use-unknown-in-catch-callback-variable, applies to Promise .catch(...) callback parameters, not try { ... } catch (e) { ... }. It will not flag a try/catch clause.
The TypeScript option useUnknownInCatchVariables: true (true by default) only changes the inferred type of the catch variable to unknown. It does not require an explicit : unknown annotation and does not warn at the catch site. Errors will appear only where you use e unsafely (for example, e.message without narrowing), not at catch (e).
Jon-edge
force-pushed
the
jon/fix/same-addr-swap
branch
2 times, most recently
from
605ea20 to
54e173a
Compare
swansontec
left a comment
swansontec
left a comment
There was a problem hiding this comment.
Looks like not all the comments from the first review got addressed.
| /> | ||
| )) | ||
| return | ||
| } catch (e) { |
Jon-edge
force-pushed
the
jon/fix/same-addr-swap
branch
4 times, most recently
from
3e5239e to
b4db080
Compare
Jon-edge
force-pushed
the
jon/fix/same-addr-swap
branch
from
b4db080 to
b181189
Compare
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: