Capability to match strings within an array #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking if value in searched object is an array, if true, runs matcher on each item in the array.
| * Checks if pattern matches any of the strings in an array | ||
| * | ||
| * @param {string} str | ||
| * @param {array} strArray |
Contributor
There was a problem hiding this comment.
please declare explicitly that strArray has to be an array of strings: string[] or (preferably) Array.<string>.
Otherwise the function does not do what it claims to do
Contributor
|
@lalooola thank you for contributing! Please apply the changes I suggested in comments, squash them into the original commit and this one can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the capability to be able to search a field where the value is an array. Matcher will run for each item in the array and return true with a partial match.