Add function to calc_stf.py #180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added function "calc_meridional_stf_dens" Equivalent to "calc_meridional_stf" but in density space rather than depth space.
corrected typo: utot -> u in strmfxn density loop
|
Hi @clarkzimm , sorry I didn't see this before! This is a great addition to ecco_v4_py. One question I have: it seems like you added the function calc_meridional_stf_dens to the calc_stf.py module as well as a new module calc_meridional_trsp_isopycnals.py. Do we need it in both, or perhaps pick one module to include it in? |
|
hi @andrewdelman , yes, I originally added it to calc_stf.py, but Ian Fenty reccommend I make it it's own thing so I made the calc)meridional_trsp_isopycnals.py. We do not need both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added function "calc_meridional_stf_dens"
Equivalent to "calc_meridional_stf" but in density space rather than depth space.