CSHARP-4157: Add FLE 2 API to ClientEncryptionOpts. #174
Conversation
| encryptedFieldsMap: encryptedFieldsBytes, | ||
| schema: schemaBytes, | ||
| bypassQueryAnalysis: _bypassQueryAnalysis.GetValueOrDefault(false), | ||
| csfleLibPath: "", |
DmitryLukyanov
force-pushed
the
csharp4157
branch
from
ebd413f to
b742ef7
Compare
BorisDog
left a comment
BorisDog
left a comment
There was a problem hiding this comment.
LGTM (see minor comment)
|
|
||
| if (autoEncryptionOptionsConfigurator != null) | ||
| { | ||
| configuredSettings.AutoEncryptionOptions = autoEncryptionOptionsConfigurator?.Invoke(configuredSettings.AutoEncryptionOptions); |
There was a problem hiding this comment.
minor: it's either autoEncryptionOptionsConfigurator != null or autoEncryptionOptionsConfigurator?
There was a problem hiding this comment.
good point. This one actually sets options to null if configurator is null. Removed unnecessary ? part
…ator and partialFilterExpression.
DmitryLukyanov
force-pushed
the
csharp4157
branch
from
4c2b964 to
fc100a1
Compare
| ## Collections | ||
|
|
||
| These operations exists on the [`IMongoDatabase`]({{< apiref "T_MongoDB_Driver_IMongoDatabase" >}}) interface. | ||
| These operations exist on the [`IMongoDatabase`]({{< apiref "T_MongoDB_Driver_IMongoDatabase" >}}) interface. |
There was a problem hiding this comment.
cherrypicked from master to make tests passed
| /// <value> | ||
| /// The clustered index definition. | ||
| /// </value> | ||
| public BsonDocument ClusteredIndex |
There was a problem hiding this comment.
cherrypicked from master to make tests passed
| /// <summary> | ||
| /// Options for creating a clustered index. | ||
| /// </summary> | ||
| public class ClusteredIndexOptions<TDocument> |
There was a problem hiding this comment.
cherrypicked from master to make tests passed
| /// <summary> | ||
| /// Gets or sets the <see cref="ClusteredIndexOptions{TDocument}"/>. | ||
| /// </summary> | ||
| public ClusteredIndexOptions<TDocument> ClusteredIndex |
There was a problem hiding this comment.
cherrypicked from master to make tests passed
| var documentType = options.GetType().GetTypeInfo().GetGenericArguments()[0]; | ||
| var methodInfo = genericMethodDefinition.MakeGenericMethod(documentType); | ||
| methodInfo.Invoke(this, new object[] { session, name, options, cancellationToken }); | ||
| try |
There was a problem hiding this comment.
we have asserting on particular exception that is hidden over TargetInvocationException. This logic of course it's better to be rewritten on some day..
| var documentSerializer = options.DocumentSerializer ?? serializerRegistry.GetSerializer<TDocument>(); | ||
| validator = options.Validator.Render(documentSerializer, serializerRegistry, _linqProvider); | ||
| } | ||
| var serializerRegistry = options.SerializerRegistry ?? BsonSerializer.SerializerRegistry; |
There was a problem hiding this comment.
cherrypicked from master to make tests passed
CSHARP-4190: Rename csfle shared library references
No description provided.