New tgmath #172
Merged
New tgmath #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Examples-and-Tests into bxdf_unit_tests
…ng/Nabla-Examples-and-Tests into bxdf_unit_tests
…Examples-and-Tests into new_tgmath
…Examples-and-Tests into new_tgmath_tests
Open
Member
|
Actually @Przemog1 can you make a cherrypicked branch, because they're ready to merge. |
Comment on lines
+126
to
+132
| #ifndef __HLSL_VERSION | ||
| nbl::hlsl::vector<int, 3> isnanVec; | ||
| nbl::hlsl::vector<int, 3> isinfVec; | ||
| #else | ||
| vector<int, 3> isnanVec; | ||
| vector<int, 3> isinfVec; | ||
| #endif |
There was a problem hiding this comment.
leave a comment that we can't fix this because using namespace nbl::hlsl would cause ambiguous math functions below and we can't add a nbl::hlsl alias for the builtin hLSL vector type because of microsoft/DirectXShaderCompiler#7035
devshgraphicsprogramming
changed the base branch from
bxdf_unit_tests
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.