Skip to content

Conversation

jinroh
Copy link
Collaborator

@jinroh jinroh commented Feb 28, 2024

  • Inline some JSON policies into YAML
  • Add a deploy script example
  • Rename some resources
  • Add tags on launch templates
  • Allow deploying scanner inside an existing VPC with the new optional parameters: ScannerVPCId and ScannerSubnetId
  • Allow associating an existing security-group to the scanner with the new optional parameter: ScannerSecurityGroupId
  • Allow attaching an existing SSH key-pair to the scanner with the new optional parameter: ScannerSSHKeyPairName
  • Allow setting the Datadog API Key via SecretManager with thew new optional paramater: DatadogAPIKeySecretArn
  • Creating a dedicated security-group by default with empty ingress rules
  • Add support for offline mode to scan without remote-config (deactived by default)
  • AutoScalingGroup update policy replacing instances as the launch template is being updated

@jinroh jinroh requested a review from a team as a code owner February 28, 2024 16:17
@jinroh jinroh force-pushed the jinroh/cloudformation-2 branch from fffe849 to 5343550 Compare March 6, 2024 11:40
@jinroh jinroh force-pushed the jinroh/cloudformation-2 branch from 5343550 to e9d7ecc Compare March 6, 2024 13:04
@0intro
Copy link
Member

0intro commented Mar 6, 2024

It works for me.

0intro
0intro previously approved these changes Mar 6, 2024
@jinroh jinroh changed the title Cleanups on Cloudformation Improving CloudFormation capabilities Mar 7, 2024
@0intro 0intro self-requested a review March 7, 2024 09:46
@jinroh jinroh merged commit 0e89a12 into main Mar 7, 2024
@jinroh jinroh deleted the jinroh/cloudformation-2 branch March 7, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants