Skip to content

Fix single-region example #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2024
Merged

Fix single-region example #39

merged 2 commits into from
Feb 1, 2024

Conversation

jinroh
Copy link
Collaborator

@jinroh jinroh commented Feb 1, 2024 •
edited
Loading

  • scanner_role variable in now scanner_roles
  • add ignore_failed_scaling_activities when creating ASG: got bit by this issue when deploying on my own account

@jinroh jinroh requested review from a team as code owners February 1, 2024 09:08
@jinroh jinroh enabled auto-merge (squash) February 1, 2024 10:03
@jinroh jinroh disabled auto-merge February 1, 2024 10:03
@jinroh jinroh enabled auto-merge (rebase) February 1, 2024 10:03
@jinroh jinroh merged commit 8eafaa0 into main Feb 1, 2024
@jinroh jinroh deleted the jinroh/fix-single-region-example branch February 1, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bit-Doctor Bit-Doctor Bit-Doctor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinroh @Bit-Doctor