Skip to content

Conversation

Dan70402
Copy link
Contributor

Add support for the sysem_core integration. Note: this required #358 in order to resolve build\test issues with ruby 2.0.0

@truthbk
Copy link
Member

truthbk commented Nov 16, 2017

@Dan70402 this looks pretty solid! Thank you for your contribution. I believe a similar fix to #358 was already merged into master after you started work on this. Could you please revert 6099ca9, rebase to the latest master and check if the tests are green?

Thanks!!

@truthbk truthbk self-assigned this Nov 16, 2017
@Dan70402
Copy link
Contributor Author

@truthbk, done and tests still pass.

Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dan70402 thank you! This is ready!! :shipit:

@truthbk truthbk merged commit 7eae02b into DataDog:master Nov 23, 2017
@truthbk truthbk added this to the 1.12.0 milestone Dec 13, 2017
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Jan 31, 2018
* Add support for system_core integration

* fix build for ruby 2.0.0

* Revert "fix build for ruby 2.0.0"

This reverts commit 6099ca9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants