Skip to content

Conversation

jameynelson
Copy link
Contributor

@jameynelson jameynelson commented Aug 1, 2017

This is to add the ability to control the network integration and it's details to the puppet module. I have included some rudimentary tests also.

@jameynelson jameynelson changed the title First pass of adding network module Add network integration to puppet module Aug 1, 2017
@truthbk
Copy link
Member

truthbk commented Aug 11, 2017

Thanks @jameynelson! Looks good right off the bat... thanks a bunch for the spec tests. I'll review soon and provide feedback, if any at all. 🙇

@truthbk truthbk added this to the 1.11.0 milestone Aug 11, 2017
@truthbk truthbk self-requested a review August 11, 2017 13:24
@truthbk truthbk modified the milestones: 1.11.0, 1.12.0 Nov 23, 2017
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go! Thanks @jameynelson awesome work here 🙇

@truthbk truthbk merged commit d2eb27d into DataDog:master Nov 23, 2017
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants