Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Conversation

@mx-psi
Copy link
Member

@mx-psi mx-psi commented Dec 20, 2023

What does this PR do?

  • First commit: Add attributes.Translator
  • Second commit: Pass attributes.Translator explicitly to metrics.Translator
  • Last commit: Pass attributes.Translator explicitly to logs.Translator

Motivation

Have a single counter for all signals

@mx-psi mx-psi force-pushed the mx-psi/refactor-attributes branch from 686909f to 7e3662d Compare December 20, 2023 16:17
@mx-psi mx-psi added the breaking-change This PR introduces a Go API breaking change label Dec 20, 2023
@mx-psi mx-psi marked this pull request as ready for review December 20, 2023 16:24
@mx-psi mx-psi requested a review from a team as a code owner December 20, 2023 16:24
@mx-psi mx-psi requested review from dinooliva and mackjmr December 20, 2023 16:24
Copy link
Member

@mackjmr mackjmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mx-psi mx-psi merged commit 19bb6a3 into main Dec 21, 2023
@mx-psi mx-psi deleted the mx-psi/refactor-attributes branch December 21, 2023 10:05
codeboten pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Dec 21, 2023
**Description:** 

- [*/datadog] Bump to opentelemetry-mapping-go v0.11.0. This includes:
  - Refactor related to upcoming metric:
    - DataDog/opentelemetry-mapping-go/pull/230
    - DataDog/opentelemetry-mapping-go/pull/231
    - DataDog/opentelemetry-mapping-go/pull/229
  - Host metadata updates:
    - DataDog/opentelemetry-mapping-go/pull/184
    - DataDog/opentelemetry-mapping-go/pull/225
- Use `logs.Translator` for logs implementation
- Set `MeterProvider` to noop to prevent sending metrics for now until
we agree on the design. Note that I reverted one of the changelog items
added in #29785, since it's no longer true that we add this metric.
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
…y#30158)

**Description:** 

- [*/datadog] Bump to opentelemetry-mapping-go v0.11.0. This includes:
  - Refactor related to upcoming metric:
    - DataDog/opentelemetry-mapping-go/pull/230
    - DataDog/opentelemetry-mapping-go/pull/231
    - DataDog/opentelemetry-mapping-go/pull/229
  - Host metadata updates:
    - DataDog/opentelemetry-mapping-go/pull/184
    - DataDog/opentelemetry-mapping-go/pull/225
- Use `logs.Translator` for logs implementation
- Set `MeterProvider` to noop to prevent sending metrics for now until
we agree on the design. Note that I reverted one of the changelog items
added in open-telemetry#29785, since it's no longer true that we add this metric.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

breaking-change This PR introduces a Go API breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants