[crashtracker] Add test to check callstack #1189
Draft
+207
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gleocadie
commented
Aug 26, 2025
Comment on lines
+28
to
+36
| #[cfg(any(target_arch = "x86", target_arch = "x86_64"))] | ||
| { | ||
| std::arch::asm!("mov eax, [0]", options(nostack)); | ||
| } | ||
|
|
||
| #[cfg(target_arch = "aarch64")] | ||
| { | ||
| std::arch::asm!("mov x0, #0", "ldr x1, [x0]", options(nostack)); | ||
| } |
gleocadie
commented
Aug 26, 2025
| let crashing_callstack = &crash_payload["error"]["stack"]["frames"]; | ||
| assert!( | ||
| crashing_callstack.as_array().unwrap().len() >= expected_functions.len(), | ||
| "crashing thread callstacks ddddd", |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1189 +/- ##
==========================================
- Coverage 71.72% 71.64% -0.08%
==========================================
Files 349 350 +1
Lines 55114 55186 +72
==========================================
+ Hits 39528 39536 +8
- Misses 15586 15650 +64
🚀 New features to boost your workflow:
|
gleocadie
force-pushed
the
gleocadie/check-crashing-thread-callstack
branch
3 times, most recently
from
3f7bf3a to
a638e6c
Compare
gleocadie
force-pushed
the
gleocadie/check-crashing-thread-callstack
branch
from
a638e6c to
85bcfae
Compare
BenchmarksComparisonBenchmark execution time: 2025-08-27 16:10:52 Comparing candidate commit b1013b6 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics. scenario:benching deserializing traces from msgpack to their internal representation
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
BaselineOmitted due to size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a
crash_test_appwhich does function calls, crashes. The crash tracker will collect the report and make sure that the crashing thread callstack contains certain frames.Motivation
Stability and quality: We want to make sure that crash tracker, more specifically the unwinder, accurately collects stack frames.
Additional Notes
Currently, the test is enabled for:
But disabled for:
"resolve_names failed with failed to open proc maps file /proc/10282/maps: No such file or directory (os error 2)". It seems that the application already died when we resolve names/normalize ips.