Skip to content

Conversation

cbeauchesne
Copy link
Contributor

@cbeauchesne cbeauchesne commented Aug 25, 2025

What does this PR do?
Use the official system-tests workflow

  • remove this big todo list in comment in new workflow file
  • Include parametric scenario
  • uncomment the schedule trigger in this file
  • uncomment the pull request trigger in this file
  • delete .github/forced-tests-list.json (and check if .github/forced-tests-list.cfg is up-to-date)
  • update docs/ForcingSystemTests.md
  • update the cleanup task in the release process that cleans forced tests

Change log entry
None.

Additional Notes:

How to test the change?

@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Aug 25, 2025
Copy link

github-actions bot commented Aug 25, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-08-25 09:55:33 UTC

@pr-commenter
Copy link

pr-commenter bot commented Aug 25, 2025

Benchmarks

Benchmark execution time: 2025-08-25 10:35:43

Comparing candidate commit 2261c6f in PR branch cbeauchesne/use-official-st-workflow with baseline commit 319db66 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics.

Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.54%. Comparing base (319db66) to head (2261c6f).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4866      +/-   ##
==========================================
- Coverage   97.55%   97.54%   -0.02%     
==========================================
  Files        1507     1507              
  Lines       89790    89789       -1     
  Branches     4755     4755              
==========================================
- Hits        87598    87584      -14     
- Misses       2192     2205      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cbeauchesne cbeauchesne marked this pull request as ready for review August 25, 2025 13:33
@cbeauchesne cbeauchesne requested a review from a team as a code owner August 25, 2025 13:33
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'm happy we finally got to this point. I think this is one case where it'd be nice to get a second review on top of mine before we merge it so I dropped a note on the channel about it.

@marcotc
Copy link
Member

marcotc commented Aug 26, 2025

@cbeauchesne when this PR is ready to merge, invoke the mergequeue bot!

@cbeauchesne
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 27, 2025

View all feedbacks in Devflow UI.

2025-08-27 14:38:10 UTC ℹ️ Start processing command /merge


2025-08-27 14:38:29 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 32m (p90).


2025-08-27 15:14:45 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 299da4e into master Aug 27, 2025
487 of 489 checks passed
@dd-mergequeue dd-mergequeue bot deleted the cbeauchesne/use-official-st-workflow branch August 27, 2025 15:14
@github-actions github-actions bot added this to the 2.20.0 milestone Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants