-
Notifications
You must be signed in to change notification settings - Fork 314
Disable process context sharing when using native image #9647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: c003f12 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~c003f12b66, baseline=1.54.0-SNAPSHOT~ed7fe50717
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1022308
Total [baseline] (10.795 s) : 0, 10794877
Agent [candidate] (1.029 s) : 0, 1028707
Total [candidate] (10.682 s) : 0, 10682342
section appsec
Agent [baseline] (1.191 s) : 0, 1191330
Total [baseline] (11.077 s) : 0, 11077315
Agent [candidate] (1.191 s) : 0, 1191279
Total [candidate] (11.079 s) : 0, 11079325
section iast
Agent [baseline] (1.162 s) : 0, 1161671
Total [baseline] (11.076 s) : 0, 11076005
Agent [candidate] (1.159 s) : 0, 1159302
Total [candidate] (10.925 s) : 0, 10924981
section profiling
Agent [baseline] (1.157 s) : 0, 1156999
Total [baseline] (11.021 s) : 0, 11021487
Agent [candidate] (1.159 s) : 0, 1159444
Total [candidate] (11.027 s) : 0, 11027233
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~c003f12b66, baseline=1.54.0-SNAPSHOT~ed7fe50717
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.493 ms) : 0, 1493
BytebuddyAgent [baseline] (696.485 ms) : 0, 696485
BytebuddyAgent [candidate] (701.426 ms) : 0, 701426
GlobalTracer [baseline] (244.468 ms) : 0, 244468
GlobalTracer [candidate] (246.776 ms) : 0, 246776
AppSec [baseline] (31.545 ms) : 0, 31545
AppSec [candidate] (31.837 ms) : 0, 31837
Debugger [baseline] (6.404 ms) : 0, 6404
Debugger [candidate] (6.453 ms) : 0, 6453
Remote Config [baseline] (681.09 µs) : 0, 681
Remote Config [candidate] (687.339 µs) : 0, 687
Telemetry [baseline] (8.977 ms) : 0, 8977
Telemetry [candidate] (9.124 ms) : 0, 9124
Flare Poller [baseline] (10.993 ms) : 0, 10993
Flare Poller [candidate] (9.475 ms) : 0, 9475
section appsec
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (716.319 ms) : 0, 716319
BytebuddyAgent [candidate] (716.624 ms) : 0, 716624
GlobalTracer [baseline] (235.073 ms) : 0, 235073
GlobalTracer [candidate] (234.976 ms) : 0, 234976
AppSec [baseline] (172.717 ms) : 0, 172717
AppSec [candidate] (172.261 ms) : 0, 172261
Debugger [baseline] (6.042 ms) : 0, 6042
Debugger [candidate] (6.044 ms) : 0, 6044
Remote Config [baseline] (628.781 µs) : 0, 629
Remote Config [candidate] (636.423 µs) : 0, 636
Telemetry [baseline] (8.305 ms) : 0, 8305
Telemetry [candidate] (9.078 ms) : 0, 9078
Flare Poller [baseline] (4.757 ms) : 0, 4757
Flare Poller [candidate] (3.996 ms) : 0, 3996
IAST [baseline] (24.886 ms) : 0, 24886
IAST [candidate] (25.083 ms) : 0, 25083
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (822.061 ms) : 0, 822061
BytebuddyAgent [candidate] (820.793 ms) : 0, 820793
GlobalTracer [baseline] (236.061 ms) : 0, 236061
GlobalTracer [candidate] (235.45 ms) : 0, 235450
AppSec [baseline] (34.374 ms) : 0, 34374
AppSec [candidate] (34.14 ms) : 0, 34140
Debugger [baseline] (6.106 ms) : 0, 6106
Debugger [candidate] (6.076 ms) : 0, 6076
Remote Config [baseline] (602.142 µs) : 0, 602
Remote Config [candidate] (603.808 µs) : 0, 604
Telemetry [baseline] (8.378 ms) : 0, 8378
Telemetry [candidate] (8.353 ms) : 0, 8353
Flare Poller [baseline] (4.241 ms) : 0, 4241
Flare Poller [candidate] (4.263 ms) : 0, 4263
IAST [baseline] (26.792 ms) : 0, 26792
IAST [candidate] (26.647 ms) : 0, 26647
section profiling
ProfilingAgent [baseline] (103.171 ms) : 0, 103171
ProfilingAgent [candidate] (104.44 ms) : 0, 104440
crashtracking [baseline] (1.417 ms) : 0, 1417
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (721.22 ms) : 0, 721220
BytebuddyAgent [candidate] (722.712 ms) : 0, 722712
GlobalTracer [baseline] (218.65 ms) : 0, 218650
GlobalTracer [candidate] (218.517 ms) : 0, 218517
AppSec [baseline] (31.378 ms) : 0, 31378
AppSec [candidate] (31.364 ms) : 0, 31364
Debugger [baseline] (7.331 ms) : 0, 7331
Debugger [candidate] (6.592 ms) : 0, 6592
Remote Config [baseline] (730.837 µs) : 0, 731
Remote Config [candidate] (732.219 µs) : 0, 732
Telemetry [baseline] (15.639 ms) : 0, 15639
Telemetry [candidate] (16.614 ms) : 0, 16614
Flare Poller [baseline] (4.201 ms) : 0, 4201
Flare Poller [candidate] (4.299 ms) : 0, 4299
Profiling [baseline] (104.407 ms) : 0, 104407
Profiling [candidate] (105.026 ms) : 0, 105026
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~c003f12b66, baseline=1.54.0-SNAPSHOT~ed7fe50717
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.016 s) : 0, 1015576
Total [baseline] (8.646 s) : 0, 8646290
Agent [candidate] (1.024 s) : 0, 1024300
Total [candidate] (8.687 s) : 0, 8686948
section iast
Agent [baseline] (1.148 s) : 0, 1148368
Total [baseline] (9.268 s) : 0, 9268143
Agent [candidate] (1.157 s) : 0, 1157021
Total [candidate] (9.266 s) : 0, 9265902
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~c003f12b66, baseline=1.54.0-SNAPSHOT~ed7fe50717
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.496 ms) : 0, 1496
BytebuddyAgent [baseline] (692.31 ms) : 0, 692310
BytebuddyAgent [candidate] (697.159 ms) : 0, 697159
GlobalTracer [baseline] (242.918 ms) : 0, 242918
GlobalTracer [candidate] (245.207 ms) : 0, 245207
AppSec [baseline] (31.371 ms) : 0, 31371
AppSec [candidate] (31.738 ms) : 0, 31738
Debugger [baseline] (6.354 ms) : 0, 6354
Debugger [candidate] (6.444 ms) : 0, 6444
Remote Config [baseline] (695.24 µs) : 0, 695
Remote Config [candidate] (706.051 µs) : 0, 706
Telemetry [baseline] (8.969 ms) : 0, 8969
Telemetry [candidate] (9.097 ms) : 0, 9097
Flare Poller [baseline] (10.289 ms) : 0, 10289
Flare Poller [candidate] (11.197 ms) : 0, 11197
section iast
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.48 ms) : 0, 1480
BytebuddyAgent [baseline] (813.516 ms) : 0, 813516
BytebuddyAgent [candidate] (819.836 ms) : 0, 819836
GlobalTracer [baseline] (232.767 ms) : 0, 232767
GlobalTracer [candidate] (234.396 ms) : 0, 234396
IAST [baseline] (26.33 ms) : 0, 26330
IAST [candidate] (26.577 ms) : 0, 26577
AppSec [baseline] (34.031 ms) : 0, 34031
AppSec [candidate] (34.143 ms) : 0, 34143
Debugger [baseline] (5.995 ms) : 0, 5995
Debugger [candidate] (6.089 ms) : 0, 6089
Remote Config [baseline] (585.622 µs) : 0, 586
Remote Config [candidate] (601.943 µs) : 0, 602
Telemetry [baseline] (8.139 ms) : 0, 8139
Telemetry [candidate] (8.317 ms) : 0, 8317
Flare Poller [baseline] (4.22 ms) : 0, 4220
Flare Poller [candidate] (4.183 ms) : 0, 4183
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~c003f12b66, baseline=1.54.0-SNAPSHOT~ed7fe50717
dateFormat X
axisFormat %s
section baseline
no_agent (4.354 ms) : 4304, 4404
. : milestone, 4354,
iast (10.151 ms) : 9983, 10319
. : milestone, 10151,
iast_FULL (14.747 ms) : 14453, 15042
. : milestone, 14747,
iast_GLOBAL (10.567 ms) : 10359, 10775
. : milestone, 10567,
profiling (8.861 ms) : 8711, 9010
. : milestone, 8861,
tracing (7.782 ms) : 7671, 7893
. : milestone, 7782,
section candidate
no_agent (4.422 ms) : 4370, 4474
. : milestone, 4422,
iast (9.863 ms) : 9696, 10030
. : milestone, 9863,
iast_FULL (14.332 ms) : 14040, 14625
. : milestone, 14332,
iast_GLOBAL (10.533 ms) : 10347, 10718
. : milestone, 10533,
profiling (8.964 ms) : 8826, 9103
. : milestone, 8964,
tracing (7.794 ms) : 7674, 7913
. : milestone, 7794,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~c003f12b66, baseline=1.54.0-SNAPSHOT~ed7fe50717
dateFormat X
axisFormat %s
section baseline
no_agent (35.253 ms) : 34974, 35533
. : milestone, 35253,
appsec (49.227 ms) : 48783, 49672
. : milestone, 49227,
code_origins (44.093 ms) : 43709, 44477
. : milestone, 44093,
iast (46.26 ms) : 45863, 46656
. : milestone, 46260,
profiling (49.929 ms) : 49462, 50395
. : milestone, 49929,
tracing (46.427 ms) : 46015, 46838
. : milestone, 46427,
section candidate
no_agent (37.247 ms) : 36944, 37550
. : milestone, 37247,
appsec (47.893 ms) : 47458, 48329
. : milestone, 47893,
code_origins (44.364 ms) : 43977, 44752
. : milestone, 44364,
iast (44.18 ms) : 43804, 44557
. : milestone, 44180,
profiling (46.323 ms) : 45926, 46719
. : milestone, 46323,
tracing (44.153 ms) : 43776, 44530
. : milestone, 44153,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~c003f12b66, baseline=1.54.0-SNAPSHOT~ed7fe50717
dateFormat X
axisFormat %s
section baseline
no_agent (14.71 s) : 14710000, 14710000
. : milestone, 14710000,
appsec (15.327 s) : 15327000, 15327000
. : milestone, 15327000,
iast (18.796 s) : 18796000, 18796000
. : milestone, 18796000,
iast_GLOBAL (17.769 s) : 17769000, 17769000
. : milestone, 17769000,
profiling (15.087 s) : 15087000, 15087000
. : milestone, 15087000,
tracing (15.285 s) : 15285000, 15285000
. : milestone, 15285000,
section candidate
no_agent (15.548 s) : 15548000, 15548000
. : milestone, 15548000,
appsec (15.235 s) : 15235000, 15235000
. : milestone, 15235000,
iast (18.73 s) : 18730000, 18730000
. : milestone, 18730000,
iast_GLOBAL (18.08 s) : 18080000, 18080000
. : milestone, 18080000,
profiling (15.399 s) : 15399000, 15399000
. : milestone, 15399000,
tracing (15.135 s) : 15135000, 15135000
. : milestone, 15135000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~c003f12b66, baseline=1.54.0-SNAPSHOT~ed7fe50717
dateFormat X
axisFormat %s
section baseline
no_agent (1.485 ms) : 1473, 1497
. : milestone, 1485,
appsec (3.726 ms) : 3509, 3942
. : milestone, 3726,
iast (2.207 ms) : 2144, 2270
. : milestone, 2207,
iast_GLOBAL (2.243 ms) : 2179, 2307
. : milestone, 2243,
profiling (2.076 ms) : 2023, 2129
. : milestone, 2076,
tracing (2.032 ms) : 1982, 2081
. : milestone, 2032,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.729 ms) : 3509, 3948
. : milestone, 3729,
iast (2.202 ms) : 2138, 2266
. : milestone, 2202,
iast_GLOBAL (2.246 ms) : 2183, 2309
. : milestone, 2246,
profiling (2.047 ms) : 1996, 2098
. : milestone, 2047,
tracing (2.032 ms) : 1982, 2081
. : milestone, 2032,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed offline by @jbachorik too
What Does This Do
This PR fixes the native build failure related to the process context sharing introduced in profiling: #9472
Motivation
Related error:
Additional Notes
I'm trying to find out while I get this failing in local build only and CI does not complain about it.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]