-
Couldn't load subscription status.
- Fork 314
Fixed git command hangs in case if no remote exists. #9575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: c2ecb1d | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~c2ecb1dd03, baseline=1.54.0-SNAPSHOT~3a389f573c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.03 s) : 0, 1030296
Total [baseline] (8.698 s) : 0, 8697507
Agent [candidate] (1.019 s) : 0, 1018977
Total [candidate] (8.638 s) : 0, 8637514
section iast
Agent [baseline] (1.16 s) : 0, 1159835
Total [baseline] (9.34 s) : 0, 9339556
Agent [candidate] (1.159 s) : 0, 1159429
Total [candidate] (9.354 s) : 0, 9354325
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~c2ecb1dd03, baseline=1.54.0-SNAPSHOT~3a389f573c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (693.689 ms) : 0, 693689
BytebuddyAgent [candidate] (686.344 ms) : 0, 686344
GlobalTracer [baseline] (260.005 ms) : 0, 260005
GlobalTracer [candidate] (257.67 ms) : 0, 257670
AppSec [baseline] (31.801 ms) : 0, 31801
AppSec [candidate] (31.575 ms) : 0, 31575
Debugger [baseline] (6.393 ms) : 0, 6393
Debugger [candidate] (6.32 ms) : 0, 6320
Remote Config [baseline] (687.542 µs) : 0, 688
Remote Config [candidate] (675.484 µs) : 0, 675
Telemetry [baseline] (15.154 ms) : 0, 15154
Telemetry [candidate] (14.006 ms) : 0, 14006
section iast
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (812.855 ms) : 0, 812855
BytebuddyAgent [candidate] (812.443 ms) : 0, 812443
GlobalTracer [baseline] (250.465 ms) : 0, 250465
GlobalTracer [candidate] (250.175 ms) : 0, 250175
AppSec [baseline] (28.024 ms) : 0, 28024
AppSec [candidate] (29.876 ms) : 0, 29876
Debugger [baseline] (6.117 ms) : 0, 6117
Debugger [candidate] (6.101 ms) : 0, 6101
Remote Config [baseline] (608.159 µs) : 0, 608
Remote Config [candidate] (610.204 µs) : 0, 610
Telemetry [baseline] (9.178 ms) : 0, 9178
Telemetry [candidate] (8.197 ms) : 0, 8197
IAST [baseline] (30.105 ms) : 0, 30105
IAST [candidate] (29.447 ms) : 0, 29447
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~c2ecb1dd03, baseline=1.54.0-SNAPSHOT~3a389f573c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1017627
Total [baseline] (10.616 s) : 0, 10615813
Agent [candidate] (1.022 s) : 0, 1021819
Total [candidate] (10.74 s) : 0, 10740358
section appsec
Agent [baseline] (1.194 s) : 0, 1194156
Total [baseline] (11.077 s) : 0, 11077178
Agent [candidate] (1.195 s) : 0, 1194704
Total [candidate] (11.018 s) : 0, 11017892
section iast
Agent [baseline] (1.154 s) : 0, 1154290
Total [baseline] (11.145 s) : 0, 11145269
Agent [candidate] (1.155 s) : 0, 1155195
Total [candidate] (11.03 s) : 0, 11029554
section profiling
Agent [baseline] (1.171 s) : 0, 1171020
Total [baseline] (10.973 s) : 0, 10973389
Agent [candidate] (1.169 s) : 0, 1169161
Total [candidate] (11.183 s) : 0, 11183440
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~c2ecb1dd03, baseline=1.54.0-SNAPSHOT~3a389f573c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (686.51 ms) : 0, 686510
BytebuddyAgent [candidate] (687.669 ms) : 0, 687669
GlobalTracer [baseline] (258.1 ms) : 0, 258100
GlobalTracer [candidate] (258.883 ms) : 0, 258883
AppSec [baseline] (31.635 ms) : 0, 31635
AppSec [candidate] (31.664 ms) : 0, 31664
Debugger [baseline] (6.326 ms) : 0, 6326
Debugger [candidate] (6.324 ms) : 0, 6324
Remote Config [baseline] (689.798 µs) : 0, 690
Remote Config [candidate] (673.909 µs) : 0, 674
Telemetry [baseline] (11.853 ms) : 0, 11853
Telemetry [candidate] (14.138 ms) : 0, 14138
section appsec
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (709.055 ms) : 0, 709055
BytebuddyAgent [candidate] (709.59 ms) : 0, 709590
GlobalTracer [baseline] (250.576 ms) : 0, 250576
GlobalTracer [candidate] (250.89 ms) : 0, 250890
AppSec [baseline] (171.2 ms) : 0, 171200
AppSec [candidate] (169.596 ms) : 0, 169596
Debugger [baseline] (6.067 ms) : 0, 6067
Debugger [candidate] (6.07 ms) : 0, 6070
Remote Config [baseline] (612.582 µs) : 0, 613
Remote Config [candidate] (622.407 µs) : 0, 622
Telemetry [baseline] (9.127 ms) : 0, 9127
Telemetry [candidate] (10.559 ms) : 0, 10559
IAST [baseline] (25.035 ms) : 0, 25035
IAST [candidate] (24.871 ms) : 0, 24871
section iast
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (808.863 ms) : 0, 808863
BytebuddyAgent [candidate] (809.061 ms) : 0, 809061
GlobalTracer [baseline] (249.414 ms) : 0, 249414
GlobalTracer [candidate] (249.837 ms) : 0, 249837
AppSec [baseline] (27.848 ms) : 0, 27848
AppSec [candidate] (30.597 ms) : 0, 30597
Debugger [baseline] (6.119 ms) : 0, 6119
Debugger [candidate] (6.052 ms) : 0, 6052
Remote Config [baseline] (600.12 µs) : 0, 600
Remote Config [candidate] (596.409 µs) : 0, 596
Telemetry [baseline] (8.167 ms) : 0, 8167
Telemetry [candidate] (8.215 ms) : 0, 8215
IAST [baseline] (30.898 ms) : 0, 30898
IAST [candidate] (28.28 ms) : 0, 28280
section profiling
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (723.264 ms) : 0, 723264
BytebuddyAgent [candidate] (722.307 ms) : 0, 722307
GlobalTracer [baseline] (237.365 ms) : 0, 237365
GlobalTracer [candidate] (237.142 ms) : 0, 237142
AppSec [baseline] (31.361 ms) : 0, 31361
AppSec [candidate] (31.171 ms) : 0, 31171
Debugger [baseline] (6.532 ms) : 0, 6532
Debugger [candidate] (6.512 ms) : 0, 6512
Remote Config [baseline] (706.791 µs) : 0, 707
Remote Config [candidate] (700.571 µs) : 0, 701
Telemetry [baseline] (15.879 ms) : 0, 15879
Telemetry [candidate] (16.669 ms) : 0, 16669
ProfilingAgent [baseline] (102.339 ms) : 0, 102339
ProfilingAgent [candidate] (101.9 ms) : 0, 101900
Profiling [baseline] (102.941 ms) : 0, 102941
Profiling [candidate] (102.498 ms) : 0, 102498
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~c2ecb1dd03, baseline=1.54.0-SNAPSHOT~3a389f573c
dateFormat X
axisFormat %s
section baseline
no_agent (4.365 ms) : 4314, 4415
. : milestone, 4365,
iast (9.73 ms) : 9570, 9890
. : milestone, 9730,
iast_FULL (14.284 ms) : 13995, 14574
. : milestone, 14284,
iast_GLOBAL (10.817 ms) : 10623, 11011
. : milestone, 10817,
profiling (8.91 ms) : 8771, 9049
. : milestone, 8910,
tracing (7.82 ms) : 7707, 7933
. : milestone, 7820,
section candidate
no_agent (4.414 ms) : 4364, 4463
. : milestone, 4414,
iast (9.456 ms) : 9303, 9610
. : milestone, 9456,
iast_FULL (14.003 ms) : 13725, 14282
. : milestone, 14003,
iast_GLOBAL (10.517 ms) : 10331, 10702
. : milestone, 10517,
profiling (9.277 ms) : 9120, 9434
. : milestone, 9277,
tracing (7.756 ms) : 7647, 7865
. : milestone, 7756,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~c2ecb1dd03, baseline=1.54.0-SNAPSHOT~3a389f573c
dateFormat X
axisFormat %s
section baseline
no_agent (38.475 ms) : 38168, 38783
. : milestone, 38475,
appsec (48.029 ms) : 47598, 48461
. : milestone, 48029,
code_origins (44.564 ms) : 44191, 44937
. : milestone, 44564,
iast (45.53 ms) : 45144, 45916
. : milestone, 45530,
profiling (49.127 ms) : 48680, 49575
. : milestone, 49127,
tracing (45.805 ms) : 45402, 46209
. : milestone, 45805,
section candidate
no_agent (36.391 ms) : 36104, 36678
. : milestone, 36391,
appsec (49.823 ms) : 49377, 50269
. : milestone, 49823,
code_origins (44.92 ms) : 44539, 45301
. : milestone, 44920,
iast (44.949 ms) : 44560, 45339
. : milestone, 44949,
profiling (46.668 ms) : 46222, 47113
. : milestone, 46668,
tracing (44.685 ms) : 44294, 45075
. : milestone, 44685,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 1 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~c2ecb1dd03, baseline=1.54.0-SNAPSHOT~3a389f573c
dateFormat X
axisFormat %s
section baseline
no_agent (15.343 s) : 15343000, 15343000
. : milestone, 15343000,
appsec (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
iast (18.679 s) : 18679000, 18679000
. : milestone, 18679000,
iast_GLOBAL (17.916 s) : 17916000, 17916000
. : milestone, 17916000,
profiling (15.397 s) : 15397000, 15397000
. : milestone, 15397000,
tracing (15.088 s) : 15088000, 15088000
. : milestone, 15088000,
section candidate
no_agent (14.933 s) : 14933000, 14933000
. : milestone, 14933000,
appsec (15.11 s) : 15110000, 15110000
. : milestone, 15110000,
iast (18.574 s) : 18574000, 18574000
. : milestone, 18574000,
iast_GLOBAL (18.067 s) : 18067000, 18067000
. : milestone, 18067000,
profiling (15.51 s) : 15510000, 15510000
. : milestone, 15510000,
tracing (15.166 s) : 15166000, 15166000
. : milestone, 15166000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~c2ecb1dd03, baseline=1.54.0-SNAPSHOT~3a389f573c
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.744 ms) : 3528, 3959
. : milestone, 3744,
iast (2.207 ms) : 2145, 2270
. : milestone, 2207,
iast_GLOBAL (2.246 ms) : 2183, 2309
. : milestone, 2246,
profiling (2.064 ms) : 2013, 2115
. : milestone, 2064,
tracing (2.03 ms) : 1981, 2079
. : milestone, 2030,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (2.501 ms) : 2449, 2554
. : milestone, 2501,
iast (2.208 ms) : 2145, 2271
. : milestone, 2208,
iast_GLOBAL (2.249 ms) : 2186, 2312
. : milestone, 2249,
profiling (2.491 ms) : 2323, 2659
. : milestone, 2491,
tracing (2.035 ms) : 1986, 2084
. : milestone, 2035,
|
What Does This Do
Fixes a hanging test:
test get base branch sha: no remote clone.The test was failing with:
Timeout while waiting for git ls-remote -.-heads origin main.Motivation
Green CI
Additional Notes
After enabling debug logs for git, I discovered the issue came from ssh being used by default. Since ssh has no built-in timeout, the process could hang indefinitely.
For the record, there are two possible approaches:
sshCommand = ssh -o ConnectTimeout=2.url = https://some-host/datadog/non_existing_repo.gitThis PR applies option (1), using a timeout.