-
Couldn't load subscription status.
- Fork 315
Migrate tests and ConfigInversionMetricCollector to config-utils module
#9566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 4 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~8fd87fbedd, baseline=1.54.0-SNAPSHOT~1450a11e5d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.015 s) : 0, 1015050
Total [baseline] (8.672 s) : 0, 8671811
Agent [candidate] (1.009 s) : 0, 1009430
Total [candidate] (8.737 s) : 0, 8737297
section iast
Agent [baseline] (1.159 s) : 0, 1159149
Total [baseline] (9.252 s) : 0, 9252100
Agent [candidate] (1.156 s) : 0, 1156321
Total [candidate] (9.338 s) : 0, 9337631
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~8fd87fbedd, baseline=1.54.0-SNAPSHOT~1450a11e5d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (694.997 ms) : 0, 694997
BytebuddyAgent [candidate] (690.927 ms) : 0, 690927
GlobalTracer [baseline] (249.862 ms) : 0, 249862
GlobalTracer [candidate] (248.714 ms) : 0, 248714
AppSec [baseline] (31.3 ms) : 0, 31300
AppSec [candidate] (31.112 ms) : 0, 31112
Debugger [baseline] (6.464 ms) : 0, 6464
Debugger [candidate] (6.369 ms) : 0, 6369
Remote Config [baseline] (695.28 µs) : 0, 695
Remote Config [candidate] (690.278 µs) : 0, 690
Telemetry [baseline] (9.06 ms) : 0, 9060
Telemetry [candidate] (9.012 ms) : 0, 9012
section iast
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.481 ms) : 0, 1481
BytebuddyAgent [baseline] (820.121 ms) : 0, 820121
BytebuddyAgent [candidate] (819.121 ms) : 0, 819121
GlobalTracer [baseline] (240.051 ms) : 0, 240051
GlobalTracer [candidate] (238.609 ms) : 0, 238609
AppSec [baseline] (34.277 ms) : 0, 34277
AppSec [candidate] (34.038 ms) : 0, 34038
Debugger [baseline] (6.149 ms) : 0, 6149
Debugger [candidate] (6.109 ms) : 0, 6109
Remote Config [baseline] (625.131 µs) : 0, 625
Remote Config [candidate] (596.833 µs) : 0, 597
Telemetry [baseline] (8.52 ms) : 0, 8520
Telemetry [candidate] (8.469 ms) : 0, 8469
IAST [baseline] (26.513 ms) : 0, 26513
IAST [candidate] (26.477 ms) : 0, 26477
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~8fd87fbedd, baseline=1.54.0-SNAPSHOT~1450a11e5d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.007 s) : 0, 1007336
Total [baseline] (10.759 s) : 0, 10759419
Agent [candidate] (1.009 s) : 0, 1008920
Total [candidate] (10.663 s) : 0, 10662653
section appsec
Agent [baseline] (1.192 s) : 0, 1191833
Total [baseline] (10.966 s) : 0, 10965738
Agent [candidate] (1.188 s) : 0, 1188125
Total [candidate] (11.053 s) : 0, 11052717
section iast
Agent [baseline] (1.144 s) : 0, 1144336
Total [baseline] (10.938 s) : 0, 10938007
Agent [candidate] (1.145 s) : 0, 1145401
Total [candidate] (10.988 s) : 0, 10987636
section profiling
Agent [baseline] (1.159 s) : 0, 1158613
Total [baseline] (11.171 s) : 0, 11171019
Agent [candidate] (1.154 s) : 0, 1153956
Total [candidate] (11.072 s) : 0, 11071523
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~8fd87fbedd, baseline=1.54.0-SNAPSHOT~1450a11e5d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (689.548 ms) : 0, 689548
BytebuddyAgent [candidate] (691.322 ms) : 0, 691322
GlobalTracer [baseline] (248.203 ms) : 0, 248203
GlobalTracer [candidate] (248.298 ms) : 0, 248298
AppSec [baseline] (30.894 ms) : 0, 30894
AppSec [candidate] (30.697 ms) : 0, 30697
Debugger [baseline] (6.372 ms) : 0, 6372
Debugger [candidate] (6.342 ms) : 0, 6342
Remote Config [baseline] (679.897 µs) : 0, 680
Remote Config [candidate] (678.576 µs) : 0, 679
Telemetry [baseline] (9.009 ms) : 0, 9009
Telemetry [candidate] (8.941 ms) : 0, 8941
section appsec
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (714.619 ms) : 0, 714619
BytebuddyAgent [candidate] (711.996 ms) : 0, 711996
GlobalTracer [baseline] (240.995 ms) : 0, 240995
GlobalTracer [candidate] (241.035 ms) : 0, 241035
AppSec [baseline] (171.486 ms) : 0, 171486
AppSec [candidate] (170.902 ms) : 0, 170902
Debugger [baseline] (6.041 ms) : 0, 6041
Debugger [candidate] (6.832 ms) : 0, 6832
Remote Config [baseline] (647.343 µs) : 0, 647
Remote Config [candidate] (647.644 µs) : 0, 648
Telemetry [baseline] (10.659 ms) : 0, 10659
Telemetry [candidate] (9.257 ms) : 0, 9257
IAST [baseline] (24.724 ms) : 0, 24724
IAST [candidate] (24.844 ms) : 0, 24844
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (809.668 ms) : 0, 809668
BytebuddyAgent [candidate] (810.253 ms) : 0, 810253
GlobalTracer [baseline] (236.855 ms) : 0, 236855
GlobalTracer [candidate] (237.68 ms) : 0, 237680
AppSec [baseline] (33.96 ms) : 0, 33960
AppSec [candidate] (33.63 ms) : 0, 33630
Debugger [baseline] (6.074 ms) : 0, 6074
Debugger [candidate] (5.998 ms) : 0, 5998
Remote Config [baseline] (596.244 µs) : 0, 596
Remote Config [candidate] (583.514 µs) : 0, 584
Telemetry [baseline] (8.218 ms) : 0, 8218
Telemetry [candidate] (8.241 ms) : 0, 8241
IAST [baseline] (26.093 ms) : 0, 26093
IAST [candidate] (26.129 ms) : 0, 26129
section profiling
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (722.619 ms) : 0, 722619
BytebuddyAgent [candidate] (719.307 ms) : 0, 719307
GlobalTracer [baseline] (224.937 ms) : 0, 224937
GlobalTracer [candidate] (224.744 ms) : 0, 224744
AppSec [baseline] (31.663 ms) : 0, 31663
AppSec [candidate] (31.403 ms) : 0, 31403
Debugger [baseline] (8.191 ms) : 0, 8191
Debugger [candidate] (6.554 ms) : 0, 6554
Remote Config [baseline] (732.522 µs) : 0, 733
Remote Config [candidate] (697.469 µs) : 0, 697
Telemetry [baseline] (14.894 ms) : 0, 14894
Telemetry [candidate] (16.117 ms) : 0, 16117
ProfilingAgent [baseline] (102.022 ms) : 0, 102022
ProfilingAgent [candidate] (101.261 ms) : 0, 101261
Profiling [baseline] (102.644 ms) : 0, 102644
Profiling [candidate] (101.86 ms) : 0, 101860
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~8fd87fbedd, baseline=1.54.0-SNAPSHOT~1450a11e5d
dateFormat X
axisFormat %s
section baseline
no_agent (4.364 ms) : 4309, 4420
. : milestone, 4364,
iast (9.156 ms) : 9006, 9305
. : milestone, 9156,
iast_FULL (14.0 ms) : 13721, 14279
. : milestone, 14000,
iast_GLOBAL (10.857 ms) : 10658, 11056
. : milestone, 10857,
profiling (8.95 ms) : 8811, 9089
. : milestone, 8950,
tracing (7.477 ms) : 7366, 7589
. : milestone, 7477,
section candidate
no_agent (4.258 ms) : 4211, 4305
. : milestone, 4258,
iast (9.48 ms) : 9323, 9637
. : milestone, 9480,
iast_FULL (13.924 ms) : 13653, 14196
. : milestone, 13924,
iast_GLOBAL (10.892 ms) : 10694, 11090
. : milestone, 10892,
profiling (9.017 ms) : 8878, 9156
. : milestone, 9017,
tracing (8.192 ms) : 8069, 8315
. : milestone, 8192,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~8fd87fbedd, baseline=1.54.0-SNAPSHOT~1450a11e5d
dateFormat X
axisFormat %s
section baseline
no_agent (36.627 ms) : 36325, 36929
. : milestone, 36627,
appsec (48.551 ms) : 48124, 48978
. : milestone, 48551,
code_origins (43.561 ms) : 43181, 43941
. : milestone, 43561,
iast (43.244 ms) : 42881, 43606
. : milestone, 43244,
profiling (48.083 ms) : 47607, 48560
. : milestone, 48083,
tracing (45.501 ms) : 45118, 45884
. : milestone, 45501,
section candidate
no_agent (36.635 ms) : 36333, 36938
. : milestone, 36635,
appsec (49.041 ms) : 48604, 49478
. : milestone, 49041,
code_origins (45.894 ms) : 45505, 46283
. : milestone, 45894,
iast (45.795 ms) : 45406, 46184
. : milestone, 45795,
profiling (45.612 ms) : 45188, 46036
. : milestone, 45612,
tracing (44.332 ms) : 43957, 44706
. : milestone, 44332,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~8fd87fbedd, baseline=1.54.0-SNAPSHOT~1450a11e5d
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.672 ms) : 3456, 3888
. : milestone, 3672,
iast (2.201 ms) : 2138, 2264
. : milestone, 2201,
iast_GLOBAL (2.234 ms) : 2171, 2298
. : milestone, 2234,
profiling (2.051 ms) : 1999, 2103
. : milestone, 2051,
tracing (2.012 ms) : 1964, 2061
. : milestone, 2012,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.615 ms) : 3403, 3827
. : milestone, 3615,
iast (2.203 ms) : 2140, 2266
. : milestone, 2203,
iast_GLOBAL (2.234 ms) : 2170, 2297
. : milestone, 2234,
profiling (2.057 ms) : 2005, 2109
. : milestone, 2057,
tracing (2.006 ms) : 1957, 2055
. : milestone, 2006,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~8fd87fbedd, baseline=1.54.0-SNAPSHOT~1450a11e5d
dateFormat X
axisFormat %s
section baseline
no_agent (15.404 s) : 15404000, 15404000
. : milestone, 15404000,
appsec (15.045 s) : 15045000, 15045000
. : milestone, 15045000,
iast (18.682 s) : 18682000, 18682000
. : milestone, 18682000,
iast_GLOBAL (18.046 s) : 18046000, 18046000
. : milestone, 18046000,
profiling (15.45 s) : 15450000, 15450000
. : milestone, 15450000,
tracing (15.166 s) : 15166000, 15166000
. : milestone, 15166000,
section candidate
no_agent (15.513 s) : 15513000, 15513000
. : milestone, 15513000,
appsec (15.272 s) : 15272000, 15272000
. : milestone, 15272000,
iast (18.692 s) : 18692000, 18692000
. : milestone, 18692000,
iast_GLOBAL (18.075 s) : 18075000, 18075000
. : milestone, 18075000,
profiling (15.175 s) : 15175000, 15175000
. : milestone, 15175000,
tracing (15.308 s) : 15308000, 15308000
. : milestone, 15308000,
|
57483a2 to
1574d9b
Compare
|
🎯 Code Coverage 🔗 Commit SHA: 8fd87fb | Docs | Was this helpful? Give us feedback! |
…module (#9566) * adding supported-configurations.json file * migrating config-utils tests and ConfigInversionMetric telemetry * updating coverage and native image test * removing extra supported-configurations.json * adding dependency * updating excluded class coverage
What Does This Do
This PR migrates the tests from the classes in #9426 to
config-utils, and migrates an abstracted version ofConfigInversionMetricCollectortoconfig-utilswhile keeping the implementation ininternal-api. This way, the telemetry can be used inconfig-utilsbut still registered within theConfigobject.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]