Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions utils/config-utils/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -30,20 +30,23 @@ val excludedClassesCoverage by extra(
"datadog.trace.bootstrap.config.provider.stableconfig.Selector",
// tested in internal-api
"datadog.trace.bootstrap.config.provider.StableConfigParser",
"datadog.trace.bootstrap.config.provider.SystemPropertiesConfigSource",
"datadog.trace.bootstrap.config.provider.SystemPropertiesConfigSource"
)
)

val excludedClassesBranchCoverage by extra(
listOf(
"datadog.trace.bootstrap.config.provider.AgentArgsInjector",
// Enum
"datadog.trace.config.inversion.ConfigHelper.StrictnessPolicy",
"datadog.trace.util.ConfigStrings"
)
)

val excludedClassesInstructionCoverage by extra(
listOf(
"datadog.trace.config.inversion.GeneratedSupportedConfigurations"
"datadog.trace.config.inversion.GeneratedSupportedConfigurations",
"datadog.trace.config.inversion.SupportedConfigurationSource"
)
)

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,153 @@
package datadog.trace.config.inversion;

import datadog.environment.EnvironmentVariables;
import datadog.trace.api.telemetry.ConfigInversionMetricCollectorProvider;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

public class ConfigHelper {

/** Config Inversion strictness policy for enforcement of undocumented environment variables */
public enum StrictnessPolicy {
STRICT,
WARNING,
TEST;

private String displayName;

StrictnessPolicy() {
this.displayName = name().toLowerCase(Locale.ROOT);
}

@Override
public String toString() {
if (displayName == null) {
displayName = name().toLowerCase(Locale.ROOT);
}
return displayName;
}
}

private static final Logger log = LoggerFactory.getLogger(ConfigHelper.class);

private static final ConfigHelper INSTANCE = new ConfigHelper();

private StrictnessPolicy configInversionStrict = StrictnessPolicy.WARNING;

private static final String DD_PREFIX = "DD_";
private static final String OTEL_PREFIX = "OTEL_";

// Cache for configs, init value is EmptyMap
private Map<String, String> configs = Collections.emptyMap();

// Default to production source
private SupportedConfigurationSource configSource = new SupportedConfigurationSource();

public static ConfigHelper get() {
return INSTANCE;
}

public void setConfigInversionStrict(StrictnessPolicy configInversionStrict) {
this.configInversionStrict = configInversionStrict;
}

public StrictnessPolicy configInversionStrictFlag() {
return configInversionStrict;
}

// Used only for testing purposes
void setConfigurationSource(SupportedConfigurationSource testSource) {
configSource = testSource;
}

/** Resetting config cache. Useful for cleaning up after tests. */
void resetCache() {
configs = Collections.emptyMap();
}

/** Reset all configuration data to the generated defaults. Useful for cleaning up after tests. */
void resetToDefaults() {
configSource = new SupportedConfigurationSource();
this.configInversionStrict = StrictnessPolicy.WARNING;
resetCache();
}

public Map<String, String> getEnvironmentVariables() {
if (!configs.isEmpty()) {
return configs;
}

// Initial value is EmptyMap
configs = new HashMap<>();

Map<String, String> env = EnvironmentVariables.getAll();
for (Map.Entry<String, String> entry : env.entrySet()) {
String key = entry.getKey();
String value = entry.getValue();
String primaryEnv = configSource.primaryEnvFromAlias(key);
if (key.startsWith(DD_PREFIX) || key.startsWith(OTEL_PREFIX) || primaryEnv != null) {
if (configSource.supported(key)) {
configs.put(key, value);
// If this environment variable is the alias of another, and we haven't processed the
// original environment variable yet, handle it here.
} else if (primaryEnv != null && !configs.containsKey(primaryEnv)) {
List<String> aliases = configSource.getAliases(primaryEnv);
for (String alias : aliases) {
if (env.containsKey(alias)) {
configs.put(primaryEnv, env.get(alias));
break;
}
}
}
String envFromDeprecated = configSource.primaryEnvFromDeprecated(key);
if (envFromDeprecated != null) {
String warning =
"Environment variable "
+ key
+ " is deprecated. Please use "
+ (primaryEnv != null ? primaryEnv : envFromDeprecated)
+ " instead.";
log.warn(warning);
}
} else {
configs.put(key, value);
}
}
return configs;
}

public String getEnvironmentVariable(String name) {
if (configs.containsKey(name)) {
return configs.get(name);
}

if ((name.startsWith(DD_PREFIX) || name.startsWith(OTEL_PREFIX))
&& configSource.primaryEnvFromAlias(name) == null
&& !configSource.supported(name)) {
if (configInversionStrict != StrictnessPolicy.TEST) {
ConfigInversionMetricCollectorProvider.get().setUndocumentedEnvVarMetric(name);
}

if (configInversionStrict == StrictnessPolicy.STRICT) {
return null; // If strict mode is enabled, return null for unsupported configs
}
}

String config = EnvironmentVariables.get(name);
List<String> aliases;
if (config == null && (aliases = configSource.getAliases(name)) != null) {
for (String alias : aliases) {
String aliasValue = EnvironmentVariables.get(alias);
if (aliasValue != null) {
return aliasValue;
}
}
}
return config;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
package datadog.trace.config.inversion;

import java.util.Collections;
import java.util.List;

/**
* This class uses {@link #GeneratedSupportedConfigurations} for handling supported configurations
* for Config Inversion Can be extended for testing with custom configuration data.
*/
class SupportedConfigurationSource {

/** @return Set of supported environment variable keys */
public boolean supported(String env) {
return GeneratedSupportedConfigurations.SUPPORTED.contains(env);
}

/** @return List of aliases for an environment variable */
public List<String> getAliases(String env) {
return GeneratedSupportedConfigurations.ALIASES.getOrDefault(env, Collections.emptyList());
}

/** @return Primary environment variable for a queried alias */
public String primaryEnvFromAlias(String alias) {
return GeneratedSupportedConfigurations.ALIAS_MAPPING.getOrDefault(alias, null);
}

/** @return Map of deprecated configurations */
public String primaryEnvFromDeprecated(String deprecated) {
return GeneratedSupportedConfigurations.DEPRECATED.getOrDefault(deprecated, null);
}
}
Loading