-
Notifications
You must be signed in to change notification settings - Fork 315
Ensure health metrics are closed when the tracer is closed #9511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: ac168dd | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~ac168ddc32, baseline=1.54.0-SNAPSHOT~036fe910ec
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063277
Total [baseline] (10.774 s) : 0, 10774119
Agent [candidate] (1.044 s) : 0, 1044183
Total [candidate] (10.895 s) : 0, 10895343
section appsec
Agent [baseline] (1.225 s) : 0, 1224631
Total [baseline] (10.855 s) : 0, 10855329
Agent [candidate] (1.224 s) : 0, 1223958
Total [candidate] (10.835 s) : 0, 10835001
section iast
Agent [baseline] (1.189 s) : 0, 1189115
Total [baseline] (10.995 s) : 0, 10994808
Agent [candidate] (1.187 s) : 0, 1186797
Total [candidate] (10.948 s) : 0, 10948146
section profiling
Agent [baseline] (1.21 s) : 0, 1209614
Total [baseline] (10.892 s) : 0, 10892173
Agent [candidate] (1.205 s) : 0, 1204971
Total [candidate] (10.943 s) : 0, 10943157
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~ac168ddc32, baseline=1.54.0-SNAPSHOT~036fe910ec
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (742.026 ms) : 0, 742026
BytebuddyAgent [candidate] (731.989 ms) : 0, 731989
GlobalTracer [baseline] (245.482 ms) : 0, 245482
GlobalTracer [candidate] (242.612 ms) : 0, 242612
AppSec [baseline] (30.949 ms) : 0, 30949
AppSec [candidate] (30.466 ms) : 0, 30466
Debugger [baseline] (6.483 ms) : 0, 6483
Debugger [candidate] (6.423 ms) : 0, 6423
Remote Config [baseline] (698.005 µs) : 0, 698
Remote Config [candidate] (674.822 µs) : 0, 675
Telemetry [baseline] (14.812 ms) : 0, 14812
Telemetry [candidate] (9.453 ms) : 0, 9453
section appsec
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (754.892 ms) : 0, 754892
BytebuddyAgent [candidate] (754.723 ms) : 0, 754723
GlobalTracer [baseline] (235.832 ms) : 0, 235832
GlobalTracer [candidate] (235.727 ms) : 0, 235727
IAST [baseline] (23.543 ms) : 0, 23543
IAST [candidate] (23.447 ms) : 0, 23447
AppSec [baseline] (169.433 ms) : 0, 169433
AppSec [candidate] (169.243 ms) : 0, 169243
Debugger [baseline] (7.559 ms) : 0, 7559
Debugger [candidate] (8.39 ms) : 0, 8390
Remote Config [baseline] (654.656 µs) : 0, 655
Remote Config [candidate] (642.765 µs) : 0, 643
Telemetry [baseline] (10.15 ms) : 0, 10150
Telemetry [candidate] (9.236 ms) : 0, 9236
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (859.013 ms) : 0, 859013
BytebuddyAgent [candidate] (856.575 ms) : 0, 856575
GlobalTracer [baseline] (234.557 ms) : 0, 234557
GlobalTracer [candidate] (234.07 ms) : 0, 234070
IAST [baseline] (30.57 ms) : 0, 30570
IAST [candidate] (30.954 ms) : 0, 30954
AppSec [baseline] (26.363 ms) : 0, 26363
AppSec [candidate] (25.669 ms) : 0, 25669
Debugger [baseline] (7.031 ms) : 0, 7031
Debugger [candidate] (7.891 ms) : 0, 7891
Remote Config [baseline] (604.978 µs) : 0, 605
Remote Config [candidate] (632.408 µs) : 0, 632
Telemetry [baseline] (8.244 ms) : 0, 8244
Telemetry [candidate] (8.324 ms) : 0, 8324
section profiling
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.433 ms) : 0, 1433
BytebuddyAgent [baseline] (767.729 ms) : 0, 767729
BytebuddyAgent [candidate] (765.192 ms) : 0, 765192
GlobalTracer [baseline] (224.821 ms) : 0, 224821
GlobalTracer [candidate] (224.347 ms) : 0, 224347
AppSec [baseline] (31.179 ms) : 0, 31179
AppSec [candidate] (31.1 ms) : 0, 31100
Debugger [baseline] (6.732 ms) : 0, 6732
Debugger [candidate] (6.775 ms) : 0, 6775
Remote Config [baseline] (730.202 µs) : 0, 730
Remote Config [candidate] (697.4 µs) : 0, 697
Telemetry [baseline] (16.598 ms) : 0, 16598
Telemetry [candidate] (16.687 ms) : 0, 16687
ProfilingAgent [baseline] (109.45 ms) : 0, 109450
ProfilingAgent [candidate] (107.744 ms) : 0, 107744
Profiling [baseline] (110.14 ms) : 0, 110140
Profiling [candidate] (108.476 ms) : 0, 108476
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~ac168ddc32, baseline=1.54.0-SNAPSHOT~036fe910ec
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060528
Total [baseline] (8.68 s) : 0, 8680433
Agent [candidate] (1.046 s) : 0, 1046051
Total [candidate] (8.648 s) : 0, 8647568
section iast
Agent [baseline] (1.186 s) : 0, 1186365
Total [baseline] (9.355 s) : 0, 9355130
Agent [candidate] (1.185 s) : 0, 1184598
Total [candidate] (9.376 s) : 0, 9375682
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~ac168ddc32, baseline=1.54.0-SNAPSHOT~036fe910ec
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (739.334 ms) : 0, 739334
BytebuddyAgent [candidate] (732.268 ms) : 0, 732268
GlobalTracer [baseline] (245.491 ms) : 0, 245491
GlobalTracer [candidate] (242.219 ms) : 0, 242219
AppSec [baseline] (31.035 ms) : 0, 31035
AppSec [candidate] (30.409 ms) : 0, 30409
Debugger [baseline] (6.523 ms) : 0, 6523
Debugger [candidate] (6.414 ms) : 0, 6414
Remote Config [baseline] (691.941 µs) : 0, 692
Remote Config [candidate] (673.84 µs) : 0, 674
Telemetry [baseline] (14.716 ms) : 0, 14716
Telemetry [candidate] (11.536 ms) : 0, 11536
section iast
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (855.846 ms) : 0, 855846
BytebuddyAgent [candidate] (854.457 ms) : 0, 854457
GlobalTracer [baseline] (234.016 ms) : 0, 234016
GlobalTracer [candidate] (233.904 ms) : 0, 233904
IAST [baseline] (29.764 ms) : 0, 29764
IAST [candidate] (30.592 ms) : 0, 30592
AppSec [baseline] (27.308 ms) : 0, 27308
AppSec [candidate] (26.412 ms) : 0, 26412
Debugger [baseline] (7.86 ms) : 0, 7860
Debugger [candidate] (7.796 ms) : 0, 7796
Remote Config [baseline] (607.474 µs) : 0, 607
Remote Config [candidate] (618.799 µs) : 0, 619
Telemetry [baseline] (8.353 ms) : 0, 8353
Telemetry [candidate] (8.272 ms) : 0, 8272
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~ac168ddc32, baseline=1.54.0-SNAPSHOT~036fe910ec
dateFormat X
axisFormat %s
section baseline
no_agent (36.677 ms) : 36376, 36977
. : milestone, 36677,
appsec (48.236 ms) : 47810, 48661
. : milestone, 48236,
code_origins (45.975 ms) : 45553, 46396
. : milestone, 45975,
iast (46.219 ms) : 45820, 46617
. : milestone, 46219,
profiling (48.594 ms) : 48116, 49072
. : milestone, 48594,
tracing (44.134 ms) : 43751, 44517
. : milestone, 44134,
section candidate
no_agent (37.79 ms) : 37478, 38103
. : milestone, 37790,
appsec (47.042 ms) : 46607, 47477
. : milestone, 47042,
code_origins (44.645 ms) : 44256, 45033
. : milestone, 44645,
iast (44.496 ms) : 44095, 44896
. : milestone, 44496,
profiling (49.322 ms) : 48869, 49776
. : milestone, 49322,
tracing (44.869 ms) : 44486, 45252
. : milestone, 44869,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~ac168ddc32, baseline=1.54.0-SNAPSHOT~036fe910ec
dateFormat X
axisFormat %s
section baseline
no_agent (4.474 ms) : 4422, 4525
. : milestone, 4474,
iast (9.369 ms) : 9213, 9525
. : milestone, 9369,
iast_FULL (13.929 ms) : 13655, 14204
. : milestone, 13929,
iast_GLOBAL (10.762 ms) : 10570, 10955
. : milestone, 10762,
profiling (9.031 ms) : 8889, 9174
. : milestone, 9031,
tracing (7.834 ms) : 7720, 7947
. : milestone, 7834,
section candidate
no_agent (4.348 ms) : 4298, 4398
. : milestone, 4348,
iast (9.581 ms) : 9424, 9738
. : milestone, 9581,
iast_FULL (14.176 ms) : 13895, 14457
. : milestone, 14176,
iast_GLOBAL (10.981 ms) : 10784, 11178
. : milestone, 10981,
profiling (9.183 ms) : 9042, 9324
. : milestone, 9183,
tracing (7.762 ms) : 7650, 7873
. : milestone, 7762,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~ac168ddc32, baseline=1.54.0-SNAPSHOT~036fe910ec
dateFormat X
axisFormat %s
section baseline
no_agent (15.592 s) : 15592000, 15592000
. : milestone, 15592000,
appsec (14.891 s) : 14891000, 14891000
. : milestone, 14891000,
iast (18.343 s) : 18343000, 18343000
. : milestone, 18343000,
iast_GLOBAL (17.852 s) : 17852000, 17852000
. : milestone, 17852000,
profiling (15.876 s) : 15876000, 15876000
. : milestone, 15876000,
tracing (14.666 s) : 14666000, 14666000
. : milestone, 14666000,
section candidate
no_agent (14.976 s) : 14976000, 14976000
. : milestone, 14976000,
appsec (14.973 s) : 14973000, 14973000
. : milestone, 14973000,
iast (18.769 s) : 18769000, 18769000
. : milestone, 18769000,
iast_GLOBAL (18.02 s) : 18020000, 18020000
. : milestone, 18020000,
profiling (15.293 s) : 15293000, 15293000
. : milestone, 15293000,
tracing (15.135 s) : 15135000, 15135000
. : milestone, 15135000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~ac168ddc32, baseline=1.54.0-SNAPSHOT~036fe910ec
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.718 ms) : 3498, 3938
. : milestone, 3718,
iast (2.21 ms) : 2147, 2273
. : milestone, 2210,
iast_GLOBAL (2.246 ms) : 2183, 2309
. : milestone, 2246,
profiling (2.061 ms) : 2009, 2113
. : milestone, 2061,
tracing (2.024 ms) : 1975, 2074
. : milestone, 2024,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.721 ms) : 3502, 3940
. : milestone, 3721,
iast (2.208 ms) : 2145, 2271
. : milestone, 2208,
iast_GLOBAL (2.252 ms) : 2189, 2315
. : milestone, 2252,
profiling (2.05 ms) : 1999, 2101
. : milestone, 2050,
tracing (2.031 ms) : 1982, 2081
. : milestone, 2031,
|
What Does This Do
Health metrics reporter must be closed when the tracer is closed. Especially for tests, this accumulates runnables scheduled when the test is finished (and the tracer closed)
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]