Ensure info discovery state change is atomic #9497

amarziali · 2025-09-09T15:38:29Z

What Does This Do

The feature discovery should maintain its state preserved until the discovery and parsing of the info endpoint is done.
In particular, when a discovery is triggered, the state was reset and this led to have inconsistent values in between (i.e. metrics were disabled temporary until the discovery finished).

This PR makes sure the state is swapped atomically when the new is available

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

github-actions · 2025-09-09T15:38:40Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

amarziali · 2025-09-09T15:40:23Z

communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java

-
-  private long lastTimeDiscovered;
+  private static class State {
+    String traceEndpoint;


didn't put those final to avoid having a too heavy refactoring to do on this sensible part

Yeah, this stuff should basically be an immutable record...

datadog-datadog-prod-us1 · 2025-09-09T16:16:39Z

🎯 Code Coverage
• Patch Coverage: 96.36%
• Total Coverage: 59.43% (+1.57%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 8663672 | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-09-09T16:30:37Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/discovery-atomic
git_commit_date	1757412728	1757433156
git_commit_sha	`f284153`	`b6bd66b`
release_version	1.54.0-SNAPSHOT~f284153719	1.54.0-SNAPSHOT~b6bd66bec5

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1757435091	1757435091
ci_job_id	1120834145	1120834145
ci_pipeline_id	75970309	75970309
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-nerj7z52 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-nerj7z52 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~b6bd66bec5, baseline=1.54.0-SNAPSHOT~f284153719

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048750
Total [baseline] (10.692 s) : 0, 10692103
Agent [candidate] (1.049 s) : 0, 1049461
Total [candidate] (10.683 s) : 0, 10682507
section appsec
Agent [baseline] (1.225 s) : 0, 1225315
Total [baseline] (10.848 s) : 0, 10847991
Agent [candidate] (1.231 s) : 0, 1231021
Total [candidate] (10.863 s) : 0, 10862672
section iast
Agent [baseline] (1.183 s) : 0, 1182653
Total [baseline] (10.963 s) : 0, 10963131
Agent [candidate] (1.182 s) : 0, 1181698
Total [candidate] (10.912 s) : 0, 10912079
section profiling
Agent [baseline] (1.206 s) : 0, 1206076
Total [baseline] (10.938 s) : 0, 10938263
Agent [candidate] (1.201 s) : 0, 1201348
Total [candidate] (10.87 s) : 0, 10870131

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.049 s	-
Agent	appsec	1.225 s	176.565 ms (16.8%)
Agent	iast	1.183 s	133.903 ms (12.8%)
Agent	profiling	1.206 s	157.326 ms (15.0%)
Total	tracing	10.692 s	-
Total	appsec	10.848 s	155.888 ms (1.5%)
Total	iast	10.963 s	271.027 ms (2.5%)
Total	profiling	10.938 s	246.159 ms (2.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.049 s	-
Agent	appsec	1.231 s	181.56 ms (17.3%)
Agent	iast	1.182 s	132.237 ms (12.6%)
Agent	profiling	1.201 s	151.887 ms (14.5%)
Total	tracing	10.683 s	-
Total	appsec	10.863 s	180.166 ms (1.7%)
Total	iast	10.912 s	229.572 ms (2.1%)
Total	profiling	10.87 s	187.624 ms (1.8%)

gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~b6bd66bec5, baseline=1.54.0-SNAPSHOT~f284153719

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (733.946 ms) : 0, 733946
BytebuddyAgent [candidate] (733.662 ms) : 0, 733662
GlobalTracer [baseline] (242.655 ms) : 0, 242655
GlobalTracer [candidate] (242.776 ms) : 0, 242776
AppSec [baseline] (30.201 ms) : 0, 30201
AppSec [candidate] (30.249 ms) : 0, 30249
Debugger [baseline] (6.412 ms) : 0, 6412
Debugger [candidate] (6.423 ms) : 0, 6423
Remote Config [baseline] (676.999 µs) : 0, 677
Remote Config [candidate] (674.769 µs) : 0, 675
Telemetry [baseline] (12.352 ms) : 0, 12352
Telemetry [candidate] (13.111 ms) : 0, 13111
section appsec
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (756.497 ms) : 0, 756497
BytebuddyAgent [candidate] (760.233 ms) : 0, 760233
GlobalTracer [baseline] (235.754 ms) : 0, 235754
GlobalTracer [candidate] (236.824 ms) : 0, 236824
IAST [baseline] (23.68 ms) : 0, 23680
IAST [candidate] (23.901 ms) : 0, 23901
AppSec [baseline] (169.368 ms) : 0, 169368
AppSec [candidate] (170.625 ms) : 0, 170625
Debugger [baseline] (7.536 ms) : 0, 7536
Debugger [candidate] (7.581 ms) : 0, 7581
Remote Config [baseline] (629.784 µs) : 0, 630
Remote Config [candidate] (623.08 µs) : 0, 623
Telemetry [baseline] (9.338 ms) : 0, 9338
Telemetry [candidate] (8.594 ms) : 0, 8594
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (853.164 ms) : 0, 853164
BytebuddyAgent [candidate] (852.447 ms) : 0, 852447
GlobalTracer [baseline] (233.682 ms) : 0, 233682
GlobalTracer [candidate] (233.714 ms) : 0, 233714
IAST [baseline] (31.119 ms) : 0, 31119
IAST [candidate] (32.764 ms) : 0, 32764
AppSec [baseline] (26.186 ms) : 0, 26186
AppSec [candidate] (25.192 ms) : 0, 25192
Debugger [baseline] (6.989 ms) : 0, 6989
Debugger [candidate] (6.131 ms) : 0, 6131
Remote Config [baseline] (609.799 µs) : 0, 610
Remote Config [candidate] (603.97 µs) : 0, 604
Telemetry [baseline] (8.327 ms) : 0, 8327
Telemetry [candidate] (8.278 ms) : 0, 8278
section profiling
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.424 ms) : 0, 1424
BytebuddyAgent [baseline] (766.728 ms) : 0, 766728
BytebuddyAgent [candidate] (762.801 ms) : 0, 762801
GlobalTracer [baseline] (224.152 ms) : 0, 224152
GlobalTracer [candidate] (224.084 ms) : 0, 224084
AppSec [baseline] (30.714 ms) : 0, 30714
AppSec [candidate] (30.507 ms) : 0, 30507
Debugger [baseline] (8.208 ms) : 0, 8208
Debugger [candidate] (7.516 ms) : 0, 7516
Remote Config [baseline] (725.503 µs) : 0, 726
Remote Config [candidate] (692.453 µs) : 0, 692
Telemetry [baseline] (14.918 ms) : 0, 14918
Telemetry [candidate] (15.769 ms) : 0, 15769
ProfilingAgent [baseline] (108.371 ms) : 0, 108371
ProfilingAgent [candidate] (107.976 ms) : 0, 107976
Profiling [baseline] (109.037 ms) : 0, 109037
Profiling [candidate] (108.703 ms) : 0, 108703

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~b6bd66bec5, baseline=1.54.0-SNAPSHOT~f284153719

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056149
Total [baseline] (8.674 s) : 0, 8674431
Agent [candidate] (1.049 s) : 0, 1048536
Total [candidate] (8.643 s) : 0, 8643495
section iast
Agent [baseline] (1.19 s) : 0, 1190049
Total [baseline] (9.397 s) : 0, 9397207
Agent [candidate] (1.178 s) : 0, 1178186
Total [candidate] (9.356 s) : 0, 9355934

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.056 s	-
Agent	iast	1.19 s	133.9 ms (12.7%)
Total	tracing	8.674 s	-
Total	iast	9.397 s	722.776 ms (8.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.049 s	-
Agent	iast	1.178 s	129.65 ms (12.4%)
Total	tracing	8.643 s	-
Total	iast	9.356 s	712.439 ms (8.2%)

gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~b6bd66bec5, baseline=1.54.0-SNAPSHOT~f284153719

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (739.189 ms) : 0, 739189
BytebuddyAgent [candidate] (734.46 ms) : 0, 734460
GlobalTracer [baseline] (244.089 ms) : 0, 244089
GlobalTracer [candidate] (243.051 ms) : 0, 243051
AppSec [baseline] (30.555 ms) : 0, 30555
AppSec [candidate] (30.397 ms) : 0, 30397
Debugger [baseline] (6.453 ms) : 0, 6453
Debugger [candidate] (6.472 ms) : 0, 6472
Remote Config [baseline] (693.326 µs) : 0, 693
Remote Config [candidate] (679.521 µs) : 0, 680
Telemetry [baseline] (12.539 ms) : 0, 12539
Telemetry [candidate] (10.971 ms) : 0, 10971
section iast
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (859.172 ms) : 0, 859172
BytebuddyAgent [candidate] (850.191 ms) : 0, 850191
GlobalTracer [baseline] (235.198 ms) : 0, 235198
GlobalTracer [candidate] (232.515 ms) : 0, 232515
IAST [baseline] (28.141 ms) : 0, 28141
IAST [candidate] (30.968 ms) : 0, 30968
AppSec [baseline] (28.901 ms) : 0, 28901
AppSec [candidate] (26.082 ms) : 0, 26082
Debugger [baseline] (7.023 ms) : 0, 7023
Debugger [candidate] (7.02 ms) : 0, 7020
Remote Config [baseline] (619.326 µs) : 0, 619
Remote Config [candidate] (613.669 µs) : 0, 614
Telemetry [baseline] (8.354 ms) : 0, 8354
Telemetry [candidate] (8.306 ms) : 0, 8306

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/discovery-atomic
git_commit_date	1757412728	1757433156
git_commit_sha	`f284153`	`b6bd66b`
release_version	1.54.0-SNAPSHOT~f284153719	1.54.0-SNAPSHOT~b6bd66bec5

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1757434758	1757434758
ci_job_id	1120834146	1120834146
ci_pipeline_id	75970309	75970309
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-mwvreuuu 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-mwvreuuu 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:no_agent:high_load	worse [+228.717µs; +337.290µs] or [+5.516%; +8.135%]	unstable [-193.961op/s; +55.773op/s] or [-17.544%; +5.045%]	4.429ms	1036.500op/s	4.146ms	1105.594op/s
scenario:load:petclinic:iast:high_load	better [-2.278ms; -1.447ms] or [-4.957%; -3.148%]	unstable [-3.109op/s; +11.684op/s] or [-3.056%; +11.482%]	44.096ms	106.050op/s	45.959ms	101.763op/s
scenario:load:petclinic:tracing:high_load	better [-2.887ms; -2.066ms] or [-6.250%; -4.473%]	unstable [+0.219op/s; +13.916op/s] or [+0.216%; +13.733%]	43.709ms	108.405op/s	46.185ms	101.338op/s
scenario:load:petclinic:code_origins:high_load	worse [+0.939ms; +1.771ms] or [+2.132%; +4.021%]	unstable [-10.620op/s; +4.345op/s] or [-10.004%; +4.093%]	45.413ms	103.025op/s	44.058ms	106.162op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~b6bd66bec5, baseline=1.54.0-SNAPSHOT~f284153719
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.262 ms) : 36960, 37564
.   : milestone, 37262,
appsec (47.696 ms) : 47282, 48110
.   : milestone, 47696,
code_origins (44.058 ms) : 43682, 44434
.   : milestone, 44058,
iast (45.959 ms) : 45570, 46348
.   : milestone, 45959,
profiling (48.794 ms) : 48301, 49287
.   : milestone, 48794,
tracing (46.185 ms) : 45788, 46582
.   : milestone, 46185,
section candidate
no_agent (37.698 ms) : 37386, 38011
.   : milestone, 37698,
appsec (48.816 ms) : 48402, 49231
.   : milestone, 48816,
code_origins (45.413 ms) : 45016, 45810
.   : milestone, 45413,
iast (44.096 ms) : 43713, 44480
.   : milestone, 44096,
profiling (49.273 ms) : 48814, 49732
.   : milestone, 49273,
tracing (43.709 ms) : 43344, 44074
.   : milestone, 43709,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.262 ms [36.96 ms, 37.564 ms]	-
appsec	47.696 ms [47.282 ms, 48.11 ms]	10.435 ms (28.0%)
code_origins	44.058 ms [43.682 ms, 44.434 ms]	6.796 ms (18.2%)
iast	45.959 ms [45.57 ms, 46.348 ms]	8.697 ms (23.3%)
profiling	48.794 ms [48.301 ms, 49.287 ms]	11.532 ms (30.9%)
tracing	46.185 ms [45.788 ms, 46.582 ms]	8.924 ms (23.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.698 ms [37.386 ms, 38.011 ms]	-
appsec	48.816 ms [48.402 ms, 49.231 ms]	11.118 ms (29.5%)
code_origins	45.413 ms [45.016 ms, 45.81 ms]	7.715 ms (20.5%)
iast	44.096 ms [43.713 ms, 44.48 ms]	6.398 ms (17.0%)
profiling	49.273 ms [48.814 ms, 49.732 ms]	11.575 ms (30.7%)
tracing	43.709 ms [43.344 ms, 44.074 ms]	6.011 ms (15.9%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~b6bd66bec5, baseline=1.54.0-SNAPSHOT~f284153719
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.146 ms) : 4096, 4196
.   : milestone, 4146,
iast (9.256 ms) : 9097, 9415
.   : milestone, 9256,
iast_FULL (14.803 ms) : 14499, 15107
.   : milestone, 14803,
iast_GLOBAL (10.164 ms) : 9987, 10341
.   : milestone, 10164,
profiling (8.816 ms) : 8684, 8948
.   : milestone, 8816,
tracing (7.658 ms) : 7552, 7764
.   : milestone, 7658,
section candidate
no_agent (4.429 ms) : 4378, 4480
.   : milestone, 4429,
iast (9.1 ms) : 8943, 9257
.   : milestone, 9100,
iast_FULL (14.375 ms) : 14087, 14663
.   : milestone, 14375,
iast_GLOBAL (10.26 ms) : 10081, 10439
.   : milestone, 10260,
profiling (9.073 ms) : 8929, 9217
.   : milestone, 9073,
tracing (7.667 ms) : 7560, 7775
.   : milestone, 7667,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.146 ms [4.096 ms, 4.196 ms]	-
iast	9.256 ms [9.097 ms, 9.415 ms]	5.11 ms (123.2%)
iast_FULL	14.803 ms [14.499 ms, 15.107 ms]	10.657 ms (257.0%)
iast_GLOBAL	10.164 ms [9.987 ms, 10.341 ms]	6.017 ms (145.1%)
profiling	8.816 ms [8.684 ms, 8.948 ms]	4.67 ms (112.6%)
tracing	7.658 ms [7.552 ms, 7.764 ms]	3.511 ms (84.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.429 ms [4.378 ms, 4.48 ms]	-
iast	9.1 ms [8.943 ms, 9.257 ms]	4.671 ms (105.5%)
iast_FULL	14.375 ms [14.087 ms, 14.663 ms]	9.946 ms (224.5%)
iast_GLOBAL	10.26 ms [10.081 ms, 10.439 ms]	5.83 ms (131.6%)
profiling	9.073 ms [8.929 ms, 9.217 ms]	4.643 ms (104.8%)
tracing	7.667 ms [7.56 ms, 7.775 ms]	3.238 ms (73.1%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/discovery-atomic
git_commit_date	1757412728	1757433156
git_commit_sha	`f284153`	`b6bd66b`
release_version	1.54.0-SNAPSHOT~f284153719	1.54.0-SNAPSHOT~b6bd66bec5

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1757435299	1757435299
ci_job_id	1120834147	1120834147
ci_pipeline_id	75970309	75970309
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-0x7aaq4h 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-0x7aaq4h 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~b6bd66bec5, baseline=1.54.0-SNAPSHOT~f284153719
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.521 s) : 15521000, 15521000
.   : milestone, 15521000,
appsec (14.82 s) : 14820000, 14820000
.   : milestone, 14820000,
iast (18.487 s) : 18487000, 18487000
.   : milestone, 18487000,
iast_GLOBAL (18.152 s) : 18152000, 18152000
.   : milestone, 18152000,
profiling (15.384 s) : 15384000, 15384000
.   : milestone, 15384000,
tracing (15.03 s) : 15030000, 15030000
.   : milestone, 15030000,
section candidate
no_agent (15.297 s) : 15297000, 15297000
.   : milestone, 15297000,
appsec (14.826 s) : 14826000, 14826000
.   : milestone, 14826000,
iast (18.695 s) : 18695000, 18695000
.   : milestone, 18695000,
iast_GLOBAL (17.799 s) : 17799000, 17799000
.   : milestone, 17799000,
profiling (15.351 s) : 15351000, 15351000
.   : milestone, 15351000,
tracing (15.06 s) : 15060000, 15060000
.   : milestone, 15060000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.521 s [15.521 s, 15.521 s]	-
appsec	14.82 s [14.82 s, 14.82 s]	-701.0 ms (-4.5%)
iast	18.487 s [18.487 s, 18.487 s]	2.966 s (19.1%)
iast_GLOBAL	18.152 s [18.152 s, 18.152 s]	2.631 s (17.0%)
profiling	15.384 s [15.384 s, 15.384 s]	-137.0 ms (-0.9%)
tracing	15.03 s [15.03 s, 15.03 s]	-491.0 ms (-3.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.297 s [15.297 s, 15.297 s]	-
appsec	14.826 s [14.826 s, 14.826 s]	-471.0 ms (-3.1%)
iast	18.695 s [18.695 s, 18.695 s]	3.398 s (22.2%)
iast_GLOBAL	17.799 s [17.799 s, 17.799 s]	2.502 s (16.4%)
profiling	15.351 s [15.351 s, 15.351 s]	54.0 ms (0.4%)
tracing	15.06 s [15.06 s, 15.06 s]	-237.0 ms (-1.5%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~b6bd66bec5, baseline=1.54.0-SNAPSHOT~f284153719
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.473 ms) : 2420, 2526
.   : milestone, 2473,
iast (2.208 ms) : 2145, 2271
.   : milestone, 2208,
iast_GLOBAL (2.246 ms) : 2183, 2310
.   : milestone, 2246,
profiling (2.065 ms) : 2013, 2118
.   : milestone, 2065,
tracing (2.017 ms) : 1968, 2066
.   : milestone, 2017,
section candidate
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (3.671 ms) : 3454, 3888
.   : milestone, 3671,
iast (2.204 ms) : 2140, 2267
.   : milestone, 2204,
iast_GLOBAL (2.243 ms) : 2180, 2306
.   : milestone, 2243,
profiling (2.486 ms) : 2315, 2656
.   : milestone, 2486,
tracing (2.013 ms) : 1964, 2062
.   : milestone, 2013,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.46 ms, 1.483 ms]	-
appsec	2.473 ms [2.42 ms, 2.526 ms]	1.001 ms (68.1%)
iast	2.208 ms [2.145 ms, 2.271 ms]	736.788 µs (50.1%)
iast_GLOBAL	2.246 ms [2.183 ms, 2.31 ms]	774.874 µs (52.7%)
profiling	2.065 ms [2.013 ms, 2.118 ms]	593.876 µs (40.4%)
tracing	2.017 ms [1.968 ms, 2.066 ms]	545.022 µs (37.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.461 ms, 1.484 ms]	-
appsec	3.671 ms [3.454 ms, 3.888 ms]	2.198 ms (149.3%)
iast	2.204 ms [2.14 ms, 2.267 ms]	730.999 µs (49.6%)
iast_GLOBAL	2.243 ms [2.18 ms, 2.306 ms]	770.518 µs (52.3%)
profiling	2.486 ms [2.315 ms, 2.656 ms]	1.013 ms (68.8%)
tracing	2.013 ms [1.964 ms, 2.062 ms]	540.03 µs (36.7%)

PerfectSlayer

Thanks for the fix!

PerfectSlayer · 2025-09-10T07:42:04Z

communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java

-
-  private long lastTimeDiscovered;
+  private static class State {
+    String traceEndpoint;


Yeah, this stuff should basically be an immutable record...

amarziali requested a review from a team as a code owner September 9, 2025 15:38

amarziali requested a review from PerfectSlayer September 9, 2025 15:38

amarziali added type: bug Bug report and fix comp: core Tracer core labels Sep 9, 2025

amarziali enabled auto-merge (squash) September 9, 2025 15:39

amarziali commented Sep 9, 2025

View reviewed changes

amarziali force-pushed the andrea.marziali/discovery-atomic branch from c66d7a8 to 0dca1f7 Compare September 9, 2025 15:42

amarziali mentioned this pull request Sep 9, 2025

Revert "Avoid race conditions between contributing and writing to a stat aggregate" #9498

Merged

Ensure info discovery state change is atomic

b6bd66b

amarziali force-pushed the andrea.marziali/discovery-atomic branch from 0dca1f7 to b6bd66b Compare September 9, 2025 15:52

port longrunning tests

8663672

PerfectSlayer approved these changes Sep 10, 2025

View reviewed changes

amarziali merged commit c5b6e46 into master Sep 10, 2025
503 checks passed

amarziali deleted the andrea.marziali/discovery-atomic branch September 10, 2025 07:45

github-actions bot added this to the 1.54.0 milestone Sep 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Ensure info discovery state change is atomic #9497

Ensure info discovery state change is atomic #9497

Uh oh!

amarziali commented Sep 9, 2025

Uh oh!

github-actions bot commented Sep 9, 2025

Uh oh!

amarziali Sep 9, 2025

Uh oh!

PerfectSlayer Sep 10, 2025

Uh oh!

datadog-datadog-prod-us1 bot commented Sep 9, 2025 •

edited by datadog-official bot

Loading

Uh oh!

pr-commenter bot commented Sep 9, 2025

Uh oh!

PerfectSlayer left a comment

Uh oh!

PerfectSlayer Sep 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Ensure info discovery state change is atomic #9497

Ensure info discovery state change is atomic #9497

Uh oh!

Conversation

amarziali commented Sep 9, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

github-actions bot commented Sep 9, 2025

Uh oh!

amarziali Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

datadog-datadog-prod-us1 bot commented Sep 9, 2025 • edited by datadog-official bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Sep 9, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

datadog-datadog-prod-us1 bot commented Sep 9, 2025 •

edited by datadog-official bot

Loading