-
Notifications
You must be signed in to change notification settings - Fork 312
Convert muzzle plugin to kotlin #9439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
d61742d
to
830d487
Compare
🎯 Code Coverage 🔗 Commit SHA: 830d487 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~830d487345, baseline=1.53.0-SNAPSHOT~ab302c3db1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1045323
Total [baseline] (8.634 s) : 0, 8633792
Agent [candidate] (1.046 s) : 0, 1046272
Total [candidate] (8.586 s) : 0, 8585641
section iast
Agent [baseline] (1.184 s) : 0, 1184311
Total [baseline] (9.317 s) : 0, 9317057
Agent [candidate] (1.179 s) : 0, 1179316
Total [candidate] (9.354 s) : 0, 9353707
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~830d487345, baseline=1.53.0-SNAPSHOT~ab302c3db1
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (732.119 ms) : 0, 732119
BytebuddyAgent [candidate] (731.806 ms) : 0, 731806
GlobalTracer [baseline] (242.502 ms) : 0, 242502
GlobalTracer [candidate] (242.446 ms) : 0, 242446
AppSec [baseline] (30.096 ms) : 0, 30096
AppSec [candidate] (29.96 ms) : 0, 29960
Debugger [baseline] (6.092 ms) : 0, 6092
Debugger [candidate] (6.046 ms) : 0, 6046
Remote Config [baseline] (679.663 µs) : 0, 680
Remote Config [candidate] (664.221 µs) : 0, 664
Telemetry [baseline] (11.417 ms) : 0, 11417
Telemetry [candidate] (12.977 ms) : 0, 12977
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (856.179 ms) : 0, 856179
BytebuddyAgent [candidate] (851.35 ms) : 0, 851350
GlobalTracer [baseline] (235.197 ms) : 0, 235197
GlobalTracer [candidate] (233.151 ms) : 0, 233151
IAST [baseline] (28.387 ms) : 0, 28387
IAST [candidate] (31.1 ms) : 0, 31100
AppSec [baseline] (26.843 ms) : 0, 26843
AppSec [candidate] (26.716 ms) : 0, 26716
Debugger [baseline] (6.476 ms) : 0, 6476
Debugger [candidate] (5.72 ms) : 0, 5720
Remote Config [baseline] (600.8 µs) : 0, 601
Remote Config [candidate] (594.885 µs) : 0, 595
Telemetry [baseline] (8.137 ms) : 0, 8137
Telemetry [candidate] (8.281 ms) : 0, 8281
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~830d487345, baseline=1.53.0-SNAPSHOT~ab302c3db1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048390
Total [baseline] (10.659 s) : 0, 10659218
Agent [candidate] (1.049 s) : 0, 1049207
Total [candidate] (10.674 s) : 0, 10673755
section appsec
Agent [baseline] (1.231 s) : 0, 1231117
Total [baseline] (10.798 s) : 0, 10798072
Agent [candidate] (1.222 s) : 0, 1221859
Total [candidate] (10.753 s) : 0, 10752725
section iast
Agent [baseline] (1.182 s) : 0, 1181989
Total [baseline] (10.915 s) : 0, 10915034
Agent [candidate] (1.19 s) : 0, 1189647
Total [candidate] (10.971 s) : 0, 10970595
section profiling
Agent [baseline] (1.203 s) : 0, 1202735
Total [baseline] (10.827 s) : 0, 10826528
Agent [candidate] (1.194 s) : 0, 1194494
Total [candidate] (10.915 s) : 0, 10915346
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~830d487345, baseline=1.53.0-SNAPSHOT~ab302c3db1
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (733.195 ms) : 0, 733195
BytebuddyAgent [candidate] (734.174 ms) : 0, 734174
GlobalTracer [baseline] (242.977 ms) : 0, 242977
GlobalTracer [candidate] (243.368 ms) : 0, 243368
AppSec [baseline] (29.939 ms) : 0, 29939
AppSec [candidate] (30.233 ms) : 0, 30233
Debugger [baseline] (6.06 ms) : 0, 6060
Debugger [candidate] (6.072 ms) : 0, 6072
Remote Config [baseline] (665.192 µs) : 0, 665
Remote Config [candidate] (667.295 µs) : 0, 667
Telemetry [baseline] (13.068 ms) : 0, 13068
Telemetry [candidate] (12.218 ms) : 0, 12218
section appsec
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (760.783 ms) : 0, 760783
BytebuddyAgent [candidate] (754.919 ms) : 0, 754919
GlobalTracer [baseline] (236.662 ms) : 0, 236662
GlobalTracer [candidate] (234.775 ms) : 0, 234775
IAST [baseline] (23.943 ms) : 0, 23943
IAST [candidate] (23.697 ms) : 0, 23697
AppSec [baseline] (171.234 ms) : 0, 171234
AppSec [candidate] (169.558 ms) : 0, 169558
Debugger [baseline] (5.85 ms) : 0, 5850
Debugger [candidate] (7.325 ms) : 0, 7325
Remote Config [baseline] (661.049 µs) : 0, 661
Remote Config [candidate] (643.025 µs) : 0, 643
Telemetry [baseline] (9.252 ms) : 0, 9252
Telemetry [candidate] (8.387 ms) : 0, 8387
section iast
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (852.814 ms) : 0, 852814
BytebuddyAgent [candidate] (859.716 ms) : 0, 859716
GlobalTracer [baseline] (233.555 ms) : 0, 233555
GlobalTracer [candidate] (235.458 ms) : 0, 235458
IAST [baseline] (31.293 ms) : 0, 31293
IAST [candidate] (29.449 ms) : 0, 29449
AppSec [baseline] (27.026 ms) : 0, 27026
AppSec [candidate] (27.74 ms) : 0, 27740
Debugger [baseline] (5.811 ms) : 0, 5811
Debugger [candidate] (5.732 ms) : 0, 5732
Remote Config [baseline] (603.977 µs) : 0, 604
Remote Config [candidate] (594.573 µs) : 0, 595
Telemetry [baseline] (8.313 ms) : 0, 8313
Telemetry [candidate] (8.316 ms) : 0, 8316
section profiling
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.428 ms) : 0, 1428
BytebuddyAgent [baseline] (766.349 ms) : 0, 766349
BytebuddyAgent [candidate] (760.372 ms) : 0, 760372
GlobalTracer [baseline] (223.129 ms) : 0, 223129
GlobalTracer [candidate] (222.224 ms) : 0, 222224
AppSec [baseline] (30.218 ms) : 0, 30218
AppSec [candidate] (29.989 ms) : 0, 29989
Debugger [baseline] (6.324 ms) : 0, 6324
Debugger [candidate] (6.293 ms) : 0, 6293
Remote Config [baseline] (726.975 µs) : 0, 727
Remote Config [candidate] (718.3 µs) : 0, 718
Telemetry [baseline] (15.602 ms) : 0, 15602
Telemetry [candidate] (16.499 ms) : 0, 16499
ProfilingAgent [baseline] (108.253 ms) : 0, 108253
ProfilingAgent [candidate] (107.401 ms) : 0, 107401
Profiling [baseline] (108.929 ms) : 0, 108929
Profiling [candidate] (108.072 ms) : 0, 108072
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~830d487345, baseline=1.53.0-SNAPSHOT~ab302c3db1
dateFormat X
axisFormat %s
section baseline
no_agent (36.228 ms) : 35935, 36521
. : milestone, 36228,
appsec (48.384 ms) : 47946, 48821
. : milestone, 48384,
code_origins (44.957 ms) : 44602, 45313
. : milestone, 44957,
iast (45.134 ms) : 44750, 45519
. : milestone, 45134,
profiling (47.178 ms) : 46674, 47683
. : milestone, 47178,
tracing (43.093 ms) : 42717, 43470
. : milestone, 43093,
section candidate
no_agent (37.592 ms) : 37294, 37889
. : milestone, 37592,
appsec (46.681 ms) : 46267, 47096
. : milestone, 46681,
code_origins (44.378 ms) : 43988, 44768
. : milestone, 44378,
iast (45.563 ms) : 45166, 45960
. : milestone, 45563,
profiling (47.23 ms) : 46782, 47678
. : milestone, 47230,
tracing (42.672 ms) : 42313, 43030
. : milestone, 42672,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~830d487345, baseline=1.53.0-SNAPSHOT~ab302c3db1
dateFormat X
axisFormat %s
section baseline
no_agent (4.524 ms) : 4469, 4578
. : milestone, 4524,
iast (9.484 ms) : 9318, 9650
. : milestone, 9484,
iast_FULL (14.103 ms) : 13820, 14386
. : milestone, 14103,
iast_GLOBAL (9.97 ms) : 9785, 10154
. : milestone, 9970,
profiling (8.69 ms) : 8546, 8834
. : milestone, 8690,
tracing (7.49 ms) : 7385, 7595
. : milestone, 7490,
section candidate
no_agent (4.355 ms) : 4299, 4411
. : milestone, 4355,
iast (9.321 ms) : 9168, 9475
. : milestone, 9321,
iast_FULL (14.315 ms) : 14027, 14604
. : milestone, 14315,
iast_GLOBAL (10.346 ms) : 10146, 10546
. : milestone, 10346,
profiling (8.584 ms) : 8444, 8725
. : milestone, 8584,
tracing (7.449 ms) : 7337, 7561
. : milestone, 7449,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~830d487345, baseline=1.53.0-SNAPSHOT~ab302c3db1
dateFormat X
axisFormat %s
section baseline
no_agent (14.903 s) : 14903000, 14903000
. : milestone, 14903000,
appsec (14.702 s) : 14702000, 14702000
. : milestone, 14702000,
iast (18.254 s) : 18254000, 18254000
. : milestone, 18254000,
iast_GLOBAL (17.771 s) : 17771000, 17771000
. : milestone, 17771000,
profiling (15.485 s) : 15485000, 15485000
. : milestone, 15485000,
tracing (14.857 s) : 14857000, 14857000
. : milestone, 14857000,
section candidate
no_agent (14.751 s) : 14751000, 14751000
. : milestone, 14751000,
appsec (14.969 s) : 14969000, 14969000
. : milestone, 14969000,
iast (18.715 s) : 18715000, 18715000
. : milestone, 18715000,
iast_GLOBAL (18.009 s) : 18009000, 18009000
. : milestone, 18009000,
profiling (15.269 s) : 15269000, 15269000
. : milestone, 15269000,
tracing (14.906 s) : 14906000, 14906000
. : milestone, 14906000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~830d487345, baseline=1.53.0-SNAPSHOT~ab302c3db1
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.679 ms) : 3459, 3898
. : milestone, 3679,
iast (2.212 ms) : 2149, 2275
. : milestone, 2212,
iast_GLOBAL (2.252 ms) : 2189, 2316
. : milestone, 2252,
profiling (2.073 ms) : 2021, 2126
. : milestone, 2073,
tracing (2.023 ms) : 1973, 2072
. : milestone, 2023,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.671 ms) : 3453, 3889
. : milestone, 3671,
iast (2.212 ms) : 2149, 2276
. : milestone, 2212,
iast_GLOBAL (2.248 ms) : 2184, 2312
. : milestone, 2248,
profiling (2.068 ms) : 2016, 2121
. : milestone, 2068,
tracing (2.031 ms) : 1981, 2080
. : milestone, 2031,
|
What Does This Do
Port the MuzzlePlugin written in groovy to Kotlin. Also spread the single source file to its constituents.
Motivation
Significantly better IDE support, this will improve maintainability.
In a previous PR this plugin was refactored to use lazy configuration API, this PR don't change that. However, it improves in a few places.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]