-
Notifications
You must be signed in to change notification settings - Fork 312
add support debugger/v2/input endpoint #9406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (313.964 µs) : 292, 336
. : milestone, 314,
basic (277.906 µs) : 271, 285
. : milestone, 278,
loop (8.967 ms) : 8962, 8972
. : milestone, 8967,
section candidate
noprobe (314.795 µs) : 284, 345
. : milestone, 315,
basic (277.089 µs) : 270, 284
. : milestone, 277,
loop (8.965 ms) : 8961, 8970
. : milestone, 8965,
|
🎯 Code Coverage 🔗 Commit SHA: 3189f3c | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 13 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~3189f3cfc2, baseline=1.53.0-SNAPSHOT~d43410737f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054430
Total [baseline] (10.665 s) : 0, 10664831
Agent [candidate] (1.049 s) : 0, 1048805
Total [candidate] (10.707 s) : 0, 10707147
section appsec
Agent [baseline] (1.219 s) : 0, 1218689
Total [baseline] (10.76 s) : 0, 10759615
Agent [candidate] (1.22 s) : 0, 1219959
Total [candidate] (10.765 s) : 0, 10765249
section iast
Agent [baseline] (1.181 s) : 0, 1181320
Total [baseline] (10.898 s) : 0, 10897993
Agent [candidate] (1.179 s) : 0, 1179036
Total [candidate] (10.893 s) : 0, 10893232
section profiling
Agent [baseline] (1.201 s) : 0, 1201300
Total [baseline] (10.827 s) : 0, 10827067
Agent [candidate] (1.197 s) : 0, 1197215
Total [candidate] (10.862 s) : 0, 10861813
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~3189f3cfc2, baseline=1.53.0-SNAPSHOT~d43410737f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.486 ms) : 0, 1486
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (738.292 ms) : 0, 738292
BytebuddyAgent [candidate] (732.335 ms) : 0, 732335
GlobalTracer [baseline] (244.054 ms) : 0, 244054
GlobalTracer [candidate] (242.768 ms) : 0, 242768
AppSec [baseline] (30.23 ms) : 0, 30230
AppSec [candidate] (30.072 ms) : 0, 30072
Debugger [baseline] (6.084 ms) : 0, 6084
Debugger [candidate] (6.099 ms) : 0, 6099
Remote Config [baseline] (685.695 µs) : 0, 686
Remote Config [candidate] (669.63 µs) : 0, 670
Telemetry [baseline] (12.388 ms) : 0, 12388
Telemetry [candidate] (14.345 ms) : 0, 14345
section appsec
crashtracking [baseline] (1.443 ms) : 0, 1443
crashtracking [candidate] (1.438 ms) : 0, 1438
BytebuddyAgent [baseline] (752.27 ms) : 0, 752270
BytebuddyAgent [candidate] (753.401 ms) : 0, 753401
GlobalTracer [baseline] (234.604 ms) : 0, 234604
GlobalTracer [candidate] (234.742 ms) : 0, 234742
IAST [baseline] (23.586 ms) : 0, 23586
IAST [candidate] (23.678 ms) : 0, 23678
AppSec [baseline] (169.357 ms) : 0, 169357
AppSec [candidate] (169.326 ms) : 0, 169326
Debugger [baseline] (6.635 ms) : 0, 6635
Debugger [candidate] (6.512 ms) : 0, 6512
Remote Config [baseline] (650.845 µs) : 0, 651
Remote Config [candidate] (633.969 µs) : 0, 634
Telemetry [baseline] (9.098 ms) : 0, 9098
Telemetry [candidate] (9.177 ms) : 0, 9177
section iast
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (852.209 ms) : 0, 852209
BytebuddyAgent [candidate] (850.776 ms) : 0, 850776
GlobalTracer [baseline] (233.574 ms) : 0, 233574
GlobalTracer [candidate] (233.296 ms) : 0, 233296
IAST [baseline] (31.3 ms) : 0, 31300
IAST [candidate] (32.846 ms) : 0, 32846
AppSec [baseline] (26.861 ms) : 0, 26861
AppSec [candidate] (25.035 ms) : 0, 25035
Debugger [baseline] (5.783 ms) : 0, 5783
Debugger [candidate] (5.802 ms) : 0, 5802
Remote Config [baseline] (622.885 µs) : 0, 623
Remote Config [candidate] (591.274 µs) : 0, 591
Telemetry [baseline] (8.461 ms) : 0, 8461
Telemetry [candidate] (8.3 ms) : 0, 8300
section profiling
crashtracking [baseline] (1.44 ms) : 0, 1440
crashtracking [candidate] (1.427 ms) : 0, 1427
BytebuddyAgent [baseline] (764.547 ms) : 0, 764547
BytebuddyAgent [candidate] (761.992 ms) : 0, 761992
GlobalTracer [baseline] (223.346 ms) : 0, 223346
GlobalTracer [candidate] (222.469 ms) : 0, 222469
AppSec [baseline] (30.112 ms) : 0, 30112
AppSec [candidate] (29.87 ms) : 0, 29870
Debugger [baseline] (7.067 ms) : 0, 7067
Debugger [candidate] (6.325 ms) : 0, 6325
Remote Config [baseline] (1.504 ms) : 0, 1504
Remote Config [candidate] (703.466 µs) : 0, 703
Telemetry [baseline] (14.862 ms) : 0, 14862
Telemetry [candidate] (16.335 ms) : 0, 16335
ProfilingAgent [baseline] (107.937 ms) : 0, 107937
ProfilingAgent [candidate] (107.713 ms) : 0, 107713
Profiling [baseline] (108.612 ms) : 0, 108612
Profiling [candidate] (108.362 ms) : 0, 108362
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~3189f3cfc2, baseline=1.53.0-SNAPSHOT~d43410737f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050806
Total [baseline] (8.622 s) : 0, 8622198
Agent [candidate] (1.054 s) : 0, 1054055
Total [candidate] (8.599 s) : 0, 8599193
section iast
Agent [baseline] (1.179 s) : 0, 1179434
Total [baseline] (9.392 s) : 0, 9392464
Agent [candidate] (1.178 s) : 0, 1178133
Total [candidate] (9.365 s) : 0, 9364517
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~3189f3cfc2, baseline=1.53.0-SNAPSHOT~d43410737f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (737.019 ms) : 0, 737019
BytebuddyAgent [candidate] (737.176 ms) : 0, 737176
GlobalTracer [baseline] (243.704 ms) : 0, 243704
GlobalTracer [candidate] (243.189 ms) : 0, 243189
AppSec [baseline] (30.149 ms) : 0, 30149
AppSec [candidate] (29.953 ms) : 0, 29953
Debugger [baseline] (6.033 ms) : 0, 6033
Debugger [candidate] (6.045 ms) : 0, 6045
Remote Config [baseline] (666.652 µs) : 0, 667
Remote Config [candidate] (665.479 µs) : 0, 665
Telemetry [baseline] (10.771 ms) : 0, 10771
Telemetry [candidate] (14.42 ms) : 0, 14420
section iast
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (850.279 ms) : 0, 850279
BytebuddyAgent [candidate] (849.917 ms) : 0, 849917
GlobalTracer [baseline] (234.57 ms) : 0, 234570
GlobalTracer [candidate] (233.812 ms) : 0, 233812
AppSec [baseline] (26.316 ms) : 0, 26316
AppSec [candidate] (27.759 ms) : 0, 27759
Debugger [baseline] (5.719 ms) : 0, 5719
Debugger [candidate] (6.624 ms) : 0, 6624
Remote Config [baseline] (616.176 µs) : 0, 616
Remote Config [candidate] (595.307 µs) : 0, 595
Telemetry [baseline] (8.29 ms) : 0, 8290
Telemetry [candidate] (8.315 ms) : 0, 8315
IAST [baseline] (31.244 ms) : 0, 31244
IAST [candidate] (28.675 ms) : 0, 28675
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~3189f3cfc2, baseline=1.53.0-SNAPSHOT~d43410737f
dateFormat X
axisFormat %s
section baseline
no_agent (4.356 ms) : 4301, 4411
. : milestone, 4356,
iast (9.352 ms) : 9199, 9504
. : milestone, 9352,
iast_FULL (13.989 ms) : 13708, 14271
. : milestone, 13989,
iast_GLOBAL (10.557 ms) : 10367, 10746
. : milestone, 10557,
profiling (8.866 ms) : 8728, 9005
. : milestone, 8866,
tracing (7.512 ms) : 7400, 7624
. : milestone, 7512,
section candidate
no_agent (4.446 ms) : 4395, 4497
. : milestone, 4446,
iast (9.174 ms) : 9020, 9327
. : milestone, 9174,
iast_FULL (13.792 ms) : 13516, 14067
. : milestone, 13792,
iast_GLOBAL (10.339 ms) : 10157, 10522
. : milestone, 10339,
profiling (9.206 ms) : 9053, 9360
. : milestone, 9206,
tracing (7.614 ms) : 7505, 7723
. : milestone, 7614,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~3189f3cfc2, baseline=1.53.0-SNAPSHOT~d43410737f
dateFormat X
axisFormat %s
section baseline
no_agent (36.928 ms) : 36634, 37222
. : milestone, 36928,
appsec (48.721 ms) : 48285, 49157
. : milestone, 48721,
code_origins (44.123 ms) : 43741, 44506
. : milestone, 44123,
iast (48.11 ms) : 47694, 48526
. : milestone, 48110,
profiling (48.943 ms) : 48472, 49415
. : milestone, 48943,
tracing (44.303 ms) : 43915, 44690
. : milestone, 44303,
section candidate
no_agent (36.595 ms) : 36300, 36890
. : milestone, 36595,
appsec (47.459 ms) : 47042, 47876
. : milestone, 47459,
code_origins (45.228 ms) : 44828, 45627
. : milestone, 45228,
iast (45.377 ms) : 44991, 45764
. : milestone, 45377,
profiling (49.265 ms) : 48781, 49749
. : milestone, 49265,
tracing (44.397 ms) : 44007, 44788
. : milestone, 44397,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~3189f3cfc2, baseline=1.53.0-SNAPSHOT~d43410737f
dateFormat X
axisFormat %s
section baseline
no_agent (14.796 s) : 14796000, 14796000
. : milestone, 14796000,
appsec (15.03 s) : 15030000, 15030000
. : milestone, 15030000,
iast (18.36 s) : 18360000, 18360000
. : milestone, 18360000,
iast_GLOBAL (17.836 s) : 17836000, 17836000
. : milestone, 17836000,
profiling (15.905 s) : 15905000, 15905000
. : milestone, 15905000,
tracing (15.179 s) : 15179000, 15179000
. : milestone, 15179000,
section candidate
no_agent (15.51 s) : 15510000, 15510000
. : milestone, 15510000,
appsec (14.862 s) : 14862000, 14862000
. : milestone, 14862000,
iast (18.493 s) : 18493000, 18493000
. : milestone, 18493000,
iast_GLOBAL (18.229 s) : 18229000, 18229000
. : milestone, 18229000,
profiling (15.763 s) : 15763000, 15763000
. : milestone, 15763000,
tracing (15.11 s) : 15110000, 15110000
. : milestone, 15110000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~3189f3cfc2, baseline=1.53.0-SNAPSHOT~d43410737f
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.634 ms) : 3420, 3849
. : milestone, 3634,
iast (2.203 ms) : 2140, 2266
. : milestone, 2203,
iast_GLOBAL (2.236 ms) : 2173, 2299
. : milestone, 2236,
profiling (2.034 ms) : 1984, 2085
. : milestone, 2034,
tracing (2.029 ms) : 1979, 2079
. : milestone, 2029,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.659 ms) : 3441, 3878
. : milestone, 3659,
iast (2.204 ms) : 2141, 2267
. : milestone, 2204,
iast_GLOBAL (2.246 ms) : 2182, 2309
. : milestone, 2246,
profiling (2.04 ms) : 1989, 2090
. : milestone, 2040,
tracing (2.028 ms) : 1979, 2078
. : milestone, 2028,
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will add smoke tests in a next PR
What Does This Do
Add support for new endpoint debugger/v2/input at datadog agent.
the tracer would try to use the endpoints in this order:
Motivation
we are in a process of directing all snapshots captured into DEBUGGER track (currently they sent to LOGS).
So, in order to allow new tracers to direct messages to DEBUGGER track without require agent upgrade, we fallback to diagnostics endpoint (that already send probe status to the DEBUGGER track).
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: DEBUG-4340