-
Notifications
You must be signed in to change notification settings - Fork 315
Update CODEOWNERS #9294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update CODEOWNERS #9294
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
61a82e6
Update CODEOWNERS
mhlidd 29e5ef4
Update CODEOWNERS
mhlidd 5812319
Update CODEOWNERS
mhlidd 1116257
update for test files
mhlidd f529f2a
Add sampling smoke tests
mhlidd a7bb475
linting
mhlidd 8007b9d
Merge branch 'master' into mhlidd_update_codeowners
mhlidd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these in! Just wanted to check in if we need to add anything for any of the below
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Telemetry is weird because
/telemetryshould belong under LP since it is the fundamental mechanism for sending telemetry. We could arguably owninternal-api/src/main/java/datadog/trace/api/telemetrybut this also contains several interfaces for telemetry mechanisms. In general, each package is a mix of fundamental interfaces that should be owned by LP and applications that could be owned by Capabilities. Telemetry is currently under LP so I feel content leaving it there...dd-trace-apiis also a combination of multiple products (civisibility, appsec, llmobs, profiling, etc) shoved under one big package. Even if we go into a subpackage, such asdd-trace-api/src/main/java/datadog/trace/api/config, the package contains information related to different products, which I'm not sure we should own.I believe most of these belong in
/dd-java-agent/agent-otel, which I've assigned to us.I can add the tests directories for the relevant packages that are too specific to contain tests.