Skip to content

Stop doing sync over async #7433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Stop doing sync over async #7433

wants to merge 1 commit into from

Conversation

andrewlock
Copy link
Member

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@dd-trace-dotnet-ci-bot
Copy link

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7433) - mean (72ms)  : 71, 74
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7433) - mean (68ms)  : 66, 71
     .   : milestone, 68,
    master - mean (68ms)  : 66, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7433) - mean (1,001ms)  : 980, 1023
     .   : milestone, 1001,
    master - mean (1,001ms)  : 972, 1030
     .   : milestone, 1001,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7433) - mean (107ms)  : 106, 108
     .   : milestone, 107,
    master - mean (106ms)  : 105, 107
     .   : milestone, 106,

    section Baseline
    This PR (7433) - mean (106ms)  : 105, 108
     .   : milestone, 106,
    master - mean (106ms)  : 103, 108
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (7433) - mean (710ms)  : 688, 732
     .   : milestone, 710,
    master - mean (709ms)  : 694, 725
     .   : milestone, 709,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7433) - mean (95ms)  : 94, 96
     .   : milestone, 95,
    master - mean (94ms)  : 93, 95
     .   : milestone, 94,

    section Baseline
    This PR (7433) - mean (94ms)  : 92, 97
     .   : milestone, 94,
    master - mean (93ms)  : 91, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (7433) - mean (669ms)  : 655, 683
     .   : milestone, 669,
    master - mean (668ms)  : 653, 684
     .   : milestone, 668,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7433) - mean (94ms)  : 92, 95
     .   : milestone, 94,
    master - mean (93ms)  : 92, 94
     .   : milestone, 93,

    section Baseline
    This PR (7433) - mean (93ms)  : 90, 95
     .   : milestone, 93,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7433) - mean (600ms)  : 591, 609
     .   : milestone, 600,
    master - mean (603ms)  : 593, 613
     .   : milestone, 603,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7433) - mean (201ms)  : 196, 207
     .   : milestone, 201,
    master - mean (200ms)  : 195, 204
     .   : milestone, 200,

    section Baseline
    This PR (7433) - mean (198ms)  : 192, 204
     .   : milestone, 198,
    master - mean (195ms)  : 190, 200
     .   : milestone, 195,

    section CallTarget+Inlining+NGEN
    This PR (7433) - mean (1,144ms)  : 1110, 1179
     .   : milestone, 1144,
    master - mean (1,130ms)  : 1092, 1168
     .   : milestone, 1130,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7433) - mean (287ms)  : 281, 294
     .   : milestone, 287,
    master - mean (284ms)  : 279, 289
     .   : milestone, 284,

    section Baseline
    This PR (7433) - mean (288ms)  : 279, 297
     .   : milestone, 288,
    master - mean (285ms)  : 274, 295
     .   : milestone, 285,

    section CallTarget+Inlining+NGEN
    This PR (7433) - mean (924ms)  : 898, 949
     .   : milestone, 924,
    master - mean (918ms)  : 890, 946
     .   : milestone, 918,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7433) - mean (281ms)  : 274, 288
     .   : milestone, 281,
    master - mean (278ms)  : 273, 283
     .   : milestone, 278,

    section Baseline
    This PR (7433) - mean (278ms)  : 271, 285
     .   : milestone, 278,
    master - mean (276ms)  : 269, 283
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (7433) - mean (912ms)  : 884, 939
     .   : milestone, 912,
    master - mean (913ms)  : 883, 942
     .   : milestone, 913,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7433) - mean (278ms)  : 269, 287
     .   : milestone, 278,
    master - mean (277ms)  : 271, 283
     .   : milestone, 277,

    section Baseline
    This PR (7433) - mean (277ms)  : 270, 283
     .   : milestone, 277,
    master - mean (276ms)  : 270, 283
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (7433) - mean (825ms)  : 799, 852
     .   : milestone, 825,
    master - mean (818ms)  : 790, 845
     .   : milestone, 818,
Loading

@pr-commenter
Copy link

pr-commenter bot commented Aug 22, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7433 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.174
  • 1 benchmarks are slower, with geometric mean 1.145
  • 8 benchmarks have fewer allocations
  • 2 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7433

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.71 KB 5.67 KB -43 B -0.75%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.2μs 53.4ns 214ns 0 0 0 5.51 KB
master StartStopWithChild netcoreapp3.1 13.2μs 62.1ns 278ns 0 0 0 5.71 KB
master StartStopWithChild net472 21.4μs 113ns 600ns 0.867 0.217 0 6.08 KB
#7433 StartStopWithChild net6.0 10.1μs 55.4ns 314ns 0 0 0 5.51 KB
#7433 StartStopWithChild netcoreapp3.1 13.8μs 70.5ns 330ns 0 0 0 5.67 KB
#7433 StartStopWithChild net472 21.8μs 122ns 813ns 0.874 0.219 0 6.08 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 938μs 46.9ns 162ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 259ns 1μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.19ms 792ns 2.97μs 0 0 0 3.31 KB
#7433 WriteAndFlushEnrichedTraces net6.0 937μs 161ns 604ns 0 0 0 2.7 KB
#7433 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 715ns 2.77μs 0 0 0 2.7 KB
#7433 WriteAndFlushEnrichedTraces net472 1.19ms 61ns 228ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #7433

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑net472 1.174 351.74 299.61

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 318μs 1.52μs 6.07μs 0 0 0 172.07 KB
master AllCycleSimpleBody netcoreapp3.1 461μs 199ns 770ns 0 0 0 174.19 KB
master AllCycleSimpleBody net472 428μs 112ns 434ns 29.2 0 0 194.24 KB
master AllCycleMoreComplexBody net6.0 328μs 556ns 2.08μs 0 0 0 175.58 KB
master AllCycleMoreComplexBody netcoreapp3.1 465μs 1.53μs 5.94μs 0 0 0 177.6 KB
master AllCycleMoreComplexBody net472 435μs 200ns 773ns 30.2 0 0 197.76 KB
master ObjectExtractorSimpleBody net6.0 319ns 1.72ns 8.76ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 401ns 2.09ns 10.4ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 352ns 0.0707ns 0.255ns 0.0429 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.42μs 2.02ns 7.84ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.6μs 35.1ns 131ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 7.26μs 2.76ns 10.7ns 0.581 0 0 3.8 KB
#7433 AllCycleSimpleBody net6.0 319μs 1.58μs 6.87μs 0 0 0 172.07 KB
#7433 AllCycleSimpleBody netcoreapp3.1 459μs 1.24μs 4.8μs 0 0 0 174.18 KB
#7433 AllCycleSimpleBody net472 425μs 177ns 661ns 29.2 0 0 194.24 KB
#7433 AllCycleMoreComplexBody net6.0 324μs 1.67μs 7.84μs 0 0 0 175.58 KB
#7433 AllCycleMoreComplexBody netcoreapp3.1 505μs 397ns 1.54μs 0 0 0 177.6 KB
#7433 AllCycleMoreComplexBody net472 435μs 95.2ns 356ns 30.2 0 0 197.76 KB
#7433 ObjectExtractorSimpleBody net6.0 337ns 0.25ns 0.967ns 0 0 0 280 B
#7433 ObjectExtractorSimpleBody netcoreapp3.1 408ns 1.79ns 8.02ns 0 0 0 272 B
#7433 ObjectExtractorSimpleBody net472 300ns 0.0944ns 0.366ns 0.0437 0 0 281 B
#7433 ObjectExtractorMoreComplexBody net6.0 6.26μs 28.3ns 110ns 0 0 0 3.78 KB
#7433 ObjectExtractorMoreComplexBody netcoreapp3.1 7.67μs 25.6ns 99.2ns 0 0 0 3.69 KB
#7433 ObjectExtractorMoreComplexBody net472 6.68μs 2.26ns 8.77ns 0.6 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 76.3μs 338ns 1.22μs 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 98.4μs 100ns 389ns 0 0 0 32.4 KB
master EncodeArgs net472 109μs 37.8ns 146ns 4.92 0 0 32.51 KB
master EncodeLegacyArgs net6.0 145μs 33.6ns 126ns 0 0 0 2.15 KB
master EncodeLegacyArgs netcoreapp3.1 199μs 161ns 625ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 263μs 106ns 409ns 0 0 0 2.16 KB
#7433 EncodeArgs net6.0 76.5μs 164ns 636ns 0 0 0 32.4 KB
#7433 EncodeArgs netcoreapp3.1 97.3μs 312ns 1.21μs 0 0 0 32.4 KB
#7433 EncodeArgs net472 109μs 5.87ns 22ns 4.92 0 0 32.51 KB
#7433 EncodeLegacyArgs net6.0 143μs 16.2ns 58.6ns 0 0 0 2.15 KB
#7433 EncodeLegacyArgs netcoreapp3.1 196μs 242ns 939ns 0 0 0 2.14 KB
#7433 EncodeLegacyArgs net472 263μs 34.1ns 127ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 392μs 67.9ns 254ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 414μs 53.4ns 200ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 432μs 83.1ns 322ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 288μs 145ns 560ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 301μs 52.4ns 182ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 315μs 19.8ns 76.9ns 0 0 0 2.29 KB
#7433 RunWafRealisticBenchmark net6.0 402μs 79ns 306ns 0 0 0 4.55 KB
#7433 RunWafRealisticBenchmark netcoreapp3.1 427μs 142ns 530ns 0 0 0 4.48 KB
#7433 RunWafRealisticBenchmark net472 436μs 75.9ns 294ns 0 0 0 4.66 KB
#7433 RunWafRealisticBenchmarkWithAttack net6.0 295μs 81.5ns 316ns 0 0 0 2.24 KB
#7433 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 304μs 101ns 349ns 0 0 0 2.22 KB
#7433 RunWafRealisticBenchmarkWithAttack net472 312μs 36.9ns 143ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.9μs 143ns 554ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 71.6μs 72.3ns 270ns 0 0 0 17.42 KB
master SendRequest net472 0.000405ns 0.000405ns 0.00157ns 0 0 0 0 b
#7433 SendRequest net6.0 61.5μs 58.7ns 220ns 0 0 0 14.52 KB
#7433 SendRequest netcoreapp3.1 71.6μs 156ns 563ns 0 0 0 17.42 KB
#7433 SendRequest net472 0.0111ns 0.00153ns 0.00592ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7433

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 4 B 2 B -2 B -50.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 4 B 2 B -2 B -50.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1 1 B 0 b -1 B -100.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.93ms 1.14μs 4.1μs 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.09ms 4.96μs 19.2μs 0 0 0 640 KB
master OriginalCharSlice net472 2.71ms 189ns 682ns 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.49ms 131ns 509ns 0 0 0 4 B
master OptimizedCharSlice netcoreapp3.1 1.7ms 335ns 1.3μs 0 0 0 1 B
master OptimizedCharSlice net472 2.05ms 147ns 571ns 0 0 0 0 b
master OptimizedCharSliceWithPool net6.0 1.01ms 42.5ns 159ns 0 0 0 4 B
master OptimizedCharSliceWithPool netcoreapp3.1 861μs 91ns 353ns 0 0 0 1 B
master OptimizedCharSliceWithPool net472 1.19ms 39.2ns 152ns 0 0 0 0 b
#7433 OriginalCharSlice net6.0 1.95ms 709ns 2.74μs 0 0 0 640.01 KB
#7433 OriginalCharSlice netcoreapp3.1 2.14ms 7.1μs 26.6μs 0 0 0 640 KB
#7433 OriginalCharSlice net472 2.75ms 444ns 1.72μs 100 0 0 641.95 KB
#7433 OptimizedCharSlice net6.0 1.42ms 265ns 1.03μs 0 0 0 2 B
#7433 OptimizedCharSlice netcoreapp3.1 1.71ms 150ns 582ns 0 0 0 1 B
#7433 OptimizedCharSlice net472 1.96ms 225ns 873ns 0 0 0 0 b
#7433 OptimizedCharSliceWithPool net6.0 980μs 38.7ns 150ns 0 0 0 2 B
#7433 OptimizedCharSliceWithPool netcoreapp3.1 799μs 94.4ns 366ns 0 0 0 0 b
#7433 OptimizedCharSliceWithPool net472 1.16ms 44.9ns 174ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7433

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 1.145 642,067.76 734,962.89

More allocations ⚠️ in #7433

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.66 KB 42.47 KB 809 B 1.94%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 55.5 KB 55.88 KB 375 B 0.68%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 642μs 593ns 2.3μs 0 0 0 41.66 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 678μs 3.63μs 23.3μs 0 0 0 41.9 KB
master WriteAndFlushEnrichedTraces net472 876μs 3.11μs 11.2μs 8.33 0 0 55.5 KB
#7433 WriteAndFlushEnrichedTraces net6.0 734μs 1.03μs 4μs 0 0 0 42.47 KB
#7433 WriteAndFlushEnrichedTraces netcoreapp3.1 680μs 1.95μs 7.55μs 0 0 0 41.79 KB
#7433 WriteAndFlushEnrichedTraces net472 884μs 3.57μs 13.8μs 8.33 0 0 55.88 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.92μs 9.71ns 44.5ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.53μs 5.56ns 21.5ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.81μs 5.37ns 20.8ns 0.154 0.014 0 987 B
#7433 ExecuteNonQuery net6.0 1.91μs 2.68ns 10.4ns 0 0 0 1.02 KB
#7433 ExecuteNonQuery netcoreapp3.1 2.54μs 2.15ns 8.06ns 0 0 0 1.02 KB
#7433 ExecuteNonQuery net472 2.69μs 2.75ns 9.9ns 0.15 0.0136 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.81μs 9.42ns 45.2ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.28μs 11.9ns 60.5ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.85μs 2.16ns 8.37ns 0.154 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.92μs 1.64ns 6.36ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.4μs 5.48ns 20.5ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 4.09μs 1.99ns 7.7ns 0.163 0 0 1.1 KB
#7433 CallElasticsearch net6.0 1.72μs 7.52ns 29.1ns 0 0 0 1.03 KB
#7433 CallElasticsearch netcoreapp3.1 2.34μs 11.4ns 47ns 0 0 0 1.03 KB
#7433 CallElasticsearch net472 3.46μs 2.98ns 11.5ns 0.155 0 0 1.04 KB
#7433 CallElasticsearchAsync net6.0 1.82μs 9.17ns 41ns 0 0 0 1.01 KB
#7433 CallElasticsearchAsync netcoreapp3.1 2.38μs 10.9ns 42.3ns 0 0 0 1.08 KB
#7433 CallElasticsearchAsync net472 3.76μs 2.91ns 11.3ns 0.169 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.88μs 1.92ns 6.91ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.3μs 10.2ns 39.5ns 0 0 0 952 B
master ExecuteAsync net472 2.51μs 4.87ns 18.9ns 0.139 0 0 915 B
#7433 ExecuteAsync net6.0 1.81μs 2.54ns 9.84ns 0 0 0 952 B
#7433 ExecuteAsync netcoreapp3.1 2.23μs 1.77ns 6.62ns 0 0 0 952 B
#7433 ExecuteAsync net472 2.44μs 2.8ns 10.8ns 0.134 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.26μs 8.27ns 32ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.29μs 21.9ns 84.7ns 0 0 0 2.9 KB
master SendAsync net472 12.4μs 11.5ns 44.4ns 0.497 0 0 3.18 KB
#7433 SendAsync net6.0 7.41μs 19.6ns 73.4ns 0 0 0 2.36 KB
#7433 SendAsync netcoreapp3.1 8.46μs 25.6ns 95.7ns 0 0 0 2.9 KB
#7433 SendAsync net472 12.2μs 6.31ns 23.6ns 0.485 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7433

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 286.72 KB 278.53 KB -8.19 KB -2.86%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 46.42 KB 43.87 KB -2.55 KB -5.50%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 274.98 KB 259.15 KB -15.82 KB -5.75%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 277.62 KB 257.46 KB -20.16 KB -7.26%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 43.8μs 243ns 1.44μs 0 0 0 46.42 KB
master StringConcatBenchmark netcoreapp3.1 49.4μs 258ns 1.18μs 0 0 0 42.64 KB
master StringConcatBenchmark net472 58.2μs 274ns 1.1μs 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 483μs 2.36μs 10.3μs 0 0 0 274.98 KB
master StringConcatAspectBenchmark netcoreapp3.1 513μs 2.06μs 8.49μs 0 0 0 277.62 KB
master StringConcatAspectBenchmark net472 399μs 1.83μs 7.54μs 0 0 0 286.72 KB
#7433 StringConcatBenchmark net6.0 48.5μs 261ns 1.83μs 0 0 0 43.87 KB
#7433 StringConcatBenchmark netcoreapp3.1 48.4μs 219ns 876ns 0 0 0 42.64 KB
#7433 StringConcatBenchmark net472 57.4μs 277ns 1.07μs 0 0 0 57.34 KB
#7433 StringConcatAspectBenchmark net6.0 466μs 2.23μs 8.65μs 0 0 0 259.15 KB
#7433 StringConcatAspectBenchmark netcoreapp3.1 503μs 2.54μs 11.6μs 0 0 0 257.46 KB
#7433 StringConcatAspectBenchmark net472 402μs 2.29μs 16.7μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.54μs 13.3ns 66.5ns 0 0 0 1.71 KB
master EnrichedLog netcoreapp3.1 3.41μs 14.4ns 54ns 0 0 0 1.7 KB
master EnrichedLog net472 3.94μs 2.41ns 9.33ns 0.255 0 0 1.64 KB
#7433 EnrichedLog net6.0 2.58μs 1.87ns 7.25ns 0 0 0 1.7 KB
#7433 EnrichedLog netcoreapp3.1 3.34μs 15.2ns 60.9ns 0 0 0 1.7 KB
#7433 EnrichedLog net472 4.01μs 3.1ns 12ns 0.241 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 63.7ns 238ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 128μs 236ns 916ns 0 0 0 4.31 KB
master EnrichedLog net472 168μs 34ns 132ns 0 0 0 4.52 KB
#7433 EnrichedLog net6.0 124μs 63.7ns 221ns 0 0 0 4.31 KB
#7433 EnrichedLog netcoreapp3.1 127μs 247ns 856ns 0 0 0 4.31 KB
#7433 EnrichedLog net472 169μs 191ns 741ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.81μs 13.3ns 49.8ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.86μs 21.1ns 81.7ns 0 0 0 2.26 KB
master EnrichedLog net472 7.61μs 6.53ns 25.3ns 0.305 0 0 2.08 KB
#7433 EnrichedLog net6.0 5.11μs 7.06ns 26.4ns 0 0 0 2.26 KB
#7433 EnrichedLog netcoreapp3.1 6.64μs 31ns 120ns 0 0 0 2.26 KB
#7433 EnrichedLog net472 7.49μs 6.28ns 24.3ns 0.302 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2μs 4.51ns 16.9ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.62μs 10.9ns 42.2ns 0 0 0 1.2 KB
master SendReceive net472 3.11μs 3.11ns 12ns 0.186 0 0 1.2 KB
#7433 SendReceive net6.0 1.94μs 9.56ns 43.8ns 0 0 0 1.2 KB
#7433 SendReceive netcoreapp3.1 2.54μs 12.2ns 53.3ns 0 0 0 1.2 KB
#7433 SendReceive net472 3.09μs 2.64ns 10.2ns 0.185 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.08μs 11.5ns 44.6ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.81μs 10.4ns 40.3ns 0 0 0 1.63 KB
master EnrichedLog net472 6.64μs 6.16ns 23ns 0.295 0 0 2.03 KB
#7433 EnrichedLog net6.0 4.28μs 4.59ns 16.5ns 0 0 0 1.58 KB
#7433 EnrichedLog netcoreapp3.1 5.56μs 13.6ns 51.1ns 0 0 0 1.63 KB
#7433 EnrichedLog net472 6.65μs 10.9ns 42.4ns 0.296 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 764ns 0.204ns 0.735ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 946ns 4.98ns 24.9ns 0 0 0 576 B
master StartFinishSpan net472 900ns 0.07ns 0.262ns 0.0904 0 0 578 B
master StartFinishScope net6.0 873ns 4.69ns 24.4ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.14μs 5.29ns 20.5ns 0 0 0 696 B
master StartFinishScope net472 1.11μs 0.531ns 2.06ns 0.0996 0 0 658 B
#7433 StartFinishSpan net6.0 740ns 1.31ns 4.71ns 0 0 0 576 B
#7433 StartFinishSpan netcoreapp3.1 952ns 0.363ns 1.41ns 0 0 0 576 B
#7433 StartFinishSpan net472 910ns 0.712ns 2.76ns 0.0907 0 0 578 B
#7433 StartFinishScope net6.0 883ns 0.289ns 1.08ns 0 0 0 696 B
#7433 StartFinishScope netcoreapp3.1 1.11μs 5.88ns 31.1ns 0 0 0 696 B
#7433 StartFinishScope net472 1.1μs 0.11ns 0.427ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.03μs 5.22ns 24.5ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.34μs 6.27ns 24.3ns 0 0 0 696 B
master RunOnMethodBegin net472 1.4μs 1.08ns 4.18ns 0.0982 0 0 658 B
#7433 RunOnMethodBegin net6.0 1.03μs 1.62ns 6.27ns 0 0 0 696 B
#7433 RunOnMethodBegin netcoreapp3.1 1.35μs 5.17ns 20ns 0 0 0 696 B
#7433 RunOnMethodBegin net472 1.45μs 1.95ns 7.54ns 0.102 0 0 658 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrewlock