Skip to content

Revert Debugger Refactoring #7399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Revert Debugger Refactoring #7399

wants to merge 2 commits into from

Conversation

andrewlock
Copy link
Member

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@datadog-official Datadog Official
Copy link

datadog-official bot commented Aug 18, 2025 •
edited
Loading

⚠️ Tests

⚠️ Warnings

🧪 5 Tests failed

❄️ Known flaky: TestOk from Datadog.Trace.Security.Unit.Tests.WafUserBlockTests (Datadog) 
Expected result!.ReturnCode to be WafReturnCode.Match {value: 1}, but found WafReturnCode.Ok {value: 0}.
❄️ Known flaky: TestOk from Datadog.Trace.Security.Unit.Tests.WafUserBlockTests (Datadog) 
Expected result!.ReturnCode to be WafReturnCode.Match {value: 1}, but found WafReturnCode.Ok {value: 0}.
❄️ Known flaky: TestOk from Datadog.Trace.Security.Unit.Tests.WafUserBlockTests (Datadog) 
Expected result!.ReturnCode to be WafReturnCode.Match {value: 1}, but found WafReturnCode.Ok {value: 0}.
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 71d3bb1 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Aug 18, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7399 compared to master:

  • All benchmarks have the same speed
  • 1 benchmarks have fewer allocations
  • 4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.6μs 57.5ns 310ns 0 0 0 5.5 KB
master StartStopWithChild netcoreapp3.1 12.9μs 63.9ns 286ns 0 0 0 5.71 KB
master StartStopWithChild net472 22.2μs 124ns 820ns 0.883 0.221 0 6.07 KB
#7399 StartStopWithChild net6.0 10.8μs 60.7ns 379ns 0 0 0 5.49 KB
#7399 StartStopWithChild netcoreapp3.1 13.3μs 67.9ns 311ns 0 0 0 5.69 KB
#7399 StartStopWithChild net472 22.2μs 120ns 679ns 0.957 0.213 0 6.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 945μs 58.2ns 226ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 41.8ns 151ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.2ms 1.32μs 5.1μs 0 0 0 3.31 KB
#7399 WriteAndFlushEnrichedTraces net6.0 969μs 84.7ns 328ns 0 0 0 2.71 KB
#7399 WriteAndFlushEnrichedTraces netcoreapp3.1 1.06ms 3.07μs 11.9μs 0 0 0 2.7 KB
#7399 WriteAndFlushEnrichedTraces net472 1.21ms 457ns 1.77μs 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7399

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 195.79 KB 200.93 KB 5.14 KB 2.62%
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 199.31 KB 204.45 KB 5.14 KB 2.58%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 318μs 1.7μs 8.65μs 0 0 0 173.45 KB
master AllCycleSimpleBody netcoreapp3.1 476μs 489ns 1.83μs 0 0 0 175.64 KB
master AllCycleSimpleBody net472 429μs 102ns 383ns 29.2 0 0 195.79 KB
master AllCycleMoreComplexBody net6.0 328μs 493ns 1.91μs 0 0 0 176.96 KB
master AllCycleMoreComplexBody netcoreapp3.1 504μs 1.31μs 4.72μs 0 0 0 179.06 KB
master AllCycleMoreComplexBody net472 439μs 105ns 408ns 30.2 0 0 199.31 KB
master ObjectExtractorSimpleBody net6.0 324ns 0.179ns 0.694ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 408ns 2.24ns 13.4ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 300ns 0.0668ns 0.25ns 0.0437 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.26μs 26.3ns 102ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.74μs 29.3ns 114ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.66μs 2.08ns 7.79ns 0.599 0 0 3.8 KB
#7399 AllCycleSimpleBody net6.0 329μs 752ns 2.91μs 0 0 0 173.45 KB
#7399 AllCycleSimpleBody netcoreapp3.1 497μs 850ns 3.18μs 0 0 0 175.64 KB
#7399 AllCycleSimpleBody net472 430μs 176ns 659ns 31.2 0 0 200.93 KB
#7399 AllCycleMoreComplexBody net6.0 333μs 1.39μs 5.19μs 0 0 0 176.95 KB
#7399 AllCycleMoreComplexBody netcoreapp3.1 506μs 196ns 760ns 0 0 0 179.06 KB
#7399 AllCycleMoreComplexBody net472 438μs 169ns 655ns 32.3 0 0 204.45 KB
#7399 ObjectExtractorSimpleBody net6.0 335ns 0.36ns 1.35ns 0 0 0 280 B
#7399 ObjectExtractorSimpleBody netcoreapp3.1 408ns 2.28ns 13.7ns 0 0 0 272 B
#7399 ObjectExtractorSimpleBody net472 327ns 0.68ns 2.63ns 0.0446 0 0 281 B
#7399 ObjectExtractorMoreComplexBody net6.0 6.33μs 19.2ns 74.4ns 0 0 0 3.78 KB
#7399 ObjectExtractorMoreComplexBody netcoreapp3.1 7.79μs 35.5ns 138ns 0 0 0 3.69 KB
#7399 ObjectExtractorMoreComplexBody net472 6.78μs 2.75ns 10.3ns 0.577 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 76.5μs 175ns 655ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 97.5μs 341ns 1.32μs 0 0 0 32.4 KB
master EncodeArgs net472 110μs 42.9ns 166ns 4.95 0 0 32.51 KB
master EncodeLegacyArgs net6.0 144μs 41ns 154ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 197μs 337ns 1.17μs 0 0 0 2.14 KB
master EncodeLegacyArgs net472 263μs 75.8ns 293ns 0 0 0 2.16 KB
#7399 EncodeArgs net6.0 78.3μs 42.2ns 152ns 0 0 0 32.4 KB
#7399 EncodeArgs netcoreapp3.1 97.8μs 223ns 833ns 0 0 0 32.4 KB
#7399 EncodeArgs net472 110μs 5.18ns 19.4ns 4.96 0 0 32.51 KB
#7399 EncodeLegacyArgs net6.0 140μs 221ns 855ns 0 0 0 2.15 KB
#7399 EncodeLegacyArgs netcoreapp3.1 198μs 276ns 1.03μs 0 0 0 2.14 KB
#7399 EncodeLegacyArgs net472 265μs 28.8ns 112ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 394μs 110ns 396ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 416μs 79.2ns 296ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 437μs 88.1ns 330ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 286μs 105ns 406ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 306μs 1.49μs 5.96μs 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 314μs 104ns 403ns 0 0 0 2.29 KB
#7399 RunWafRealisticBenchmark net6.0 399μs 22.1ns 85.7ns 0 0 0 4.55 KB
#7399 RunWafRealisticBenchmark netcoreapp3.1 419μs 342ns 1.33μs 0 0 0 4.48 KB
#7399 RunWafRealisticBenchmark net472 432μs 110ns 424ns 0 0 0 4.68 KB
#7399 RunWafRealisticBenchmarkWithAttack net6.0 287μs 109ns 408ns 0 0 0 2.24 KB
#7399 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 302μs 42.7ns 154ns 0 0 0 2.22 KB
#7399 RunWafRealisticBenchmarkWithAttack net472 314μs 46.7ns 181ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 60.8μs 103ns 385ns 0 0 0 14.58 KB
master SendRequest netcoreapp3.1 71.5μs 62.3ns 233ns 0 0 0 17.42 KB
master SendRequest net472 0.00791ns 0.00235ns 0.00911ns 0 0 0 0 b
#7399 SendRequest net6.0 61.2μs 86.5ns 300ns 0 0 0 14.52 KB
#7399 SendRequest netcoreapp3.1 71.8μs 276ns 1.24μs 0 0 0 17.42 KB
#7399 SendRequest net472 0.000745ns 0.000745ns 0.00288ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7399

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 4 B 3 B -1 B -25.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.93ms 1.2μs 4.31μs 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.21ms 11.9μs 65.4μs 0 0 0 640 KB
master OriginalCharSlice net472 2.74ms 92.9ns 360ns 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.36ms 360ns 1.4μs 0 0 0 7 B
master OptimizedCharSlice netcoreapp3.1 1.73ms 307ns 1.19μs 0 0 0 1 B
master OptimizedCharSlice net472 2ms 424ns 1.64μs 0 0 0 0 b
master OptimizedCharSliceWithPool net6.0 804μs 70.9ns 274ns 0 0 0 4 B
master OptimizedCharSliceWithPool netcoreapp3.1 872μs 77.3ns 299ns 0 0 0 0 b
master OptimizedCharSliceWithPool net472 1.13ms 66.9ns 259ns 0 0 0 0 b
#7399 OriginalCharSlice net6.0 1.95ms 1.24μs 4.78μs 0 0 0 640.01 KB
#7399 OriginalCharSlice netcoreapp3.1 2.15ms 5.66μs 21.2μs 0 0 0 640 KB
#7399 OriginalCharSlice net472 2.65ms 377ns 1.46μs 100 0 0 641.95 KB
#7399 OptimizedCharSlice net6.0 1.46ms 99.5ns 372ns 0 0 0 7 B
#7399 OptimizedCharSlice netcoreapp3.1 1.65ms 754ns 2.92μs 0 0 0 1 B
#7399 OptimizedCharSlice net472 1.97ms 343ns 1.33μs 0 0 0 0 b
#7399 OptimizedCharSliceWithPool net6.0 867μs 39.8ns 154ns 0 0 0 3 B
#7399 OptimizedCharSliceWithPool netcoreapp3.1 839μs 76.4ns 296ns 0 0 0 0 b
#7399 OptimizedCharSliceWithPool net472 1.16ms 138ns 517ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 722μs 1.13μs 4.37μs 0 0 0 41.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 696μs 731ns 2.53μs 0 0 0 41.93 KB
master WriteAndFlushEnrichedTraces net472 890μs 3.48μs 13.5μs 8.33 0 0 55.91 KB
#7399 WriteAndFlushEnrichedTraces net6.0 658μs 970ns 3.76μs 0 0 0 41.67 KB
#7399 WriteAndFlushEnrichedTraces netcoreapp3.1 665μs 2.51μs 9.73μs 0 0 0 42.06 KB
#7399 WriteAndFlushEnrichedTraces net472 907μs 2.9μs 11.2μs 4.46 0 0 56.17 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.86μs 0.59ns 2.13ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.55μs 12.3ns 50.7ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.76μs 2.81ns 10.9ns 0.153 0.0139 0 987 B
#7399 ExecuteNonQuery net6.0 1.88μs 9.12ns 38.7ns 0 0 0 1.02 KB
#7399 ExecuteNonQuery netcoreapp3.1 2.52μs 1.17ns 4.23ns 0 0 0 1.02 KB
#7399 ExecuteNonQuery net472 2.79μs 3.4ns 13.2ns 0.151 0.0138 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.77μs 0.517ns 2ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.25μs 7.16ns 26.8ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.62μs 3.88ns 15ns 0.163 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.77μs 8.02ns 31.1ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.46μs 4.26ns 15.9ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.89μs 9.43ns 36.5ns 0.156 0 0 1.1 KB
#7399 CallElasticsearch net6.0 1.71μs 9.05ns 39.4ns 0 0 0 1.03 KB
#7399 CallElasticsearch netcoreapp3.1 2.37μs 11.5ns 47.5ns 0 0 0 1.03 KB
#7399 CallElasticsearch net472 3.71μs 1.81ns 7ns 0.149 0 0 1.04 KB
#7399 CallElasticsearchAsync net6.0 1.84μs 0.882ns 3.42ns 0 0 0 1.01 KB
#7399 CallElasticsearchAsync netcoreapp3.1 2.48μs 12.3ns 50.6ns 0 0 0 1.08 KB
#7399 CallElasticsearchAsync net472 3.84μs 1.27ns 4.93ns 0.174 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.78μs 2.39ns 8.96ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.26μs 8.69ns 31.3ns 0 0 0 952 B
master ExecuteAsync net472 2.49μs 1.02ns 3.95ns 0.138 0 0 915 B
#7399 ExecuteAsync net6.0 1.85μs 2.44ns 8.78ns 0 0 0 952 B
#7399 ExecuteAsync netcoreapp3.1 2.28μs 7ns 27.1ns 0 0 0 952 B
#7399 ExecuteAsync net472 2.45μs 1.39ns 5.18ns 0.134 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.89μs 13.2ns 51.1ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.4μs 18.4ns 71.2ns 0 0 0 2.9 KB
master SendAsync net472 12.4μs 13ns 50.3ns 0.5 0 0 3.18 KB
#7399 SendAsync net6.0 6.99μs 14.7ns 54.9ns 0 0 0 2.36 KB
#7399 SendAsync netcoreapp3.1 8.65μs 29.5ns 110ns 0 0 0 2.9 KB
#7399 SendAsync net472 12.6μs 13.2ns 51ns 0.503 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7399

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 246.65 KB 273.47 KB 26.82 KB 10.88%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 278.53 KB 286.19 KB 7.66 KB 2.75%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 43.7μs 244ns 1.48μs 0 0 0 43.78 KB
master StringConcatBenchmark netcoreapp3.1 45.8μs 166ns 576ns 0 0 0 42.66 KB
master StringConcatBenchmark net472 56.3μs 101ns 364ns 0 0 0 65.54 KB
master StringConcatAspectBenchmark net6.0 472μs 2.34μs 9.93μs 0 0 0 275.91 KB
master StringConcatAspectBenchmark netcoreapp3.1 476μs 2.06μs 7.96μs 0 0 0 246.65 KB
master StringConcatAspectBenchmark net472 419μs 2.2μs 11μs 0 0 0 278.53 KB
#7399 StringConcatBenchmark net6.0 47.5μs 255ns 1.91μs 0 0 0 43.82 KB
#7399 StringConcatBenchmark netcoreapp3.1 55.7μs 647ns 6.44μs 0 0 0 42.86 KB
#7399 StringConcatBenchmark net472 57.4μs 129ns 447ns 0 0 0 65.54 KB
#7399 StringConcatAspectBenchmark net6.0 492μs 1.82μs 9.26μs 0 0 0 276.48 KB
#7399 StringConcatAspectBenchmark netcoreapp3.1 507μs 1.75μs 6.31μs 0 0 0 273.47 KB
#7399 StringConcatAspectBenchmark net472 409μs 2.2μs 12.6μs 0 0 0 286.19 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.57μs 6.87ns 26.6ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.42μs 4.84ns 18.7ns 0 0 0 1.7 KB
master EnrichedLog net472 3.97μs 3.84ns 14.9ns 0.258 0 0 1.64 KB
#7399 EnrichedLog net6.0 2.59μs 3.29ns 12.8ns 0 0 0 1.7 KB
#7399 EnrichedLog netcoreapp3.1 3.75μs 18.7ns 83.8ns 0 0 0 1.7 KB
#7399 EnrichedLog net472 3.91μs 3.66ns 14.2ns 0.254 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 122μs 69.8ns 242ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 130μs 506ns 1.96μs 0 0 0 4.31 KB
master EnrichedLog net472 169μs 80ns 299ns 0 0 0 4.52 KB
#7399 EnrichedLog net6.0 122μs 32.5ns 126ns 0 0 0 4.31 KB
#7399 EnrichedLog netcoreapp3.1 126μs 85.1ns 307ns 0 0 0 4.31 KB
#7399 EnrichedLog net472 167μs 42.7ns 148ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 5.08μs 15.6ns 60.6ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.81μs 18.6ns 72ns 0 0 0 2.26 KB
master EnrichedLog net472 7.55μs 4.68ns 18.1ns 0.301 0 0 2.08 KB
#7399 EnrichedLog net6.0 4.97μs 4.77ns 17.9ns 0 0 0 2.26 KB
#7399 EnrichedLog netcoreapp3.1 6.67μs 15.9ns 59.5ns 0 0 0 2.26 KB
#7399 EnrichedLog net472 7.55μs 8.42ns 32.6ns 0.303 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.04μs 10ns 41.4ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.66μs 4.9ns 19ns 0 0 0 1.2 KB
master SendReceive net472 3.18μs 4.83ns 18.7ns 0.19 0 0 1.2 KB
#7399 SendReceive net6.0 1.99μs 10.1ns 45.4ns 0 0 0 1.2 KB
#7399 SendReceive netcoreapp3.1 2.56μs 10.7ns 41.5ns 0 0 0 1.2 KB
#7399 SendReceive net472 3.23μs 3.51ns 13.6ns 0.178 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.07μs 2ns 7.19ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.67μs 13.3ns 51.6ns 0 0 0 1.63 KB
master EnrichedLog net472 6.67μs 7.2ns 27.9ns 0.297 0 0 2.03 KB
#7399 EnrichedLog net6.0 4.22μs 2.19ns 7.6ns 0 0 0 1.58 KB
#7399 EnrichedLog netcoreapp3.1 5.43μs 20ns 77.5ns 0 0 0 1.63 KB
#7399 EnrichedLog net472 6.59μs 6.29ns 23.5ns 0.297 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 751ns 3.42ns 13.7ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 923ns 4.82ns 25ns 0 0 0 576 B
master StartFinishSpan net472 926ns 1.03ns 3.99ns 0.0881 0 0 578 B
master StartFinishScope net6.0 902ns 4.27ns 18.1ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.11μs 5.36ns 21.4ns 0 0 0 696 B
master StartFinishScope net472 1.11μs 0.862ns 3.34ns 0.0999 0 0 658 B
#7399 StartFinishSpan net6.0 747ns 0.205ns 0.767ns 0 0 0 576 B
#7399 StartFinishSpan netcoreapp3.1 960ns 5.29ns 30.8ns 0 0 0 576 B
#7399 StartFinishSpan net472 904ns 0.256ns 0.992ns 0.0905 0 0 578 B
#7399 StartFinishScope net6.0 907ns 5.21ns 29ns 0 0 0 696 B
#7399 StartFinishScope netcoreapp3.1 1.15μs 5.77ns 26.4ns 0 0 0 696 B
#7399 StartFinishScope net472 1.1μs 0.729ns 2.82ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 0.498ns 1.79ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.41μs 5.46ns 21.1ns 0 0 0 696 B
master RunOnMethodBegin net472 1.38μs 0.211ns 0.817ns 0.104 0 0 658 B
#7399 RunOnMethodBegin net6.0 1.03μs 4.89ns 19.6ns 0 0 0 696 B
#7399 RunOnMethodBegin netcoreapp3.1 1.34μs 1.01ns 3.92ns 0 0 0 696 B
#7399 RunOnMethodBegin net472 1.39μs 0.301ns 1.13ns 0.0976 0 0 658 B

@dd-trace-dotnet-ci-bot
Copy link

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7399) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7399) - mean (68ms)  : 65, 72
     .   : milestone, 68,
    master - mean (69ms)  : 66, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (7399) - mean (1,022ms)  : 996, 1048
     .   : milestone, 1022,
    master - mean (994ms)  : 976, 1012
     .   : milestone, 994,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7399) - mean (107ms)  : 106, 109
     .   : milestone, 107,
    master - mean (107ms)  : 106, 108
     .   : milestone, 107,

    section Baseline
    This PR (7399) - mean (107ms)  : 104, 109
     .   : milestone, 107,
    master - mean (107ms)  : 104, 109
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (7399) - mean (723ms)  : 709, 737
     .   : milestone, 723,
    master - mean (714ms)  : 705, 724
     .   : milestone, 714,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7399) - mean (95ms)  : 93, 96
     .   : milestone, 95,
    master - mean (94ms)  : 93, 95
     .   : milestone, 94,

    section Baseline
    This PR (7399) - mean (94ms)  : 92, 96
     .   : milestone, 94,
    master - mean (93ms)  : 92, 95
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (7399) - mean (683ms)  : 665, 701
     .   : milestone, 683,
    master - mean (670ms)  : 660, 680
     .   : milestone, 670,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7399) - mean (94ms)  : 92, 95
     .   : milestone, 94,
    master - mean (93ms)  : 92, 95
     .   : milestone, 93,

    section Baseline
    This PR (7399) - mean (93ms)  : 90, 95
     .   : milestone, 93,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7399) - mean (608ms)  : 596, 620
     .   : milestone, 608,
    master - mean (606ms)  : 593, 618
     .   : milestone, 606,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7399) - mean (196ms)  : 193, 198
     .   : milestone, 196,
    master - mean (199ms)  : 195, 202
     .   : milestone, 199,

    section Baseline
    This PR (7399) - mean (193ms)  : 189, 197
     .   : milestone, 193,
    master - mean (195ms)  : 190, 200
     .   : milestone, 195,

    section CallTarget+Inlining+NGEN
    This PR (7399) - mean (1,137ms)  : 1105, 1169
     .   : milestone, 1137,
    master - mean (1,121ms)  : 1090, 1151
     .   : milestone, 1121,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7399) - mean (280ms)  : 275, 286
     .   : milestone, 280,
    master - mean (279ms)  : 275, 282
     .   : milestone, 279,

    section Baseline
    This PR (7399) - mean (281ms)  : 272, 289
     .   : milestone, 281,
    master - mean (279ms)  : 273, 285
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (7399) - mean (922ms)  : 901, 943
     .   : milestone, 922,
    master - mean (911ms)  : 890, 933
     .   : milestone, 911,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7399) - mean (279ms)  : 272, 287
     .   : milestone, 279,
    master - mean (272ms)  : 268, 276
     .   : milestone, 272,

    section Baseline
    This PR (7399) - mean (278ms)  : 270, 287
     .   : milestone, 278,
    master - mean (273ms)  : 266, 279
     .   : milestone, 273,

    section CallTarget+Inlining+NGEN
    This PR (7399) - mean (915ms)  : 889, 942
     .   : milestone, 915,
    master - mean (893ms)  : 875, 912
     .   : milestone, 893,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7399) - mean (271ms)  : 266, 275
     .   : milestone, 271,
    master - mean (270ms)  : 265, 275
     .   : milestone, 270,

    section Baseline
    This PR (7399) - mean (271ms)  : 266, 276
     .   : milestone, 271,
    master - mean (271ms)  : 266, 277
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (7399) - mean (809ms)  : 787, 831
     .   : milestone, 809,
    master - mean (815ms)  : 784, 845
     .   : milestone, 815,
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrewlock