[PROD] Update RDS func to deal with empty name tag #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently filesystem metrics -> aws.rds.filesystem.* metrics are being tagged with a empty 'name:' tag. This happens because we are trying to parse the name key's value from the "fileSys" section of the log event, but it has an empty values as seen here: https://a.cl.ly/v1um7p1z which results in an empty tag like this: https://a.cl.ly/WnuEgNNn I think my change will not add the `name` tag if it has an empty value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently filesystem metrics -> aws.rds.filesystem.* metrics are being tagged with an empty 'name:' tag.
This happens because we are trying to parse the name key's value from the "fileSys" section of the log event, but it has an empty values as seen here: https://a.cl.ly/v1um7p1z which results in an empty tag like this: https://a.cl.ly/WnuEgNNn
I think my change will not add the
nametag if it has an empty value.What does this PR do?
Change the function to collect fileSys metrics to deal with an empty
name:tag issue.Motivation
Customer reached out to us about this, we have an issue on the support board.
Additional Notes
Anything else we should know when reviewing?