Improve error message when running integration tests without AWS credentials #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agocs
reviewed
Apr 1, 2021
|
|
||
| if [ -z "$AWS_SECRET_ACCESS_KEY" ]; then | ||
| echo "No AWS credentials were found in the environment." | ||
| echo "Note that only Datadog employees can run these integration tests." |
Contributor
There was a problem hiding this comment.
It's possible for a non-Datadogger to run these tests if they supply their own AWS credentials, no?
Contributor
Author
There was a problem hiding this comment.
Not without modification. The tests expect a specific S3 bucket and IAM role to be in place in the AWS account.
agocs
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Displays a more helpful error message when the integration tests are run without AWS credentials.
Motivation
When a community PR from outside Datadog is submitted, the AWS credentials will not be provided to run the integration tests, and they will fail. We should show a helpful error message so that they know this behavior is expected.
Testing Guidelines
I ran the tests without AWS credentials.
Types of Changes
Check all that apply