Skip to content

Conversation

@Manuthor
Copy link
Contributor

@Manuthor Manuthor commented May 27, 2025

  • Remove all KMS and Findex-server crates

@Manuthor Manuthor force-pushed the move_clap_actions branch from d671736 to 8192ed3 Compare May 27, 2025 05:20
@Manuthor Manuthor requested review from ccorsin and Copilot May 27, 2025 05:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes all clap-based actions and associated modules in the Findex server and CLI, and updates dependency and workflow configurations accordingly. Key changes include:

  • Removal of files under crate/cli/src/actions/findex_server (findex, insert_or_delete, encrypt_and_index, datasets, actions) and console.
  • Updates to Cargo.toml and top-level workspace configuration to reference the new cosmian_findex_cli and cosmian_kms_cli crates.
  • Adjustments to Dockerfile, GitHub workflows, and various scripts to use the new reusable scripts submodule.

Reviewed Changes

Copilot reviewed 242 out of 242 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crate/cli/src/actions/findex_server/findex/mod.rs Removed retrieval function and related KMS handling code.
crate/cli/src/actions/findex_server/findex/insert_or_delete.rs Removed insert/delete actions related to Findex indexing.
crate/cli/src/actions/findex_server/findex/findex_instance.rs Removed instantiation logic for Findex instance with encryption.
crate/cli/src/actions/findex_server/encrypt_and_index.rs Removed encryption and indexing client action implementations.
crate/cli/src/actions/findex_server/datasets.rs Removed dataset management functionality.
crate/cli/src/actions/findex_server/actions.rs Removed the composite Findex actions command implementation.
crate/cli/src/actions/console.rs Removed console output formatting code.
crate/cli/Cargo.toml Updated dependency references and feature lists.
Cargo.toml, .github/*, and scripts Updated configurations to reference new reusable scripts/submodules.
Comments suppressed due to low confidence (3)

crate/cli/src/actions/findex_server/findex/mod.rs:1

  • The entire module has been removed including the retrieve_key_from_kms function; please ensure that all modules previously dependent on this functionality have been updated to use the new implementation or removed accordingly.
use cosmian_crypto_core::{Secret, reexport::zeroize::Zeroizing};

crate/cli/src/actions/findex_server/findex/insert_or_delete.rs:1

  • Since the insert and delete action module has been removed, verify that any command mapping or higher-level orchestration invoking these actions has been updated to reflect the new design.
use std::{ collections::{HashMap, HashSet}, fs::File, path::PathBuf };

crate/cli/Cargo.toml:30

  • The dependency updates in Cargo.toml change the Findex-related crate references; please double-check that all public APIs and integration points are compatible with these replacements.
"cosmian_findex_cli/fips",

@Manuthor Manuthor requested a review from bgrieder May 27, 2025 13:06
@Manuthor Manuthor merged commit c1518e6 into develop May 27, 2025
17 checks passed
@Manuthor Manuthor deleted the move_clap_actions branch May 27, 2025 14:59
@Manuthor Manuthor mentioned this pull request Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants