chore: use cosmian_logger #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes logging throughout the Cosmian CLI codebase by replacing direct tracing imports with the cosmian_logger facade. This change consolidates logging functionality under a unified interface while maintaining the same underlying tracing capabilities.
Key changes:
- Replace
use tracing::*imports withuse cosmian_logger::*equivalents - Update Cargo.toml dependencies to reflect the logging library changes
- Maintain existing log macro call patterns with the new import sources
Reviewed Changes
Copilot reviewed 36 out of 37 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crate/pkcs11/provider/src/*.rs | Replace tracing imports with cosmian_logger for error, debug, trace macros |
| crate/pkcs11/module/src/*.rs | Replace tracing imports with cosmian_logger for debug, error, info, trace macros |
| crate/cli/src/tests/kms/**/*.rs | Replace tracing imports with cosmian_logger for various log level macros |
| crate/cli/src/*.rs | Replace tracing imports with cosmian_logger for debug, info, trace macros |
| */Cargo.toml | Update dependencies to use cosmian_logger instead of direct tracing dependency |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.